dev.dpdk.org archive mirror
 help / color / mirror / Atom feed
From: Andy Pei <andy.pei@intel.com>
To: dev@dpdk.org
Cc: andy.pei@intel.com, rosen.xu@intel.com
Subject: [dpdk-dev] [PATCH v3 2/4] net/ipn3ke: delete MAC register address mask
Date: Wed, 19 Jun 2019 16:49:32 +0800	[thread overview]
Message-ID: <1560934174-408632-2-git-send-email-andy.pei@intel.com> (raw)
In-Reply-To: <1560934174-408632-1-git-send-email-andy.pei@intel.com>

original code is compatible with older device,
whose mac register address is no more than 10 bits.
Now we have mac register address longer than 10 bits,
so we just delete the mask here.

Fixes: c01c748e4ae6 ("net/ipn3ke: add new driver")
Cc: rosen.xu@intel.com

Signed-off-by: Andy Pei <andy.pei@intel.com>
---
 drivers/net/ipn3ke/ipn3ke_ethdev.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/drivers/net/ipn3ke/ipn3ke_ethdev.c b/drivers/net/ipn3ke/ipn3ke_ethdev.c
index 9079b57..8d3084d 100644
--- a/drivers/net/ipn3ke/ipn3ke_ethdev.c
+++ b/drivers/net/ipn3ke/ipn3ke_ethdev.c
@@ -48,7 +48,6 @@
 	if (eth_group_sel != 0 && eth_group_sel != 1)
 		return -1;
 
-	addr &= 0x3FF;
 	target_addr = addr | dev_sel << 17;
 
 	indirect_value = RCMD | target_addr << 32;
@@ -86,7 +85,6 @@
 	if (eth_group_sel != 0 && eth_group_sel != 1)
 		return -1;
 
-	addr &= 0x3FF;
 	target_addr = addr | dev_sel << 17;
 
 	indirect_value = WCMD | target_addr << 32 | wr_data;
-- 
1.8.3.1


  reply	other threads:[~2019-06-19  8:56 UTC|newest]

Thread overview: 47+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-06-03  6:31 [dpdk-dev] [PATCH 1/2] net/ipn3ke: add new register address Andy Pei
2019-06-03  6:31 ` [dpdk-dev] [PATCH 2/2] net/ipn3ke: implementation of statistics Andy Pei
2019-06-11  9:48   ` [dpdk-dev] [PATCH v2 1/4] net/ipn3ke: add new register address Andy Pei
2019-06-11  9:48     ` [dpdk-dev] [PATCH v2 2/4] net/ipn3ke: delete MAC register address mask Andy Pei
2019-06-12  1:17       ` Xu, Rosen
2019-06-11  9:48     ` [dpdk-dev] [PATCH v2 3/4] net/ipn3ke: clear statistics when init and start dev Andy Pei
2019-06-12  1:17       ` Xu, Rosen
2019-06-19  8:49       ` [dpdk-dev] [PATCH v3 1/4] net/ipn3ke: add new register address Andy Pei
2019-06-19  8:49         ` Andy Pei [this message]
2019-06-19  8:49         ` [dpdk-dev] [PATCH v3 3/4] net/ipn3ke: clear statistics when init and start dev Andy Pei
2019-06-19  8:49         ` [dpdk-dev] [PATCH v3 4/4] net/ipn3ke: implementation of statistics Andy Pei
2019-06-19  9:05           ` David Marchand
2019-06-25  7:09             ` Pei, Andy
2019-06-25  7:16               ` David Marchand
2019-06-25  8:53                 ` Pei, Andy
2019-06-25  8:58                   ` David Marchand
2019-06-27  6:02                     ` Pei, Andy
2019-06-25  7:50           ` [dpdk-dev] [PATCH v4 1/4] net/ipn3ke: add new register address Andy Pei
2019-06-25  7:50             ` [dpdk-dev] [PATCH v4 2/4] net/ipn3ke: delete MAC register address mask Andy Pei
2019-06-25  7:50             ` [dpdk-dev] [PATCH v4 3/4] net/ipn3ke: clear statistics when init and start dev Andy Pei
2019-06-25  7:50             ` [dpdk-dev] [PATCH v4] net/ipn3ke: implementation of statistics Andy Pei
2019-06-25  8:00           ` [dpdk-dev] [PATCH v4 1/4] net/ipn3ke: add new register address Andy Pei
2019-06-25  8:00             ` [dpdk-dev] [PATCH v4 2/4] net/ipn3ke: delete MAC register address mask Andy Pei
2019-06-25  8:00             ` [dpdk-dev] [PATCH v4 3/4] net/ipn3ke: clear statistics when init and start dev Andy Pei
2019-06-25  8:00             ` [dpdk-dev] [PATCH v4 4/4] net/ipn3ke: implementation of statistics Andy Pei
2019-06-27  5:49               ` Xu, Rosen
2019-06-28  8:54                 ` Pei, Andy
2019-07-01 10:36               ` [dpdk-dev] [PATCH v5 1/4] net/ipn3ke: add new register address Andy Pei
2019-07-01 10:36                 ` [dpdk-dev] [PATCH v5 2/4] net/ipn3ke: delete MAC register address mask Andy Pei
2019-07-02 10:00                   ` Xu, Rosen
2019-07-08  2:06                     ` Zhang, Qi Z
2019-07-01 10:36                 ` [dpdk-dev] [PATCH v5 3/4] net/ipn3ke: clear statistics when init and start dev Andy Pei
2019-07-02 10:00                   ` Xu, Rosen
2019-07-08  2:07                     ` Zhang, Qi Z
2019-07-01 10:36                 ` [dpdk-dev] [PATCH v5 4/4] net/ipn3ke: implementation of statistics Andy Pei
2019-07-02 10:01                   ` Xu, Rosen
2019-07-08  2:09                     ` Zhang, Qi Z
2019-07-02  9:59                 ` [dpdk-dev] [PATCH v5 1/4] net/ipn3ke: add new register address Xu, Rosen
2019-07-08  2:06                   ` Zhang, Qi Z
2019-07-08 16:00                 ` Ferruh Yigit
2019-07-09  1:33                   ` Pei, Andy
2019-06-11  9:48     ` [dpdk-dev] [PATCH v2 4/4] net/ipn3ke: implementation of statistics Andy Pei
2019-06-12  1:17       ` Xu, Rosen
2019-06-18 11:59       ` Ferruh Yigit
2019-06-18 12:39         ` Ferruh Yigit
2019-06-19  3:23           ` Pei, Andy
2019-06-12  1:17     ` [dpdk-dev] [PATCH v2 1/4] net/ipn3ke: add new register address Xu, Rosen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1560934174-408632-2-git-send-email-andy.pei@intel.com \
    --to=andy.pei@intel.com \
    --cc=dev@dpdk.org \
    --cc=rosen.xu@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).