From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, MENTIONS_GIT_HOSTING,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4AFD9C606A1 for ; Mon, 8 Jul 2019 09:38:30 +0000 (UTC) Received: from dpdk.org (dpdk.org [92.243.14.124]) by mail.kernel.org (Postfix) with ESMTP id D6F3920659 for ; Mon, 8 Jul 2019 09:38:29 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=monjalon.net header.i=@monjalon.net header.b="Iapi8l15"; dkim=pass (2048-bit key) header.d=messagingengine.com header.i=@messagingengine.com header.b="jFA6Qi+4" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org D6F3920659 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=monjalon.net Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=dev-bounces@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id C285337B0; Mon, 8 Jul 2019 11:38:28 +0200 (CEST) Received: from new2-smtp.messagingengine.com (new2-smtp.messagingengine.com [66.111.4.224]) by dpdk.org (Postfix) with ESMTP id 33B392E81 for ; Mon, 8 Jul 2019 11:38:27 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailnew.nyi.internal (Postfix) with ESMTP id 7E86320CC; Mon, 8 Jul 2019 05:38:25 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute1.internal (MEProxy); Mon, 08 Jul 2019 05:38:25 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=mesmtp; bh=crTziCgbRP+h0aWWT8VXuXz9LOgTBBC2o0+nMMhqr40=; b=Iapi8l15bJhx 1P5TjamjbSJpmtCEQFY16pp11FuMyJ5jtX7f6LV5AFCueUrv0XnDvVjbJ9Q27kHh C7ZibOkU/k4lwQM6r03sPAzKCCqZBq+ktFGQ2Vkca0CPhFGfdlGLMUsbBxeruChz 6wu7u9/9eeNkMTnbWOr/+7wPRBTeRfY= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm3; bh=crTziCgbRP+h0aWWT8VXuXz9LOgTBBC2o0+nMMhqr 40=; b=jFA6Qi+4DTVFsXKjErSY4N6p5ubkDXfIlov9p90RRMPNrL9gwHt24lFaQ jbgJb5yS4RHMSPtUjvsrAj0og8DTD8ptjKmCAj+6ejxe7sM0RAWPBqtSNHU5XnG5 AZc8rH0kfsasG+TQnnLKfOPGhX9EmmCKBYGWuqZhzgJ5ioCUqDPp3QPkhGPh0XBt Z9tvYFptF84zjtUeZhn8G80Sf7nYgMOW+6duAB3nBcsy2Wz8d7PMDYfkabu3gmKQ 8EXBjkl1xbALwFdaET7w6RLMN3ggfyPxv3rg66Ds0xb6bNOsaUFgVtbPOwe5szTa iY8AmFyzHQv4/QyhOnJ4BsDAIXy1w== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduvddrgedtgddukecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefhvffufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhmrghs ucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenucffoh hmrghinhepughpughkrdhorhhgnecukfhppeejjedrudefgedrvddtfedrudekgeenucfr rghrrghmpehmrghilhhfrhhomhepthhhohhmrghssehmohhnjhgrlhhonhdrnhgvthenuc evlhhushhtvghrufhiiigvpedt X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id C11C98005A; Mon, 8 Jul 2019 05:38:21 -0400 (EDT) From: Thomas Monjalon To: "Burakov, Anatoly" Cc: dev@dpdk.org, Neil Horman , John McNamara , Marko Kovacevic , Konstantin Ananyev , David Hunt , Bruce Richardson , Byron Marohn , Pablo de Lara Guarch , Yipeng Wang , Sameh Gobriel , Vladimir Medvedkin , Olivier Matz , Andrew Rybchenko , Honnappa Nagarahalli , Reshma Pattan , david.marchand@redhat.com, stephen@networkplumber.org Date: Mon, 08 Jul 2019 11:38:20 +0200 Message-ID: <156259344.1lfZDpRt24@xps> In-Reply-To: <74c0d876-5a61-485f-aed6-3422b0e9f313@intel.com> References: <4007509.ZM762vluVm@xps> <74c0d876-5a61-485f-aed6-3422b0e9f313@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v5 4/9] eal: hide shared memory config X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 08/07/2019 11:22, Burakov, Anatoly: > On 05-Jul-19 8:08 PM, Thomas Monjalon wrote: > > 05/07/2019 19:26, Anatoly Burakov: > >> --- a/lib/librte_eal/common/include/rte_fbarray.h > >> +++ b/lib/librte_eal/common/include/rte_fbarray.h > >> @@ -34,7 +34,6 @@ > >> extern "C" { > >> #endif > >> > >> -#include > >> #include > > > > It triggers some compilation errors in mlx4 and mlx5: > > fatal error: unknown type name 'bool' > > I will try to fix them. > > They probably need to include stdbool. Not removing these broke > everything else... I should get a mlx compilation setup. You can check the changes I did in mlx4/mlx5 to fix compilation: http://git.dpdk.org/dpdk/commit/?id=028669bc9f0 bool type was over used in some places. About checking mlx compilation, you just need to install rdma-core which is packaged in all good distributions.