[dpdk-dev] [PATCH] net/mlx5: fix interrupt install

[dpdk-dev] [PATCH] net/mlx5: fix interrupt install

[Matan Azrad]

The error path of interrupt install was done in any way.
Fix it to skip error path in case of success.

Fixes: 0134353a5951 ("net/mlx5: accelerate DV flow counter query")

Signed-off-by: Matan Azrad <matan@mellanox.com>
---
 drivers/net/mlx5/mlx5_ethdev.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/net/mlx5/mlx5_ethdev.c b/drivers/net/mlx5/mlx5_ethdev.c
index fdd6e03..6c9bcf1 100644
--- a/drivers/net/mlx5/mlx5_ethdev.c
+++ b/drivers/net/mlx5/mlx5_ethdev.c
@@ -1620,6 +1620,7 @@ int mlx5_fw_version_get(struct rte_eth_dev *dev, char *fw_ver, size_t fw_size)
 #endif /* HAVE_IBV_DEVX_ASYNC */
 	}
 	sh->intr_cnt++;
+	goto exit;
 error_unregister:
 	rte_intr_callback_unregister(&sh->intr_handle,
 				     mlx5_dev_interrupt_handler, sh);
-- 
1.8.3.1

Re: [dpdk-dev] [PATCH] net/mlx5: fix interrupt install

[Slava Ovsiienko]

> -----Original Message-----
> From: Matan Azrad <matan@mellanox.com>
> Sent: Sunday, July 21, 2019 11:17
> To: Shahaf Shuler <shahafs@mellanox.com>; Yongseok Koh
> <yskoh@mellanox.com>; Slava Ovsiienko <viacheslavo@mellanox.com>
> Cc: dev@dpdk.org
> Subject: [PATCH] net/mlx5: fix interrupt install
> 
> The error path of interrupt install was done in any way.
> Fix it to skip error path in case of success.
> 
> Fixes: 0134353a5951 ("net/mlx5: accelerate DV flow counter query")
> 
> Signed-off-by: Matan Azrad <matan@mellanox.com>
Acked-by: Viacheslav Ovsiienko <viacheslavo@mellanox.com>

Re: [dpdk-dev] [PATCH] net/mlx5: fix interrupt install

[Raslan Darawsheh]

Hi,

> -----Original Message-----
> From: dev <dev-bounces@dpdk.org> On Behalf Of Matan Azrad
> Sent: Sunday, July 21, 2019 11:17 AM
> To: Shahaf Shuler <shahafs@mellanox.com>; Yongseok Koh
> <yskoh@mellanox.com>; Slava Ovsiienko <viacheslavo@mellanox.com>
> Cc: dev@dpdk.org
> Subject: [dpdk-dev] [PATCH] net/mlx5: fix interrupt install
> 
> The error path of interrupt install was done in any way.
> Fix it to skip error path in case of success.
> 
> Fixes: 0134353a5951 ("net/mlx5: accelerate DV flow counter query")
> 
> Signed-off-by: Matan Azrad <matan@mellanox.com>
> ---
>  drivers/net/mlx5/mlx5_ethdev.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/net/mlx5/mlx5_ethdev.c
> b/drivers/net/mlx5/mlx5_ethdev.c
> index fdd6e03..6c9bcf1 100644
> --- a/drivers/net/mlx5/mlx5_ethdev.c
> +++ b/drivers/net/mlx5/mlx5_ethdev.c
> @@ -1620,6 +1620,7 @@ int mlx5_fw_version_get(struct rte_eth_dev *dev,
> char *fw_ver, size_t fw_size)
>  #endif /* HAVE_IBV_DEVX_ASYNC */
>  	}
>  	sh->intr_cnt++;
> +	goto exit;
>  error_unregister:
>  	rte_intr_callback_unregister(&sh->intr_handle,
>  				     mlx5_dev_interrupt_handler, sh);
> --
> 1.8.3.1

Patch applied to next-net-mlx,

Kindest regards,
Raslan Darawsheh