DPDK-dev Archive on lore.kernel.org
 help / color / Atom feed
* [dpdk-dev] net/i40e: fix vf runtime queues rss config
@ 2019-08-07  0:09 Xiao Zhang
  2019-08-08 16:41 ` [dpdk-dev] [v2] " Xiao Zhang
  0 siblings, 1 reply; 16+ messages in thread
From: Xiao Zhang @ 2019-08-07  0:09 UTC (permalink / raw)
  To: dev; +Cc: qi.z.zhang, beilei.xing, Xiao Zhang, stable

I40evf queue can not work properly with kernel pf driver. Eg. when
configured to use 8 queue pairs, only 4 queues can receive packets, and
half packets will be lost if using 2 queue pairs.
This issue is caused by misconfiguration of look up table, use aq command
to setup the lut to make it work properly.

Fixes: cea7a51c1750 ("i40evf: support RSS")
Cc: stable@dpdk.org

Signed-off-by: Xiao Zhang <xiao.zhang@intel.com>
---
 drivers/net/i40e/i40e_ethdev_vf.c | 35 ++++++++++++++++++++++++++++-------
 1 file changed, 28 insertions(+), 7 deletions(-)

diff --git a/drivers/net/i40e/i40e_ethdev_vf.c b/drivers/net/i40e/i40e_ethdev_vf.c
index 308fb98..43ce2bd 100644
--- a/drivers/net/i40e/i40e_ethdev_vf.c
+++ b/drivers/net/i40e/i40e_ethdev_vf.c
@@ -2574,6 +2574,25 @@ i40evf_hw_rss_hash_set(struct i40e_vf *vf, struct rte_eth_rss_conf *rss_conf)
 	if (ret)
 		return ret;
 
+	if (vf->flags & I40E_FLAG_RSS_AQ_CAPABLE) {
+		uint8_t *lut;
+		uint32_t rss_lut_size = (I40E_VFQF_HLUT1_MAX_INDEX + 1) * 4;
+		lut = rte_zmalloc("i40e_rss_lut", rss_lut_size, 0);
+		if (!lut) {
+			PMD_DRV_LOG(ERR, "No memory can be allocated");
+			return -ENOMEM;
+		}
+
+		for (uint32_t i = 0; i < rss_lut_size; i++)
+			lut[i] = i % vf->num_queue_pairs;
+
+		ret = i40evf_set_rss_lut(&vf->vsi, lut,
+					 rss_lut_size);
+		rte_free(lut);
+		if (ret)
+			return ret;
+	}
+
 	hena = i40e_config_hena(vf->adapter, rss_conf->rss_hf);
 	i40e_write_rx_ctl(hw, I40E_VFQF_HENA(0), (uint32_t)hena);
 	i40e_write_rx_ctl(hw, I40E_VFQF_HENA(1), (uint32_t)(hena >> 32));
@@ -2607,13 +2626,15 @@ i40evf_config_rss(struct i40e_vf *vf)
 	}
 
 	num = RTE_MIN(vf->dev_data->nb_rx_queues, I40E_MAX_QP_NUM_PER_VF);
-	/* Fill out the look up table */
-	for (i = 0, j = 0; i < nb_q; i++, j++) {
-		if (j >= num)
-			j = 0;
-		lut = (lut << 8) | j;
-		if ((i & 3) == 3)
-			I40E_WRITE_REG(hw, I40E_VFQF_HLUT(i >> 2), lut);
+	if (!(vf->flags & I40E_FLAG_RSS_AQ_CAPABLE)) {
+		/* Fill out the look up table */
+		for (i = 0, j = 0; i < nb_q; i++, j++) {
+			if (j >= num)
+				j = 0;
+			lut = (lut << 8) | j;
+			if ((i & 3) == 3)
+				I40E_WRITE_REG(hw, I40E_VFQF_HLUT(i >> 2), lut);
+		}
 	}
 
 	rss_conf = vf->dev_data->dev_conf.rx_adv_conf.rss_conf;
-- 
2.7.4


^ permalink raw reply	[flat|nested] 16+ messages in thread

end of thread, back to index

Thread overview: 16+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-08-07  0:09 [dpdk-dev] net/i40e: fix vf runtime queues rss config Xiao Zhang
2019-08-08 16:41 ` [dpdk-dev] [v2] " Xiao Zhang
2019-08-09  2:44   ` Xing, Beilei
2019-08-09  3:25     ` Zhang, Xiao
2019-08-12 10:29   ` [dpdk-dev] [v3] " Xiao Zhang
2019-08-12 17:43     ` [dpdk-dev] [v4] " Xiao Zhang
2019-08-12 12:07       ` Aaron Conole
2019-08-13  1:43       ` Xing, Beilei
2019-08-13 10:40       ` [dpdk-dev] [v5] " Xiao Zhang
2019-08-13  2:21         ` Xing, Beilei
2019-08-13  6:28         ` Ye Xiaolong
2019-08-13  7:24           ` Zhang, Xiao
2019-08-13  7:37             ` Ye Xiaolong
2019-08-13  7:59               ` Zhang, Xiao
2019-08-13 22:17         ` [dpdk-dev] [v6] " Xiao Zhang
2019-08-13 14:55           ` Ye Xiaolong

DPDK-dev Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/dpdk-dev/0 dpdk-dev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 dpdk-dev dpdk-dev/ https://lore.kernel.org/dpdk-dev \
		dev@dpdk.org dpdk-dev@archiver.kernel.org
	public-inbox-index dpdk-dev

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.dpdk.dev


AGPL code for this site: git clone https://public-inbox.org/ public-inbox