[dpdk-dev] [PATCH] net/mlx5: fix compiling without definition

[dpdk-dev] [PATCH] net/mlx5: fix compiling without definition

[Bing Zhao]

When compiling the driver without macro for direct rules, the flow
table reference count should also be in the flow table resource
structure.

Fixes: c7455199284a ("net/mlx5: reorganize flow tables with hash list")

Signed-off-by: Bing Zhao <bingz@mellanox.com>
---
 drivers/net/mlx5/mlx5.h | 2 --
 1 file changed, 2 deletions(-)

diff --git a/drivers/net/mlx5/mlx5.h b/drivers/net/mlx5/mlx5.h
index 3296f10..feac5a3 100644
--- a/drivers/net/mlx5/mlx5.h
+++ b/drivers/net/mlx5/mlx5.h
@@ -587,9 +587,7 @@ struct mlx5_ibv_shared_port {
 /* Table structure. */
 struct mlx5_flow_tbl_resource {
 	void *obj; /**< Pointer to DR table object. */
-#ifdef HAVE_MLX5DV_DR
 	rte_atomic32_t refcnt; /**< Reference counter. */
-#endif
 };
 
 #define MLX5_MAX_TABLES UINT16_MAX
-- 
1.8.3.1

Re: [dpdk-dev] [PATCH] net/mlx5: fix compiling without definition

[Slava Ovsiienko]

> -----Original Message-----
> From: Bing Zhao <bingz@mellanox.com>
> Sent: Sunday, November 10, 2019 18:37
> To: Slava Ovsiienko <viacheslavo@mellanox.com>; Raslan Darawsheh
> <rasland@mellanox.com>
> Cc: Ori Kam <orika@mellanox.com>; dev@dpdk.org
> Subject: [PATCH] net/mlx5: fix compiling without definition
> 
> When compiling the driver without macro for direct rules, the flow table
> reference count should also be in the flow table resource structure.
> 
> Fixes: c7455199284a ("net/mlx5: reorganize flow tables with hash list")
> 
> Signed-off-by: Bing Zhao <bingz@mellanox.com>
Acked-by: Viacheslav Ovsiienko <viacheslavo@mellanox.com>

Re: [dpdk-dev] [PATCH] net/mlx5: fix compiling without definition

[Ferruh Yigit]

On 11/11/2019 7:00 AM, Slava Ovsiienko wrote:
>> -----Original Message-----
>> From: Bing Zhao <bingz@mellanox.com>
>> Sent: Sunday, November 10, 2019 18:37
>> To: Slava Ovsiienko <viacheslavo@mellanox.com>; Raslan Darawsheh
>> <rasland@mellanox.com>
>> Cc: Ori Kam <orika@mellanox.com>; dev@dpdk.org
>> Subject: [PATCH] net/mlx5: fix compiling without definition
>>
>> When compiling the driver without macro for direct rules, the flow table
>> reference count should also be in the flow table resource structure.
>>
>> Fixes: c7455199284a ("net/mlx5: reorganize flow tables with hash list")
>>
>> Signed-off-by: Bing Zhao <bingz@mellanox.com>
> Acked-by: Viacheslav Ovsiienko <viacheslavo@mellanox.com>
> 

Squashed into relevant commit in next-net, thanks.

Please confirm the change in latest next-net.