From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.1 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,URIBL_SBL,URIBL_SBL_A autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6C093C7618F for ; Mon, 22 Jul 2019 17:03:08 +0000 (UTC) Received: from dpdk.org (dpdk.org [92.243.14.124]) by mail.kernel.org (Postfix) with ESMTP id 00DB221901 for ; Mon, 22 Jul 2019 17:03:07 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=monjalon.net header.i=@monjalon.net header.b="AmsV+QJd"; dkim=pass (2048-bit key) header.d=messagingengine.com header.i=@messagingengine.com header.b="yedjnGIq" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 00DB221901 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=monjalon.net Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=dev-bounces@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 0E98D1BF29; Mon, 22 Jul 2019 19:03:07 +0200 (CEST) Received: from wout2-smtp.messagingengine.com (wout2-smtp.messagingengine.com [64.147.123.25]) by dpdk.org (Postfix) with ESMTP id 7D26D1BF19 for ; Mon, 22 Jul 2019 19:03:05 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.west.internal (Postfix) with ESMTP id 556E12D8; Mon, 22 Jul 2019 13:03:04 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute1.internal (MEProxy); Mon, 22 Jul 2019 13:03:04 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=mesmtp; bh=3WYrEN5tks6NjAqlEQF5Efe6xAYKAb4kQZBUx/2RGXo=; b=AmsV+QJdof3L tSH+aLD7BR4ZnS/rRXOghoF65gYt/hhZHQvTK1wOKSBmOGEuIj09u2VUIU5SyysT rGMNIhMLOkh5odJnp9xqu4bkkSxreRv1PU5v+Whn1J9I8zQsYXKs98dMBx1xTIvd wFqNnJTA1dKMZy9uH7VoUPpRnB62Hac= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm3; bh=3WYrEN5tks6NjAqlEQF5Efe6xAYKAb4kQZBUx/2RG Xo=; b=yedjnGIqNn6Yr+5D/umTE6bPd9zMxvj+0Q8SphXTeuEH6Ws+CrVkMm0+Y tiMoKsiW2qdr7dIsKuvLlKgwg2qI44jx82Hoh4F6z5U1jWZUWX3TIU2hrzZhx+T0 UMxaIZU5V0BliBcXaplV5TH0pRred0y1Bonq6w8J8ScPz0sNhkzTHaTrC2t6rNq/ IXRj56VRn7P20Pt4xBoJkwtxI+toRVU8Vje1js25CCcTRLWXuEJCxPee1EXhwssG N1cTwGqG9VfAtdSc827xL4ISFmKVY52vJJ6FeiZ6fsiwYDmkwArIw1sFMn5eAW6/ /aQjMJQchQv5SBoraymZ97s1UDkHQ== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduvddrjeeggdduudduucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucenucfjughrpefhvffufffkjghfggfgtgesthfure dttddtvdenucfhrhhomhepvfhhohhmrghsucfoohhnjhgrlhhonhcuoehthhhomhgrshes mhhonhhjrghlohhnrdhnvghtqeenucfkphepjeejrddufeegrddvtdefrddukeegnecurf grrhgrmhepmhgrihhlfhhrohhmpehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtnecu vehluhhsthgvrhfuihiivgeptd X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 619A4380083; Mon, 22 Jul 2019 13:03:02 -0400 (EDT) From: Thomas Monjalon To: anatoly.burakov@intel.com Cc: dev@dpdk.org Date: Mon, 22 Jul 2019 19:03:00 +0200 Message-ID: <1594287.eYpNOEoKs5@xps> In-Reply-To: <20190722165505.14745-1-thomas@monjalon.net> References: <20190718093432.14092-1-thomas@monjalon.net> <20190722165505.14745-1-thomas@monjalon.net> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v2] eal: warn on legacy memory allocation requirement X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 22/07/2019 18:55, Thomas Monjalon: > When using --no-huge mode, dynamic allocation is not supported. > Because of this limitation, the option --legacy-mem is implied > and -m may be needed to specify the amount of memory to allocate. > Otherwise the default amount MEMSIZE_IF_NO_HUGE_PAGE will be allocated. > > Signed-off-by: Thomas Monjalon > --- > v2: > - user-oriented message > - trigger warning on any legacy mem option > --- > --- a/lib/librte_eal/common/eal_common_options.c > +++ b/lib/librte_eal/common/eal_common_options.c > + if (internal_cfg->legacy_mem && internal_cfg->memory == 0) { > + RTE_LOG(NOTICE, EAL, "Selected memory layout is static, " > + "allocation can be increased with the option -m\n"); Or better: "Static memory layout is selected, " "allocation can be increased with the option -m\n"