dev.dpdk.org archive mirror
 help / color / mirror / Atom feed
From: Thomas Monjalon <thomas@monjalon.net>
To: "Dumitrescu, Cristian" <cristian.dumitrescu@intel.com>
Cc: dev@dpdk.org, David Marchand <david.marchand@redhat.com>
Subject: Re: [dpdk-dev] [PATCH] test/table: skip when not enough memory is available
Date: Fri, 05 Jul 2019 22:47:16 +0200	[thread overview]
Message-ID: <1667102.eNUTlEWTa7@xps> (raw)
In-Reply-To: <3EB4FA525960D640B5BDFFD6A3D891268E8EB23B@IRSMSX108.ger.corp.intel.com>

Hi,

05/07/2019 19:54, Dumitrescu, Cristian:
> From: David Marchand [mailto:david.marchand@redhat.com]
> > Following empirical tries, this test wants at least 3300M of memory to
> > run.
> > 
> > Signed-off-by: David Marchand <david.marchand@redhat.com>
> 
> Yes, some tests need large amounts of memory.

Basic tests should not.

> I understand your proposal, but it feels
> a bit like a hack for this test.

Of course it is a hack, probably on purpose to show the issue :)

> Could we create a more generic fix?
> 
> Expanding on your idea, could we wrap this code
> into a macro such as TEST_CHECK_FOR_LARGE_MEMORY(memsize_in_gb)
> that could live in test.h and call it for this test
> (and potentially others that have the same requirements)?

I don't see what it would improve.

> Or maybe people have a better idea?

Yes, a better idea is to reduce the requirements.
Requiring more than 3GB for a unit test is not reasonnable.
If you want to stress the algorithm, then it is a performance test,
and it won't be launched on basic CI.

So there are 2 proposals here:
	- use small memory amount
	- classify as perf test
Please choose one of these two, but neither the hack above,
nor a macro to hide the hack.
Thanks



      reply	other threads:[~2019-07-05 20:47 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-07-05  9:19 [dpdk-dev] [PATCH] test/table: skip when not enough memory is available David Marchand
2019-07-05 17:54 ` Dumitrescu, Cristian
2019-07-05 20:47   ` Thomas Monjalon [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1667102.eNUTlEWTa7@xps \
    --to=thomas@monjalon.net \
    --cc=cristian.dumitrescu@intel.com \
    --cc=david.marchand@redhat.com \
    --cc=dev@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).