[dpdk-dev] [PATCH] maintainers: add Windows exports script

[dpdk-dev] [PATCH] maintainers: add Windows exports script

[Thomas Monjalon]

A script used with meson was missing in the list of files.

Fixes: 4c773788e05a ("build: generate Windows exports file")
Cc: bruce.richardson@intel.com

Signed-off-by: Thomas Monjalon <thomas@monjalon.net>
---
 MAINTAINERS | 1 +
 1 file changed, 1 insertion(+)

diff --git a/MAINTAINERS b/MAINTAINERS
index 0212fe6d0..fdc083db9 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -117,6 +117,7 @@ F: lib/librte_eal/freebsd/BSDmakefile.meson
 F: meson_options.txt
 F: config/rte_config.h
 F: buildtools/gen-pmdinfo-cfile.sh
+F: buildtools/map_to_def.py
 F: buildtools/symlink-drivers-solibs.sh
 
 Public CI
-- 
2.21.0

Re: [dpdk-dev] [PATCH] maintainers: add Windows exports script

[David Marchand]

On Thu, Jun 13, 2019 at 4:12 PM Thomas Monjalon <thomas@monjalon.net> wrote:

> A script used with meson was missing in the list of files.
>
> Fixes: 4c773788e05a ("build: generate Windows exports file")
> Cc: bruce.richardson@intel.com
>
> Signed-off-by: Thomas Monjalon <thomas@monjalon.net>
> ---
>  MAINTAINERS | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/MAINTAINERS b/MAINTAINERS
> index 0212fe6d0..fdc083db9 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -117,6 +117,7 @@ F: lib/librte_eal/freebsd/BSDmakefile.meson
>  F: meson_options.txt
>  F: config/rte_config.h
>  F: buildtools/gen-pmdinfo-cfile.sh
> +F: buildtools/map_to_def.py
>  F: buildtools/symlink-drivers-solibs.sh
>
>  Public CI
>

Reviewed-by: David Marchand <david.marchand@redhat.com>

-- 
David Marchand

Re: [dpdk-dev] [PATCH] maintainers: add Windows exports script

[Thomas Monjalon]

13/06/2019 17:11, Thomas Monjalon:
> A script used with meson was missing in the list of files.
> 
> Fixes: 4c773788e05a ("build: generate Windows exports file")
> Cc: bruce.richardson@intel.com
> 
> Signed-off-by: Thomas Monjalon <thomas@monjalon.net>


Bruce, do you agree with following addition?

> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -117,6 +117,7 @@ F: lib/librte_eal/freebsd/BSDmakefile.meson
>  F: meson_options.txt
>  F: config/rte_config.h
>  F: buildtools/gen-pmdinfo-cfile.sh
> +F: buildtools/map_to_def.py
>  F: buildtools/symlink-drivers-solibs.sh

Re: [dpdk-dev] [PATCH] maintainers: add Windows exports script

[Bruce Richardson]

On Mon, Jun 17, 2019 at 12:33:58PM +0300, Thomas Monjalon wrote:
> 13/06/2019 17:11, Thomas Monjalon:
> > A script used with meson was missing in the list of files.
> > 
> > Fixes: 4c773788e05a ("build: generate Windows exports file")
> > Cc: bruce.richardson@intel.com
> > 
> > Signed-off-by: Thomas Monjalon <thomas@monjalon.net>
> 
> 
> Bruce, do you agree with following addition?
> 

No objections. Sorry for not replying sooner.

Acked-by: Bruce Richardson <bruce.richardson@intel.com>

> > --- a/MAINTAINERS
> > +++ b/MAINTAINERS
> > @@ -117,6 +117,7 @@ F: lib/librte_eal/freebsd/BSDmakefile.meson
> >  F: meson_options.txt
> >  F: config/rte_config.h
> >  F: buildtools/gen-pmdinfo-cfile.sh
> > +F: buildtools/map_to_def.py
> >  F: buildtools/symlink-drivers-solibs.sh
> 
> 
> 
> 

Re: [dpdk-dev] [PATCH] maintainers: add Windows exports script

[Thomas Monjalon]

17/06/2019 13:02, Bruce Richardson:
> On Mon, Jun 17, 2019 at 12:33:58PM +0300, Thomas Monjalon wrote:
> > 13/06/2019 17:11, Thomas Monjalon:
> > > A script used with meson was missing in the list of files.
> > > 
> > > Fixes: 4c773788e05a ("build: generate Windows exports file")
> > > Cc: bruce.richardson@intel.com
> > > 
> > > Signed-off-by: Thomas Monjalon <thomas@monjalon.net>
> > 
> > 
> > Bruce, do you agree with following addition?
> > 
> 
> No objections. Sorry for not replying sooner.
> 
> Acked-by: Bruce Richardson <bruce.richardson@intel.com>

Applied, thanks