dev.dpdk.org archive mirror
 help / color / mirror / Atom feed
From: "Laatz, Kevin" <kevin.laatz@intel.com>
To: "Yigit, Ferruh" <ferruh.yigit@intel.com>,
	"Pattan, Reshma" <reshma.pattan@intel.com>,
	"dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH v2] lib/telemetry: add support to fetch global metrics
Date: Thu, 20 Jun 2019 08:59:06 +0000	[thread overview]
Message-ID: <17B8B96B619B7A459C5ACA628B2749520D2C9CA6@IRSMSX103.ger.corp.intel.com> (raw)
In-Reply-To: <c48e5221-f46b-937c-650c-22f354637e32@intel.com>



> Hi Reshma, Kevin,
> 
> Not related to this patch, but when telemetry library enabled, it is causing
> some warnings [1] with gcc9
> 
> The [-Waddress-of-packed-member] warnings already disable for gcc, but
> you need following update to "lib/librte_telemetry/Makefile":
>  -CFLAGS += -I$(SRCDIR)
>  +CFLAGS += $(WERROR_FLAGS) -I$(SRCDIR)
> 
> Can you please take care of this?
> 

Sure, I'll look into it. Thanks.

> 
> 
> [1]
> In file included from .../dpdk/x86_64-native-linuxapp-
> gcc/include/rte_ethdev.h:160,
>                  from .../dpdk/lib/librte_telemetry/rte_telemetry_parser.c:13:
> .../dpdk/x86_64-native-linuxapp-gcc/include/rte_ether.h: In function
> ‘rte_is_broadcast_ether_addr’:
> .../dpdk/x86_64-native-linuxapp-gcc/include/rte_ether.h:152:2: warning:
> converting a packed ‘const struct rte_ether_addr’ pointer (alignment 1) to a
> ‘unaligned_uint16_t’ {aka ‘const short unsigned int’} pointer (alignment 2)
> may result in an unaligned pointer value [-Waddress-of-packed-member]
>   152 |  const unaligned_uint16_t *ea_words = (const unaligned_uint16_t
> *)ea;
>       |  ^~~~~

  reply	other threads:[~2019-06-20  8:59 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-05-17 16:07 [dpdk-dev] [PATCH] lib/telemetry: add support to fetch global metrics Reshma Pattan
2019-05-31 12:41 ` Laatz, Kevin
2019-06-18  9:44 ` Thomas Monjalon
2019-06-18 11:46   ` Pattan, Reshma
2019-06-18 15:55   ` Pattan, Reshma
2019-06-18 20:07     ` Thomas Monjalon
2019-06-18 13:49 ` [dpdk-dev] [PATCH v2] " Reshma Pattan
2019-06-19 16:02   ` Ferruh Yigit
2019-06-20  8:59     ` Laatz, Kevin [this message]
2019-06-24 14:54   ` Thomas Monjalon
2019-06-24 17:36     ` Chautru, Nicolas
2019-06-25  8:39       ` Pattan, Reshma
2019-06-25 11:28       ` Pattan, Reshma

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=17B8B96B619B7A459C5ACA628B2749520D2C9CA6@IRSMSX103.ger.corp.intel.com \
    --to=kevin.laatz@intel.com \
    --cc=dev@dpdk.org \
    --cc=ferruh.yigit@intel.com \
    --cc=reshma.pattan@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).