DPDK-dev Archive on lore.kernel.org
 help / color / Atom feed
From: Ferruh Yigit <ferruh.yigit@intel.com>
To: Kalesh A P <kalesh-anakkur.purayil@broadcom.com>,
	wenzhuo.lu@intel.com, jingjing.wu@intel.com,
	bernard.iremonger@intel.com
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH] app/testpmd: show mac addresses added to a port
Date: Tue, 3 Dec 2019 11:59:32 +0000
Message-ID: <184c56e7-67c6-64a2-f242-c3f02dffd19b@intel.com> (raw)
In-Reply-To: <20191125082750.10641-1-kalesh-anakkur.purayil@broadcom.com>

On 11/25/2019 8:27 AM, Kalesh A P wrote:
> From: Kalesh AP <kalesh-anakkur.purayil@broadcom.com>
> 
> Patch adds a runtime function to display the unicast and
> multicast MAC addresses added to a port.
> 
> Syntax:
> 	show port (port_id) macs|mcast_macs
> 
> Usage:
> testpmd> show port 0 macs
> Number of MAC address added: 1
>   B0:26:28:7F:F5:C1
> testpmd>
> testpmd> show port 0 mcast_macs
> Number of Multicast MAC address added: 0
> testpmd>
> testpmd> mac_addr add 0 B0:26:28:7F:22:33
> testpmd> mac_addr add 0 B0:26:28:7F:22:34
> testpmd> show port 0 macs
> Number of MAC address added: 3
>   B0:26:28:7F:F5:C1
>   B0:26:28:7F:22:33
>   B0:26:28:7F:22:34
> testpmd>
> testpmd> mac_addr remove 0 B0:26:28:7F:22:33
> testpmd> show port 0 macs
> Number of MAC address added: 2
>   B0:26:28:7F:F5:C1
>   B0:26:28:7F:22:34
> 
> Signed-off-by: Kalesh AP <kalesh-anakkur.purayil@broadcom.com>
> Reviewed-by: Ajit Khaparde <ajit.khaparde@broadcom.com>

Reviewed-by: Ferruh Yigit <ferruh.yigit@intel.com>

> @@ -487,6 +487,21 @@ set packet types classification for a specific port::
>  
>     testpmd> set port (port_id) ptypes_mask (mask)
>  
> +show port mac addresses info
> +~~~~~~~~~~~~~~~~~~~~~~~~~~

Causing warning [1], will fix while merging.

[1]
WARNING: Title underline too short.

> +
> +Show mac addresses added for a specific port::
> +
> +   testpmd> show port (port_id) macs
> +
> +
> +show port mac addresses info
> +~~~~~~~~~~~~~~~~~~~~~~~~~~

's/mac addresses/multicast mac addresses', again I can fix while merging.

> +
> +Show multicast mac addresses added for a specific port::
> +
> +   testpmd> show port (port_id) mcast_macs
> +
>  show device info
>  ~~~~~~~~~~~~~~~~
>  
> 


  reply index

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-11-25  8:27 Kalesh A P
2019-12-03 11:59 ` Ferruh Yigit [this message]
2019-12-03 12:01   ` Ferruh Yigit

Reply instructions:

You may reply publically to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=184c56e7-67c6-64a2-f242-c3f02dffd19b@intel.com \
    --to=ferruh.yigit@intel.com \
    --cc=bernard.iremonger@intel.com \
    --cc=dev@dpdk.org \
    --cc=jingjing.wu@intel.com \
    --cc=kalesh-anakkur.purayil@broadcom.com \
    --cc=wenzhuo.lu@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

DPDK-dev Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/dpdk-dev/0 dpdk-dev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 dpdk-dev dpdk-dev/ https://lore.kernel.org/dpdk-dev \
		dev@dpdk.org
	public-inbox-index dpdk-dev

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.dpdk.dev


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git