From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.9 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8DCEBC7618F for ; Thu, 18 Jul 2019 22:25:36 +0000 (UTC) Received: from dpdk.org (dpdk.org [92.243.14.124]) by mail.kernel.org (Postfix) with ESMTP id 128F421019 for ; Thu, 18 Jul 2019 22:25:35 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=monjalon.net header.i=@monjalon.net header.b="Mt+A7QHg"; dkim=pass (2048-bit key) header.d=messagingengine.com header.i=@messagingengine.com header.b="Kb35qz8x" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 128F421019 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=monjalon.net Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=dev-bounces@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id AA5682BA8; Fri, 19 Jul 2019 00:25:33 +0200 (CEST) Received: from wout2-smtp.messagingengine.com (wout2-smtp.messagingengine.com [64.147.123.25]) by dpdk.org (Postfix) with ESMTP id 9EC0B1DBF; Fri, 19 Jul 2019 00:25:31 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.west.internal (Postfix) with ESMTP id 72FBB3D0; Thu, 18 Jul 2019 18:25:30 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute1.internal (MEProxy); Thu, 18 Jul 2019 18:25:30 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=mesmtp; bh=B0AVpK/5SttsPpe5sEuxeb4vqILvO4fq+lqoystAgvA=; b=Mt+A7QHgFFD3 ZhtFLFLu+jlYTHTaluEQTuZrOioA0hFC+Z/cIMUwKUE9b7UiaNDGdRyGveiJ52ME s7crjj6f9Lo3pybskakgj8wxUvU0Ieemd0BGlVGssqeuyvcBAtYpx+KmeX2/LRAl N6s3ENz7FwKoX6PQeeIpuVcQmeOLic4= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm3; bh=B0AVpK/5SttsPpe5sEuxeb4vqILvO4fq+lqoystAg vA=; b=Kb35qz8xvOFFQPfBfzzsaYpiZ0LIiG78+pOPlGmc/vBWUqqz82gd8SZ1U RYHCv5Q+xU0vn4fO6cjHtkc72clIwEsMptEMrdqpeW5HQTxtLIT8bsBFKjB6Bshk PkEiJbE4EkMr1xf6sKmFFDL7Hkfe5WW2es3y7RJVN9nhLC6KdQ2gtdfnAMj2pyGf wYAQ8t5a0Pob8W9sRzgzo/Wj9R228d/ImOTZKdMUvyyL0h1BLE05ffBkEz7lfRuY n9EJ3OQUnL7utIsqgI1ErJV65tKcMGMpOIDd7Cg4iqY8VSZH+I19Q7aDe3uRiOm8 NQWvDm5+aAbzdP4kDYdjyqBvODVcQ== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduvddrieeigddutdcutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefhvffufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhmrghs ucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenucfkph epjeejrddufeegrddvtdefrddukeegnecurfgrrhgrmhepmhgrihhlfhhrohhmpehthhho mhgrshesmhhonhhjrghlohhnrdhnvghtnecuvehluhhsthgvrhfuihiivgeptd X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 135B9380075; Thu, 18 Jul 2019 18:25:28 -0400 (EDT) From: Thomas Monjalon To: Herakliusz Lipiec Cc: dev@dpdk.org, stable@dpdk.org, bruce.richardson@intel.com Date: Fri, 19 Jul 2019 00:25:28 +0200 Message-ID: <1901807.fy38742gHy@xps> In-Reply-To: <20190718140330.43109-1-herakliusz.lipiec@intel.com> References: <20190718132912.28250-1-herakliusz.lipiec@intel.com> <20190718140330.43109-1-herakliusz.lipiec@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH] mk: fix output directory name when compiling with custom kernel header dir X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 18/07/2019 16:03, Herakliusz Lipiec: > When building dpdk with differnt kernel headers by specifying > RTE_KERNELDIR igb_uio is compiled to directory with a name of the > version of kernel thats running on the system instead of the one that > dpdk is actually compiled against. Fixed by replacing hardcoded value > with value from RTE_KERNELDIR. missing original commit reference: Fixes: 3967af352aeb ("mk: install kernel modules") > Cc: stable@dpdk.org > Cc: bruce.richardson@intel.com > Signed-off-by: Herakliusz Lipiec > > --- > resending v1 with corrected cc address for stable and corrected > alignment. It should be marked v2, and the alignment is still not correct. > -kerneldir ?= /lib/modules/$(shell uname -r)/extra/dpdk > +kerneldir ?= $(subst /build,/extra/dpdk,$(RTE_KERNELDIR)) I would suggest another syntax, easier to read: kerneldir ?= $(RTE_KERNELDIR:/build=/extra/dpdk)