DPDK-dev Archive on lore.kernel.org
 help / color / Atom feed
From: Ferruh Yigit <ferruh.yigit@intel.com>
To: Viacheslav Ovsiienko <viacheslavo@mellanox.com>, dev@dpdk.org
Cc: bernard.iremonger@intel.com, stable@dpdk.org
Subject: Re: [dpdk-dev] [dpdk-stable] [PATCH] app/testpmd: fix display capabilities routine
Date: Wed, 17 Jul 2019 15:56:06 +0100
Message-ID: <19034fb3-38b1-01d0-f6c9-498982e7e43a@intel.com> (raw)
In-Reply-To: <1563277177-6089-1-git-send-email-viacheslavo@mellanox.com>

On 7/16/2019 12:39 PM, Viacheslav Ovsiienko wrote:
> The DEV_TX_OFFLOAD_MATCH_METADATA was introduced by [1], but
> it is not displayed by "show port [id] tx_offloads capabilities"
> command in testpmd.
> 
> [1] http://patches.dpdk.org/patch/47265/
> 
> Fixes: 839b20be0e9b ("ethdev: support metadata as flow rule criteria")
> Cc: stable@dpdk.org
> 
> Signed-off-by: Viacheslav Ovsiienko <viacheslavo@mellanox.com>
> ---
>  app/test-pmd/config.c | 8 ++++++++
>  1 file changed, 8 insertions(+)
> 
> diff --git a/app/test-pmd/config.c b/app/test-pmd/config.c
> index ba43be5..8fb18be 100644
> --- a/app/test-pmd/config.c
> +++ b/app/test-pmd/config.c
> @@ -830,6 +830,14 @@
>  			printf("off\n");
>  	}
>  
> +	if (dev_info.tx_offload_capa & DEV_TX_OFFLOAD_MATCH_METADATA) {
> +		printf("TX match Flow metafata:        ");
> +		if (ports[port_id].dev_conf.txmode.offloads &
> +		    DEV_TX_OFFLOAD_MATCH_METADATA)
> +			printf("on\n");
> +		else
> +			printf("off\n");
> +	}
>  }
>  
>  int
> 

Hi Viacheslav,

There is already another testpmd command that displays offloads, which is more
dynamic and I think better solution:
"show port <port_id> tx_offload capabilities"
"show port <port_id> tx_offload configuration"
"show port <port_id> rx_offload capabilities"
"show port <port_id> rx_offload configuration"

As far as I can see 'metadata' already supported by these commands, can you
please confirm?

And instead of improving it, what do you think dropping the duplicated command
"show port cap <port_id>|all" ?

  parent reply index

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-07-16 11:39 [dpdk-dev] " Viacheslav Ovsiienko
2019-07-16 13:06 ` Iremonger, Bernard
2019-07-17 14:56 ` Ferruh Yigit [this message]
2019-07-19  5:07   ` [dpdk-dev] [dpdk-stable] " Slava Ovsiienko
2019-07-19 12:46     ` Ferruh Yigit
2019-07-19 18:32       ` Slava Ovsiienko

Reply instructions:

You may reply publically to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=19034fb3-38b1-01d0-f6c9-498982e7e43a@intel.com \
    --to=ferruh.yigit@intel.com \
    --cc=bernard.iremonger@intel.com \
    --cc=dev@dpdk.org \
    --cc=stable@dpdk.org \
    --cc=viacheslavo@mellanox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

DPDK-dev Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/dpdk-dev/0 dpdk-dev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 dpdk-dev dpdk-dev/ https://lore.kernel.org/dpdk-dev \
		dev@dpdk.org dpdk-dev@archiver.kernel.org
	public-inbox-index dpdk-dev


Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.dpdk.dev


AGPL code for this site: git clone https://public-inbox.org/ public-inbox