DPDK-dev Archive on lore.kernel.org
 help / color / Atom feed
* [dpdk-dev] [PATCH] app/testpmd: fix display capabilities routine
@ 2019-07-16 11:39 Viacheslav Ovsiienko
  2019-07-16 13:06 ` Iremonger, Bernard
  2019-07-17 14:56 ` [dpdk-dev] [dpdk-stable] " Ferruh Yigit
  0 siblings, 2 replies; 6+ messages in thread
From: Viacheslav Ovsiienko @ 2019-07-16 11:39 UTC (permalink / raw)
  To: dev; +Cc: bernard.iremonger, stable

The DEV_TX_OFFLOAD_MATCH_METADATA was introduced by [1], but
it is not displayed by "show port [id] tx_offloads capabilities"
command in testpmd.

[1] http://patches.dpdk.org/patch/47265/

Fixes: 839b20be0e9b ("ethdev: support metadata as flow rule criteria")
Cc: stable@dpdk.org

Signed-off-by: Viacheslav Ovsiienko <viacheslavo@mellanox.com>
---
 app/test-pmd/config.c | 8 ++++++++
 1 file changed, 8 insertions(+)

diff --git a/app/test-pmd/config.c b/app/test-pmd/config.c
index ba43be5..8fb18be 100644
--- a/app/test-pmd/config.c
+++ b/app/test-pmd/config.c
@@ -830,6 +830,14 @@
 			printf("off\n");
 	}
 
+	if (dev_info.tx_offload_capa & DEV_TX_OFFLOAD_MATCH_METADATA) {
+		printf("TX match Flow metafata:        ");
+		if (ports[port_id].dev_conf.txmode.offloads &
+		    DEV_TX_OFFLOAD_MATCH_METADATA)
+			printf("on\n");
+		else
+			printf("off\n");
+	}
 }
 
 int
-- 
1.8.3.1


^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [dpdk-dev] [PATCH] app/testpmd: fix display capabilities routine
  2019-07-16 11:39 [dpdk-dev] [PATCH] app/testpmd: fix display capabilities routine Viacheslav Ovsiienko
@ 2019-07-16 13:06 ` Iremonger, Bernard
  2019-07-17 14:56 ` [dpdk-dev] [dpdk-stable] " Ferruh Yigit
  1 sibling, 0 replies; 6+ messages in thread
From: Iremonger, Bernard @ 2019-07-16 13:06 UTC (permalink / raw)
  To: Viacheslav Ovsiienko, dev; +Cc: stable

> -----Original Message-----
> From: Viacheslav Ovsiienko [mailto:viacheslavo@mellanox.com]
> Sent: Tuesday, July 16, 2019 12:40 PM
> To: dev@dpdk.org
> Cc: Iremonger, Bernard <bernard.iremonger@intel.com>; stable@dpdk.org
> Subject: [PATCH] app/testpmd: fix display capabilities routine
> 
> The DEV_TX_OFFLOAD_MATCH_METADATA was introduced by [1], but it is
> not displayed by "show port [id] tx_offloads capabilities"
> command in testpmd.
> 
> [1] http://patches.dpdk.org/patch/47265/
> 
> Fixes: 839b20be0e9b ("ethdev: support metadata as flow rule criteria")
> Cc: stable@dpdk.org
> 
> Signed-off-by: Viacheslav Ovsiienko <viacheslavo@mellanox.com>

Acked-by: Bernard Iremonger <bernard.iremonger@intel.com>


^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [dpdk-dev] [dpdk-stable] [PATCH] app/testpmd: fix display capabilities routine
  2019-07-16 11:39 [dpdk-dev] [PATCH] app/testpmd: fix display capabilities routine Viacheslav Ovsiienko
  2019-07-16 13:06 ` Iremonger, Bernard
@ 2019-07-17 14:56 ` " Ferruh Yigit
  2019-07-19  5:07   ` Slava Ovsiienko
  1 sibling, 1 reply; 6+ messages in thread
From: Ferruh Yigit @ 2019-07-17 14:56 UTC (permalink / raw)
  To: Viacheslav Ovsiienko, dev; +Cc: bernard.iremonger, stable

On 7/16/2019 12:39 PM, Viacheslav Ovsiienko wrote:
> The DEV_TX_OFFLOAD_MATCH_METADATA was introduced by [1], but
> it is not displayed by "show port [id] tx_offloads capabilities"
> command in testpmd.
> 
> [1] http://patches.dpdk.org/patch/47265/
> 
> Fixes: 839b20be0e9b ("ethdev: support metadata as flow rule criteria")
> Cc: stable@dpdk.org
> 
> Signed-off-by: Viacheslav Ovsiienko <viacheslavo@mellanox.com>
> ---
>  app/test-pmd/config.c | 8 ++++++++
>  1 file changed, 8 insertions(+)
> 
> diff --git a/app/test-pmd/config.c b/app/test-pmd/config.c
> index ba43be5..8fb18be 100644
> --- a/app/test-pmd/config.c
> +++ b/app/test-pmd/config.c
> @@ -830,6 +830,14 @@
>  			printf("off\n");
>  	}
>  
> +	if (dev_info.tx_offload_capa & DEV_TX_OFFLOAD_MATCH_METADATA) {
> +		printf("TX match Flow metafata:        ");
> +		if (ports[port_id].dev_conf.txmode.offloads &
> +		    DEV_TX_OFFLOAD_MATCH_METADATA)
> +			printf("on\n");
> +		else
> +			printf("off\n");
> +	}
>  }
>  
>  int
> 

Hi Viacheslav,

There is already another testpmd command that displays offloads, which is more
dynamic and I think better solution:
"show port <port_id> tx_offload capabilities"
"show port <port_id> tx_offload configuration"
"show port <port_id> rx_offload capabilities"
"show port <port_id> rx_offload configuration"

As far as I can see 'metadata' already supported by these commands, can you
please confirm?

And instead of improving it, what do you think dropping the duplicated command
"show port cap <port_id>|all" ?

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [dpdk-dev] [dpdk-stable] [PATCH] app/testpmd: fix display capabilities routine
  2019-07-17 14:56 ` [dpdk-dev] [dpdk-stable] " Ferruh Yigit
@ 2019-07-19  5:07   ` Slava Ovsiienko
  2019-07-19 12:46     ` Ferruh Yigit
  0 siblings, 1 reply; 6+ messages in thread
From: Slava Ovsiienko @ 2019-07-19  5:07 UTC (permalink / raw)
  To: Ferruh Yigit, dev; +Cc: bernard.iremonger, stable

Hi, Ferruh

Please, see below

> -----Original Message-----
> From: Ferruh Yigit <ferruh.yigit@intel.com>
> Sent: Wednesday, July 17, 2019 17:56
> To: Slava Ovsiienko <viacheslavo@mellanox.com>; dev@dpdk.org
> Cc: bernard.iremonger@intel.com; stable@dpdk.org
> Subject: Re: [dpdk-stable] [PATCH] app/testpmd: fix display capabilities
> routine
> 
> On 7/16/2019 12:39 PM, Viacheslav Ovsiienko wrote:
> > The DEV_TX_OFFLOAD_MATCH_METADATA was introduced by [1], but it is
> not
> > displayed by "show port [id] tx_offloads capabilities"
> > command in testpmd.
> >
> > [1]
> >
> https://eur03.safelinks.protection.outlook.com/?url=http%3A%2F%2Fpatch
> >
> es.dpdk.org%2Fpatch%2F47265%2F&amp;data=02%7C01%7Cviacheslavo%4
> 0mellan
> >
> ox.com%7C3fea893cbf43414d6f9a08d70ac6e78f%7Ca652971c7d2e4d9ba6a
> 4d14925
> >
> 6f461b%7C0%7C0%7C636989721710321485&amp;sdata=bnKjCSFr%2FVX9k
> Ds1TwijB0
> > %2Bpe0xM4j2J9cZg872hBYA%3D&amp;reserved=0
> >
> > Fixes: 839b20be0e9b ("ethdev: support metadata as flow rule criteria")
> > Cc: stable@dpdk.org
> >
> > Signed-off-by: Viacheslav Ovsiienko <viacheslavo@mellanox.com>
> > ---
> >  app/test-pmd/config.c | 8 ++++++++
> >  1 file changed, 8 insertions(+)
> >
> > diff --git a/app/test-pmd/config.c b/app/test-pmd/config.c index
> > ba43be5..8fb18be 100644
> > --- a/app/test-pmd/config.c
> > +++ b/app/test-pmd/config.c
> > @@ -830,6 +830,14 @@
> >  			printf("off\n");
> >  	}
> >
> > +	if (dev_info.tx_offload_capa &
> DEV_TX_OFFLOAD_MATCH_METADATA) {
> > +		printf("TX match Flow metafata:        ");
> > +		if (ports[port_id].dev_conf.txmode.offloads &
> > +		    DEV_TX_OFFLOAD_MATCH_METADATA)
> > +			printf("on\n");
> > +		else
> > +			printf("off\n");
> > +	}
> >  }
> >
> >  int
> >
> 
> Hi Viacheslav,
> 
> There is already another testpmd command that displays offloads, which is
> more dynamic and I think better solution:
> "show port <port_id> tx_offload capabilities"
> "show port <port_id> tx_offload configuration"

Yes, it's implemented in dynamic approach and shows tx metadata offload cap/con correctly.
It is OK, no need to update this one.

> "show port <port_id> rx_offload capabilities"
> "show port <port_id> rx_offload configuration"
> 
> As far as I can see 'metadata' already supported by these commands, can
> you please confirm?

These commands are RX related, there is no any metadata offloads for RX.

> 
> And instead of improving it, what do you think dropping the duplicated
> command "show port cap <port_id>|all" ?

I use this command, it is shorter than the "show port 0 tx_offload capabilities", even with autocompletion.
Despite this, personally me is OK with drop. But someone else may use these commands also.

With best regards, Slava


^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [dpdk-dev] [dpdk-stable] [PATCH] app/testpmd: fix display capabilities routine
  2019-07-19  5:07   ` Slava Ovsiienko
@ 2019-07-19 12:46     ` Ferruh Yigit
  2019-07-19 18:32       ` Slava Ovsiienko
  0 siblings, 1 reply; 6+ messages in thread
From: Ferruh Yigit @ 2019-07-19 12:46 UTC (permalink / raw)
  To: Slava Ovsiienko, dev; +Cc: bernard.iremonger, stable

On 7/19/2019 6:07 AM, Slava Ovsiienko wrote:
> Hi, Ferruh
> 
> Please, see below
> 
>> -----Original Message-----
>> From: Ferruh Yigit <ferruh.yigit@intel.com>
>> Sent: Wednesday, July 17, 2019 17:56
>> To: Slava Ovsiienko <viacheslavo@mellanox.com>; dev@dpdk.org
>> Cc: bernard.iremonger@intel.com; stable@dpdk.org
>> Subject: Re: [dpdk-stable] [PATCH] app/testpmd: fix display capabilities
>> routine
>>
>> On 7/16/2019 12:39 PM, Viacheslav Ovsiienko wrote:
>>> The DEV_TX_OFFLOAD_MATCH_METADATA was introduced by [1], but it is
>> not
>>> displayed by "show port [id] tx_offloads capabilities"
>>> command in testpmd.
>>>
>>> [1]
>>>
>> https://eur03.safelinks.protection.outlook.com/?url=http%3A%2F%2Fpatch
>>>
>> es.dpdk.org%2Fpatch%2F47265%2F&amp;data=02%7C01%7Cviacheslavo%4
>> 0mellan
>>>
>> ox.com%7C3fea893cbf43414d6f9a08d70ac6e78f%7Ca652971c7d2e4d9ba6a
>> 4d14925
>>>
>> 6f461b%7C0%7C0%7C636989721710321485&amp;sdata=bnKjCSFr%2FVX9k
>> Ds1TwijB0
>>> %2Bpe0xM4j2J9cZg872hBYA%3D&amp;reserved=0
>>>
>>> Fixes: 839b20be0e9b ("ethdev: support metadata as flow rule criteria")
>>> Cc: stable@dpdk.org
>>>
>>> Signed-off-by: Viacheslav Ovsiienko <viacheslavo@mellanox.com>
>>> ---
>>>  app/test-pmd/config.c | 8 ++++++++
>>>  1 file changed, 8 insertions(+)
>>>
>>> diff --git a/app/test-pmd/config.c b/app/test-pmd/config.c index
>>> ba43be5..8fb18be 100644
>>> --- a/app/test-pmd/config.c
>>> +++ b/app/test-pmd/config.c
>>> @@ -830,6 +830,14 @@
>>>  			printf("off\n");
>>>  	}
>>>
>>> +	if (dev_info.tx_offload_capa &
>> DEV_TX_OFFLOAD_MATCH_METADATA) {
>>> +		printf("TX match Flow metafata:        ");
>>> +		if (ports[port_id].dev_conf.txmode.offloads &
>>> +		    DEV_TX_OFFLOAD_MATCH_METADATA)
>>> +			printf("on\n");
>>> +		else
>>> +			printf("off\n");
>>> +	}
>>>  }
>>>
>>>  int
>>>
>>
>> Hi Viacheslav,
>>
>> There is already another testpmd command that displays offloads, which is
>> more dynamic and I think better solution:
>> "show port <port_id> tx_offload capabilities"
>> "show port <port_id> tx_offload configuration"
> 
> Yes, it's implemented in dynamic approach and shows tx metadata offload cap/con correctly.
> It is OK, no need to update this one.
> 
>> "show port <port_id> rx_offload capabilities"
>> "show port <port_id> rx_offload configuration"
>>
>> As far as I can see 'metadata' already supported by these commands, can
>> you please confirm?
> 
> These commands are RX related, there is no any metadata offloads for RX.
> 
>>
>> And instead of improving it, what do you think dropping the duplicated
>> command "show port cap <port_id>|all" ?
> 
> I use this command, it is shorter than the "show port 0 tx_offload capabilities", even with autocompletion.
> Despite this, personally me is OK with drop. But someone else may use these commands also.

As long as we have another command that has this support it is not an issue I
think. And duplication is bad :)

Would you mind helping on this, and prepare a patch to remove this?

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [dpdk-dev] [dpdk-stable] [PATCH] app/testpmd: fix display capabilities routine
  2019-07-19 12:46     ` Ferruh Yigit
@ 2019-07-19 18:32       ` Slava Ovsiienko
  0 siblings, 0 replies; 6+ messages in thread
From: Slava Ovsiienko @ 2019-07-19 18:32 UTC (permalink / raw)
  To: Ferruh Yigit, dev; +Cc: bernard.iremonger, stable



> -----Original Message-----
> From: Ferruh Yigit <ferruh.yigit@intel.com>
> Sent: Friday, July 19, 2019 15:47
> To: Slava Ovsiienko <viacheslavo@mellanox.com>; dev@dpdk.org
> Cc: bernard.iremonger@intel.com; stable@dpdk.org
> Subject: Re: [dpdk-dev] [dpdk-stable] [PATCH] app/testpmd: fix display
> capabilities routine
> 
> On 7/19/2019 6:07 AM, Slava Ovsiienko wrote:
> > Hi, Ferruh
> >
> > Please, see below
> >
> >> -----Original Message-----
> >> From: Ferruh Yigit <ferruh.yigit@intel.com>
> >> Sent: Wednesday, July 17, 2019 17:56
> >> To: Slava Ovsiienko <viacheslavo@mellanox.com>; dev@dpdk.org
> >> Cc: bernard.iremonger@intel.com; stable@dpdk.org
> >> Subject: Re: [dpdk-stable] [PATCH] app/testpmd: fix display
> >> capabilities routine
> >>
> >> On 7/16/2019 12:39 PM, Viacheslav Ovsiienko wrote:
> >>> The DEV_TX_OFFLOAD_MATCH_METADATA was introduced by [1], but it
> is
> >> not
> >>> displayed by "show port [id] tx_offloads capabilities"
> >>> command in testpmd.
> >>>
> >>> [1]
> >>>
> >> http://patch
> >>>
> >>
> es.dpdk.org%2Fpatch%2F47265%2F&amp;data=02%7C01%7Cviacheslavo%4
> >> 0mellan
> >>>
> >>
> ox.com%7C3fea893cbf43414d6f9a08d70ac6e78f%7Ca652971c7d2e4d9ba6a
> >> 4d14925
> >>>
> >>
> 6f461b%7C0%7C0%7C636989721710321485&amp;sdata=bnKjCSFr%2FVX9k
> >> Ds1TwijB0
> >>> %2Bpe0xM4j2J9cZg872hBYA%3D&amp;reserved=0
> >>>
> >>> Fixes: 839b20be0e9b ("ethdev: support metadata as flow rule
> >>> criteria")
> >>> Cc: stable@dpdk.org
> >>>
> >>> Signed-off-by: Viacheslav Ovsiienko <viacheslavo@mellanox.com>
> >>> ---
> >>>  app/test-pmd/config.c | 8 ++++++++
> >>>  1 file changed, 8 insertions(+)
> >>>
> >>> diff --git a/app/test-pmd/config.c b/app/test-pmd/config.c index
> >>> ba43be5..8fb18be 100644
> >>> --- a/app/test-pmd/config.c
> >>> +++ b/app/test-pmd/config.c
> >>> @@ -830,6 +830,14 @@
> >>>  			printf("off\n");
> >>>  	}
> >>>
> >>> +	if (dev_info.tx_offload_capa &
> >> DEV_TX_OFFLOAD_MATCH_METADATA) {
> >>> +		printf("TX match Flow metafata:        ");
> >>> +		if (ports[port_id].dev_conf.txmode.offloads &
> >>> +		    DEV_TX_OFFLOAD_MATCH_METADATA)
> >>> +			printf("on\n");
> >>> +		else
> >>> +			printf("off\n");
> >>> +	}
> >>>  }
> >>>
> >>>  int
> >>>
> >>
> >> Hi Viacheslav,
> >>
> >> There is already another testpmd command that displays offloads,
> >> which is more dynamic and I think better solution:
> >> "show port <port_id> tx_offload capabilities"
> >> "show port <port_id> tx_offload configuration"
> >
> > Yes, it's implemented in dynamic approach and shows tx metadata offload
> cap/con correctly.
> > It is OK, no need to update this one.
> >
> >> "show port <port_id> rx_offload capabilities"
> >> "show port <port_id> rx_offload configuration"
> >>
> >> As far as I can see 'metadata' already supported by these commands,
> >> can you please confirm?
> >
> > These commands are RX related, there is no any metadata offloads for RX.
> >
> >>
> >> And instead of improving it, what do you think dropping the
> >> duplicated command "show port cap <port_id>|all" ?
> >
> > I use this command, it is shorter than the "show port 0 tx_offload
> capabilities", even with autocompletion.
> > Despite this, personally me is OK with drop. But someone else may use
> these commands also.
> 
> As long as we have another command that has this support it is not an issue I
> think. And duplication is bad :)
> 
> Would you mind helping on this, and prepare a patch to remove this?
Sure, I would, with pleasure.

With best regards, Slava

^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, back to index

Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-07-16 11:39 [dpdk-dev] [PATCH] app/testpmd: fix display capabilities routine Viacheslav Ovsiienko
2019-07-16 13:06 ` Iremonger, Bernard
2019-07-17 14:56 ` [dpdk-dev] [dpdk-stable] " Ferruh Yigit
2019-07-19  5:07   ` Slava Ovsiienko
2019-07-19 12:46     ` Ferruh Yigit
2019-07-19 18:32       ` Slava Ovsiienko

DPDK-dev Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/dpdk-dev/0 dpdk-dev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 dpdk-dev dpdk-dev/ https://lore.kernel.org/dpdk-dev \
		dev@dpdk.org dpdk-dev@archiver.kernel.org
	public-inbox-index dpdk-dev


Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.dpdk.dev


AGPL code for this site: git clone https://public-inbox.org/ public-inbox