dev.dpdk.org archive mirror
 help / color / mirror / Atom feed
From: "Rao, Nikhil" <nikhil.rao@intel.com>
To: "jerinj@marvell.com" <jerinj@marvell.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>,
	"Mattias Rönnblom" <mattias.ronnblom@ericsson.com>
Subject: Re: [dpdk-dev] [PATCH] eventdev: remove event copy in Rx adapter
Date: Thu, 13 Jun 2019 13:02:55 +0000	[thread overview]
Message-ID: <1F668163772FA946975B9466A9DFF729EDE51851@ORSMSX122.amr.corp.intel.com> (raw)
In-Reply-To: <94f5667e-6539-a91c-36d3-8d890cab4e51@ericsson.com>

Hi Jerin,

> -----Original Message-----
> From: Mattias Rönnblom [mailto:mattias.ronnblom@ericsson.com]
> Sent: Tuesday, June 11, 2019 4:25 PM
> To: Rao, Nikhil <nikhil.rao@intel.com>; jerinj@marvell.com
> Cc: dev@dpdk.org
> Subject: Re: [dpdk-dev] [PATCH] eventdev: remove event copy in Rx adapter
> 
> On 2019-05-21 23:52, Nikhil Rao wrote:
> > Remove copy from temporary event array on the stack to the enqueue
> > buffer event array entry, instead initialize event in the enqueue
> > buffer event array entry.
> >
> > Suggested-by: Mattias Rönnblom <mattias.ronnblom@ericsson.com>
> > Signed-off-by: Nikhil Rao <nikhil.rao@intel.com>
> > ---
> >
> > Hi Mattias,
> >
> > This patch eliminates the event copy as you previously mentioned
> > (https://patches.dpdk.org/patch/53350/), the enqueue buffer array is
> > still retained in the rx_adapter struct, since the Rx adapter service
> > function can return with events in the enqueue buffer that have not
> > yet been shipped to the event device.
> >
> > Let me know your comments.
> >
> > Thanks,
> > Nikhil
> 
> Looks good to me. Sorry about the late reply.
> 
Would you be able to merge this patch.

The patch below is dependent on it. 
http://patchwork.dpdk.org/patch/53764/

Thanks,
Nikhil

  reply	other threads:[~2019-06-13 13:03 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-05-21 21:52 [dpdk-dev] [PATCH] eventdev: remove event copy in Rx adapter Nikhil Rao
2019-06-11 10:55 ` Mattias Rönnblom
2019-06-13 13:02   ` Rao, Nikhil [this message]
2019-06-13 14:05     ` Jerin Jacob Kollanukkaran
2019-06-13 14:43       ` Jerin Jacob Kollanukkaran
2019-06-10  4:23 Jerin Jacob Kollanukkaran

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1F668163772FA946975B9466A9DFF729EDE51851@ORSMSX122.amr.corp.intel.com \
    --to=nikhil.rao@intel.com \
    --cc=dev@dpdk.org \
    --cc=jerinj@marvell.com \
    --cc=mattias.ronnblom@ericsson.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).