From: "Wei Hu (Xavier)" <xavier.huwei@huawei.com> To: Jerin Jacob Kollanukkaran <jerinj@marvell.com>, "dev@dpdk.org" <dev@dpdk.org> Cc: "xavier_huwei@163.com" <xavier_huwei@163.com>, "linuxarm@huawei.com" <linuxarm@huawei.com>, "forest.zhouchang@huawei.com" <forest.zhouchang@huawei.com> Subject: Re: [dpdk-dev] [PATCH 22/22] net/hns3: add hns3 build files Date: Sat, 31 Aug 2019 10:10:31 +0800 Message-ID: <1faf6ee1-7dbf-4c58-994f-86a5ee09868f@huawei.com> (raw) In-Reply-To: <e5c5824f-5061-353a-0efd-25aff38a3866@huawei.com> On 2019/8/30 11:22, Wei Hu (Xavier) wrote: > Hi, Jerin > > > On 2019/8/23 22:08, Jerin Jacob Kollanukkaran wrote: >>> -----Original Message----- >>> From: dev <dev-bounces@dpdk.org> On Behalf Of Wei Hu (Xavier) >>> Sent: Friday, August 23, 2019 7:17 PM >>> To: dev@dpdk.org >>> Cc: linuxarm@huawei.com; xavier_huwei@163.com; >>> liudongdong3@huawei.com; forest.zhouchang@huawei.com >>> Subject: [dpdk-dev] [PATCH 22/22] net/hns3: add hns3 build files >>> >>> This patch add build related files for hns3 PMD driver. >>> >>> Signed-off-by: Wei Hu (Xavier) <xavier.huwei@huawei.com> >>> Signed-off-by: Min Hu (Connor) <humin29@huawei.com> >>> Signed-off-by: Chunsong Feng <fengchunsong@huawei.com> >>> Signed-off-by: Hao Chen <chenhao164@huawei.com> >>> Signed-off-by: Huisong Li <lihuisong@huawei.com> >>> --- >>> +# Hisilicon HNS3 PMD driver >>> +# >>> +CONFIG_RTE_LIBRTE_HNS3_PMD=y >> # Please add meson support > This patch already contains meson support, thanks >> # Move build infra to the first patch >> # See git log drivers/net/octeontx2 as example > OK, I will adjust the order of the patches in this series and send V2. >> >>> diff --git a/config/common_base b/config/common_base >>> index 8ef75c2..71a2c33 100644 >>> --- a/config/common_base >>> +++ b/config/common_base >>> @@ -282,6 +282,11 @@ >>> CONFIG_RTE_LIBRTE_E1000_PF_DISABLE_STRIP_CRC=n >>> CONFIG_RTE_LIBRTE_HINIC_PMD=n >>> >>> # >>> +# Compile burst-oriented HNS3 PMD driver >>> +# >>> +CONFIG_RTE_LIBRTE_HNS3_PMD=n >>> + >>> +# >>> # Compile burst-oriented IXGBE PMD driver >>> # >>> CONFIG_RTE_LIBRTE_IXGBE_PMD=y >>> diff --git a/config/defconfig_arm64-armv8a-linuxapp-clang >>> b/config/defconfig_arm64-armv8a-linuxapp-clang >>> index d3b4dad..c73f5fb 100644 >>> --- a/config/defconfig_arm64-armv8a-linuxapp-clang >>> +++ b/config/defconfig_arm64-armv8a-linuxapp-clang >>> @@ -6,3 +6,5 @@ >>> >>> CONFIG_RTE_TOOLCHAIN="clang" >>> CONFIG_RTE_TOOLCHAIN_CLANG=y >>> + >>> +CONFIG_RTE_LIBRTE_HNS3_PMD=n >>> diff --git a/doc/guides/nics/features/hns3.ini >>> b/doc/guides/nics/features/hns3.ini >>> new file mode 100644 >>> index 0000000..d38d35e >>> --- /dev/null >>> +++ b/doc/guides/nics/features/hns3.ini >>> @@ -0,0 +1,38 @@ >>> +; >>> +; Supported features of the 'hns3' network poll mode driver. >> Add doc changes when driver feature gets added. >> # See git log drivers/net/octeontx2 as example > OK, I will modify the patches and send V2. > Thanks >>> +; >>> +; Refer to default.ini for the full list of available PMD features. >>> +; >>> +[Features] >>> +Link status = Y >>> +MTU update = Y >>> +Jumbo frame = Y >>> +Promiscuous mode = Y >>> +Allmulticast mode = Y >>> diff --git a/doc/guides/nics/hns3.rst b/doc/guides/nics/hns3.rst >>> new file mode 100644 >>> index 0000000..c9d0253 >>> --- /dev/null >>> +++ b/doc/guides/nics/hns3.rst >>> @@ -0,0 +1,55 @@ >>> +.. SPDX-License-Identifier: BSD-3-Clause >>> + Copyright(c) 2018-2019 Hisilicon Limited. >>> + >>> +HNS3 Poll Mode Driver >>> +=============================== >>> + >>> +The Hisilicon Network Subsystem is a long term evolution IP which is >>> +supposed to be used in Hisilicon ICT SoCs such as Kunpeng 920. >>> + >>> +The HNS3 PMD (librte_pmd_hns3) provides poll mode driver support >>> +for hns3(Hisilicon Network Subsystem 3) network engine. >>> + >>> +Features >>> +-------- >>> + >>> +Features of the HNS3 PMD are: >>> + >>> +- Arch support: ARMv8. >> Is it an integrated NIC controller? Why it is supported only on ARMv8? >> The reason why I asking because, Enabling CONFIG_RTE_LIBRTE_HNS3_PMD=y >> only on arm64 will create a case where build fails for arm64 and passes for >> x86. I would like to avoid such disparity. If the build is passing on x86 make it >> enable in the common code, not in arm64 config. > Currently this network engine is integrated in the SoCs, the SoCs can be > used > as a PCIe EP integrated NIC controllers or be used as universal cpus on > the device, > such as servers. The network engine is accessed by ARM cores in the SoCs. > We will enabling CONFIG_RTE_LIBRTE_HNS3_PMD=y in common_linux config in V2. > Thanks. Hi, Jerin as a PCIe EP integrated NIC controllers -> as a PCIe EP Intelligent NIC controllers Since it is currently only accessed by ARM cores on SoCs, maybe it is also reasonable to compile only on ARMv8, right? Regards Xaiver >>> +- Multiple queues for TX and RX >>> +- Receive Side Scaling (RSS) >>> +- Packet type information >>> +- Checksum offload >>> +- Promiscuous mode >>> +- Multicast mode >>> +- Port hardware statistics >>> +- Jumbo frames >>> +- Link state information >>> +- VLAN stripping >>> +cflags += '-DALLOW_EXPERIMENTAL_API' >>> diff --git a/drivers/net/hns3/rte_pmd_hns3_version.map >>> b/drivers/net/hns3/rte_pmd_hns3_version.map >>> new file mode 100644 >>> index 0000000..3aef967 >>> --- /dev/null >>> +++ b/drivers/net/hns3/rte_pmd_hns3_version.map >>> @@ -0,0 +1,3 @@ >>> +DPDK_19.08 { >> Change to 19.11 > OK, I will modify the patches and send V2. Thanks. > > Regards > Xavier >> >> > > _______________________________________________ > Linuxarm mailing list > Linuxarm@huawei.com > http://hulk.huawei.com/mailman/listinfo/linuxarm > > . >
next prev parent reply index Thread overview: 77+ messages / expand[flat|nested] mbox.gz Atom feed top 2019-08-23 13:46 [dpdk-dev] [PATCH 00/22] add hns3 ethernet PMD driver Wei Hu (Xavier) 2019-08-23 13:46 ` [dpdk-dev] [PATCH 01/22] net/hns3: add hardware registers definition Wei Hu (Xavier) 2019-08-23 13:46 ` [dpdk-dev] [PATCH 02/22] net/hns3: add some definitions for data structure and macro Wei Hu (Xavier) 2019-08-30 8:25 ` Gavin Hu (Arm Technology China) 2019-09-05 6:01 ` Wei Hu (Xavier) 2019-08-23 13:46 ` [dpdk-dev] [PATCH 03/22] net/hns3: register hns3 PMD driver Wei Hu (Xavier) 2019-08-30 15:01 ` Ferruh Yigit 2019-09-06 6:20 ` Wei Hu (Xavier) 2019-08-23 13:46 ` [dpdk-dev] [PATCH 04/22] net/hns3: add support for cmd of " Wei Hu (Xavier) 2019-08-30 15:02 ` Ferruh Yigit 2019-09-06 6:49 ` Wei Hu (Xavier) 2019-08-23 13:46 ` [dpdk-dev] [PATCH 05/22] net/hns3: add the initialization " Wei Hu (Xavier) 2019-08-23 13:46 ` [dpdk-dev] [PATCH 06/22] net/hns3: add support for MAC address related operations Wei Hu (Xavier) 2019-08-30 15:03 ` Ferruh Yigit 2019-09-05 5:40 ` Wei Hu (Xavier) 2019-08-23 13:46 ` [dpdk-dev] [PATCH 07/22] net/hns3: add support for some misc operations Wei Hu (Xavier) 2019-08-30 15:04 ` Ferruh Yigit 2019-08-23 13:46 ` [dpdk-dev] [PATCH 08/22] net/hns3: add support for link update operation Wei Hu (Xavier) 2019-08-30 15:04 ` Ferruh Yigit 2019-09-06 6:56 ` Wei Hu (Xavier) 2019-08-23 13:46 ` [dpdk-dev] [PATCH 09/22] net/hns3: add support for flow directory of hns3 PMD driver Wei Hu (Xavier) 2019-08-30 15:06 ` Ferruh Yigit 2019-09-06 8:23 ` Wei Hu (Xavier) 2019-09-06 11:08 ` Wei Hu (Xavier) 2019-08-23 13:46 ` [dpdk-dev] [PATCH 10/22] net/hns3: add support for RSS " Wei Hu (Xavier) 2019-08-30 15:07 ` Ferruh Yigit 2019-08-31 9:16 ` Wei Hu (Xavier) 2019-08-23 13:47 ` [dpdk-dev] [PATCH 11/22] net/hns3: add support for flow control " Wei Hu (Xavier) 2019-08-30 15:07 ` Ferruh Yigit 2019-08-31 8:04 ` Wei Hu (Xavier) 2019-08-23 13:47 ` [dpdk-dev] [PATCH 12/22] net/hns3: add support for VLAN " Wei Hu (Xavier) 2019-08-30 15:08 ` Ferruh Yigit 2019-08-31 9:04 ` Wei Hu (Xavier) 2019-08-23 13:47 ` [dpdk-dev] [PATCH 13/22] net/hns3: add support for mailbox " Wei Hu (Xavier) 2019-08-30 15:08 ` Ferruh Yigit 2019-09-06 11:25 ` Wei Hu (Xavier) 2019-08-23 13:47 ` [dpdk-dev] [PATCH 14/22] net/hns3: add support for hns3 VF " Wei Hu (Xavier) 2019-08-30 15:11 ` Ferruh Yigit 2019-08-31 9:03 ` Wei Hu (Xavier) 2019-09-06 11:27 ` Wei Hu (Xavier) 2019-08-23 13:47 ` [dpdk-dev] [PATCH 15/22] net/hns3: add package and queue related operation Wei Hu (Xavier) 2019-08-23 15:42 ` Aaron Conole 2019-08-30 15:13 ` Ferruh Yigit 2019-09-11 11:40 ` Wei Hu (Xavier) 2019-08-23 13:47 ` [dpdk-dev] [PATCH 16/22] net/hns3: add start stop configure promiscuous ops Wei Hu (Xavier) 2019-08-30 15:14 ` Ferruh Yigit 2019-09-06 11:51 ` Wei Hu (Xavier) 2019-08-23 13:47 ` [dpdk-dev] [PATCH 17/22] net/hns3: add dump register ops for hns3 PMD driver Wei Hu (Xavier) 2019-08-23 13:47 ` [dpdk-dev] [PATCH 18/22] net/hns3: add abnormal interrupt process " Wei Hu (Xavier) 2019-08-23 13:47 ` [dpdk-dev] [PATCH 19/22] net/hns3: add stats related ops " Wei Hu (Xavier) 2019-08-30 15:20 ` Ferruh Yigit 2019-08-31 8:49 ` Wei Hu (Xavier) 2019-08-23 13:47 ` [dpdk-dev] [PATCH 20/22] net/hns3: add reset related process " Wei Hu (Xavier) 2019-08-23 13:47 ` [dpdk-dev] [PATCH 21/22] net/hns3: add multiple process support " Wei Hu (Xavier) 2019-08-30 15:14 ` Ferruh Yigit 2019-09-02 13:41 ` Wei Hu (Xavier) 2019-08-23 13:47 ` [dpdk-dev] [PATCH 22/22] net/hns3: add hns3 build files Wei Hu (Xavier) 2019-08-23 14:08 ` Jerin Jacob Kollanukkaran 2019-08-30 3:22 ` Wei Hu (Xavier) 2019-08-31 2:10 ` Wei Hu (Xavier) [this message] 2019-08-30 14:57 ` Ferruh Yigit 2019-08-30 6:16 ` Stephen Hemminger 2019-08-31 8:46 ` Wei Hu (Xavier) 2019-08-30 6:17 ` Stephen Hemminger 2019-08-31 8:44 ` Wei Hu (Xavier) 2019-09-03 15:27 ` Ye Xiaolong 2019-09-11 11:36 ` Wei Hu (Xavier) 2019-08-30 14:58 ` Ferruh Yigit 2019-09-10 11:43 ` Wei Hu (Xavier) 2019-08-30 15:00 ` Ferruh Yigit 2019-08-31 8:07 ` Wei Hu (Xavier) 2019-08-30 15:12 ` Ferruh Yigit 2019-08-31 8:07 ` Wei Hu (Xavier) 2019-08-30 15:23 ` [dpdk-dev] [PATCH 00/22] add hns3 ethernet PMD driver Ferruh Yigit 2019-08-31 8:06 ` Wei Hu (Xavier) 2019-09-02 4:24 [dpdk-dev] [PATCH 22/22] net/hns3: add hns3 build files Jerin Jacob Kollanukkaran 2019-09-06 12:21 ` Wei Hu (Xavier)
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=1faf6ee1-7dbf-4c58-994f-86a5ee09868f@huawei.com \ --to=xavier.huwei@huawei.com \ --cc=dev@dpdk.org \ --cc=forest.zhouchang@huawei.com \ --cc=jerinj@marvell.com \ --cc=linuxarm@huawei.com \ --cc=xavier_huwei@163.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
DPDK-dev Archive on lore.kernel.org Archives are clonable: git clone --mirror https://lore.kernel.org/dpdk-dev/0 dpdk-dev/git/0.git # If you have public-inbox 1.1+ installed, you may # initialize and index your mirror using the following commands: public-inbox-init -V2 dpdk-dev dpdk-dev/ https://lore.kernel.org/dpdk-dev \ dev@dpdk.org public-inbox-index dpdk-dev Example config snippet for mirrors Newsgroup available over NNTP: nntp://nntp.lore.kernel.org/org.dpdk.dev AGPL code for this site: git clone https://public-inbox.org/public-inbox.git