From mboxrd@z Thu Jan  1 00:00:00 1970
From: Stephen Hemminger <stephen@networkplumber.org>
Subject: Re: [PATCH 2/6] net/sfc: add support for driver-wide
 dynamic logging
Date: Thu, 25 Jan 2018 10:42:55 -0800
Message-ID: <20180125104255.57e0cd19@xeon-e3>
References: <1516899647-8541-1-git-send-email-arybchenko@solarflare.com>
 <1516899647-8541-3-git-send-email-arybchenko@solarflare.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Cc: <dev@dpdk.org>, Ivan Malov <ivan.malov@oktetlabs.ru>
To: Andrew Rybchenko <arybchenko@solarflare.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mail-pf0-f196.google.com (mail-pf0-f196.google.com
 [209.85.192.196]) by dpdk.org (Postfix) with ESMTP id 2E4152C2E
 for <dev@dpdk.org>; Thu, 25 Jan 2018 19:42:59 +0100 (CET)
Received: by mail-pf0-f196.google.com with SMTP id 23so6422351pfp.3
 for <dev@dpdk.org>; Thu, 25 Jan 2018 10:42:59 -0800 (PST)
In-Reply-To: <1516899647-8541-3-git-send-email-arybchenko@solarflare.com>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On Thu, 25 Jan 2018 17:00:43 +0000
Andrew Rybchenko <arybchenko@solarflare.com> wrote:

> diff --git a/drivers/net/sfc/efsys.h b/drivers/net/sfc/efsys.h
> index c7a54c3..8dd225e 100644
> --- a/drivers/net/sfc/efsys.h
> +++ b/drivers/net/sfc/efsys.h
> @@ -26,6 +26,7 @@
>  #include <rte_io.h>
>  
>  #include "sfc_debug.h"
> +#include "sfc_log.h"
>  
>  #ifdef __cplusplus
>  extern "C" {
> @@ -721,7 +722,7 @@ typedef uint64_t	efsys_stat_t;
>  #define EFSYS_ERR(_esip, _code, _dword0, _dword1)			\
>  	do {								\
>  		(void)(_esip);						\
> -		RTE_LOG(ERR, PMD, "FATAL ERROR #%u (0x%08x%08x)\n",	\
> +		SFC_GENERIC_LOG(ERR, "FATAL ERROR #%u (0x%08x%08x)",	\
>  			(_code), (_dword0), (_dword1));			\
>  		_NOTE(CONSTANTCONDITION);				\
>  	} while (B_FALSE)

Off topic, but why is this header file having C++ wrapper?
It is driver private, and driver is always built with C.