From mboxrd@z Thu Jan 1 00:00:00 1970 From: Adrien Mazarguil Subject: Re: [PATCH 3/3] net/mlx5: fix traffic restart function to return errors Date: Fri, 16 Feb 2018 15:26:51 +0100 Message-ID: <20180216142651.GG4256@6wind.com> References: <20fc1ef17c45c727fe72182fa0ba89313fdb430d.1518686930.git.nelio.laranjeiro@6wind.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: dev@dpdk.org, Yongseok Koh , stable@dpdk.org To: Nelio Laranjeiro Return-path: Received: from mail-wm0-f48.google.com (mail-wm0-f48.google.com [74.125.82.48]) by dpdk.org (Postfix) with ESMTP id 5AF051B29B for ; Fri, 16 Feb 2018 15:27:05 +0100 (CET) Received: by mail-wm0-f48.google.com with SMTP id f3so3475619wmc.1 for ; Fri, 16 Feb 2018 06:27:05 -0800 (PST) Content-Disposition: inline In-Reply-To: <20fc1ef17c45c727fe72182fa0ba89313fdb430d.1518686930.git.nelio.laranjeiro@6wind.com> List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Thu, Feb 15, 2018 at 10:29:27AM +0100, Nelio Laranjeiro wrote: > priv_dev_traffic_restart() was considering nothing could fail whereas it > can. How about simply describing it as: priv_dev_traffic_restart() must not ignore errors. > Fixes: 272733b5ebfd ("net/mlx5: use flow to enable unicast traffic") > Cc: stable@dpdk.org > > Signed-off-by: Nelio Laranjeiro > Acked-by: Yongseok Koh Acked-by: Adrien Mazarguil -- Adrien Mazarguil 6WIND