From mboxrd@z Thu Jan 1 00:00:00 1970 From: Pavan Nikhilesh Subject: Re: [PATCH v2 00/41] Memory Hotplug for DPDK Date: Thu, 8 Mar 2018 15:48:06 +0530 Message-ID: <20180308101805.GA9526@ltp-pvn> References: Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: dev@dpdk.org To: Anatoly Burakov , keith.wiles@intel.com, jianfeng.tan@intel.com, andras.kovacs@ericsson.com, laszlo.vadkeri@ericsson.com, benjamin.walker@intel.com, bruce.richardson@intel.com, thomas@monjalon.net, konstantin.ananyev@intel.com, kuralamudhan.ramakrishnan@intel.com, louise.m.daly@intel.com, nelio.laranjeiro@6wind.com, yskoh@mellanox.com, pepperjo@japf.ch, jerin.jacob@caviumnetworks.com, hemant.agrawal@nxp.com, olivier.matz@6wind.com Return-path: Received: from NAM03-CO1-obe.outbound.protection.outlook.com (mail-co1nam03on0082.outbound.protection.outlook.com [104.47.40.82]) by dpdk.org (Postfix) with ESMTP id A313E4CBB for ; Thu, 8 Mar 2018 11:18:38 +0100 (CET) Content-Disposition: inline In-Reply-To: List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi Anatoly, I am trying to verify this patchset and have encountered few issues. Few -Werror=maybe-uninitialized errors in eal_memalloc.c/eal_memory.c/ eal_common_memzone.c files. diff --git a/lib/librte_eal/common/eal_common_memzone.c b/lib/librte_eal/common/eal_common_memzone.c index a7cfdaf03..ad4413507 100644 --- a/lib/librte_eal/common/eal_common_memzone.c +++ b/lib/librte_eal/common/eal_common_memzone.c @@ -321,7 +321,7 @@ rte_memzone_free(const struct rte_memzone *mz) struct rte_fbarray *arr; struct rte_memzone *found_mz; int ret = 0; - void *addr; + void *addr = NULL; unsigned idx; if (mz == NULL) diff --git a/lib/librte_eal/linuxapp/eal/eal_memalloc.c b/lib/librte_eal/linuxapp/eal/eal_memalloc.c index 1008faed6..32b0d5133 100644 --- a/lib/librte_eal/linuxapp/eal/eal_memalloc.c +++ b/lib/librte_eal/linuxapp/eal/eal_memalloc.c @@ -570,7 +570,7 @@ eal_memalloc_alloc_page_bulk(struct rte_memseg **ms, int n, unsigned int msl_idx; int cur_idx, start_idx, end_idx, i, j, ret = -1; #ifdef RTE_EAL_NUMA_AWARE_HUGEPAGES - bool have_numa; + bool have_numa = false; int oldpolicy; struct bitmask *oldmask = numa_allocate_nodemask(); #endif diff --git a/lib/librte_eal/linuxapp/eal/eal_memory.c b/lib/librte_eal/linuxapp/eal/eal_memory.c index f74291fb6..d37b4a59b 100644 --- a/lib/librte_eal/linuxapp/eal/eal_memory.c +++ b/lib/librte_eal/linuxapp/eal/eal_memory.c @@ -1386,9 +1386,9 @@ eal_legacy_hugepage_attach(void) struct rte_mem_config *mcfg = rte_eal_get_configuration()->mem_config; struct hugepage_file *hp = NULL; unsigned int num_hp = 0; - unsigned int i; + unsigned int i = 0; int ms_idx, msl_idx; - unsigned int cur_seg, max_seg; + unsigned int cur_seg, max_seg = 0; off_t size = 0; int fd, fd_hugepage = -1; @Hemanth Also, this patchset breaks dpaa/dpaa2 bus drivers (they rely on `rte_eal_get_physmem_layout` that is depricated http://dpdk.org/dev/patchwork/patch/34002/) So, generic arm64 linuxapp build is broken. Regards, Pavan. On Wed, Mar 07, 2018 at 04:56:28PM +0000, Anatoly Burakov wrote: > This patchset introduces dynamic memory allocation for DPDK (aka memory > hotplug). Based upon RFC submitted in December [1]. > > Dependencies (to be applied in specified order): > - IPC bugfixes patchset [2] > - IPC improvements patchset [3] > - IPC asynchronous request API patch [4] > - Function to return number of sockets [5] > -- > 2.7.4