From mboxrd@z Thu Jan 1 00:00:00 1970 From: =?iso-8859-1?Q?Ga=EBtan?= Rivet Subject: Re: [PATCH 2/3] bus/pci: expose sysfs parsing API Date: Wed, 14 Mar 2018 14:30:35 +0100 Message-ID: <20180314133035.tmqgh2ghdyv3b47e@bidouze.vm.6wind.com> References: <20180309230809.63361-1-xiao.w.wang@intel.com> <20180309230809.63361-3-xiao.w.wang@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: 8bit Cc: Xiao Wang , dev@dpdk.org, zhihong.wang@intel.com, maxime.coquelin@redhat.com, yliu@fridaylinux.org, cunming.liang@intel.com, rosen.xu@intel.com, junjie.j.chen@intel.com, dan.daly@intel.com To: "Burakov, Anatoly" Return-path: Received: from mail-wr0-f196.google.com (mail-wr0-f196.google.com [209.85.128.196]) by dpdk.org (Postfix) with ESMTP id C295A4F9A for ; Wed, 14 Mar 2018 14:30:51 +0100 (CET) Received: by mail-wr0-f196.google.com with SMTP id z12so4791775wrg.4 for ; Wed, 14 Mar 2018 06:30:51 -0700 (PDT) Content-Disposition: inline In-Reply-To: List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi, On Wed, Mar 14, 2018 at 11:19:31AM +0000, Burakov, Anatoly wrote: > On 09-Mar-18 11:08 PM, Xiao Wang wrote: > > Some existing sysfs parsing functions are helpful for the later vDPA > > driver, this patch make them global and expose them to shared lib. > > > > Signed-off-by: Xiao Wang > > --- > > drivers/bus/pci/linux/pci.c | 9 ++++----- > > drivers/bus/pci/linux/pci_init.h | 8 ++++++++ > > drivers/bus/pci/rte_bus_pci_version.map | 8 ++++++++ > > 3 files changed, 20 insertions(+), 5 deletions(-) > > > > diff --git a/drivers/bus/pci/linux/pci.c b/drivers/bus/pci/linux/pci.c > > index abde64119..81e5e5650 100644 > > --- a/drivers/bus/pci/linux/pci.c > > +++ b/drivers/bus/pci/linux/pci.c > > @@ -32,7 +32,7 @@ > > extern struct rte_pci_bus rte_pci_bus; > > -static int > > +int > > pci_get_kernel_driver_by_path(const char *filename, char *dri_name) > > Here and in other places - shouldn't this too be prefixed with rte_? > A public PCI function should be prefixed by rte_pci_ yes. Additionally, if this function was to be exposed, then there should be a BSD implementation as well (shared map file). I don't know how BSD works, I'm not sure parsing the filesystem is the way to get a PCI driver name. If so, maybe the function should be called another, generic, way, that would work for both linux and BSD (and ideally, having a real BSD implementation). > > -- > Thanks, > Anatoly -- Gaëtan Rivet 6WIND