dev.dpdk.org archive mirror
 help / color / mirror / Atom feed
From: Shreyansh Jain <shreyansh.jain@nxp.com>
To: dev@dpdk.org
Cc: ferruh.yigit@intel.com, hemant.agrawal@nxp.com,
	nipun.gupta@nxp.com, akhil.goyal@nxp.com,
	Shreyansh Jain <shreyansh.jain@nxp.com>,
	pablo.de.lara.guarch@intel.com
Subject: [PATCH v3 6/7] crypto/dpaa2_sec: fix incorrect debugging prints
Date: Fri, 23 Mar 2018 17:34:55 +0530	[thread overview]
Message-ID: <20180323120456.16920-7-shreyansh.jain@nxp.com> (raw)
In-Reply-To: <20180323120456.16920-1-shreyansh.jain@nxp.com>

Digest and IV length variable declarations have changed.
These were escaping builds as the debugging macro was disabled.
During dynamic logging change, they were discoverd.

Fixes: 0fbd75a99fc9 ("cryptodev: move IV parameters to session")
Fixes: 7f0034275a24 ("cryptodev: remove digest length from crypto op")
Cc: pablo.de.lara.guarch@intel.com

Signed-off-by: Shreyansh Jain <shreyansh.jain@nxp.com>
Acked-by: Hemant Agrawal <hemant.agrawal@nxp.com>
---
 drivers/crypto/dpaa2_sec/dpaa2_sec_dpseci.c | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/drivers/crypto/dpaa2_sec/dpaa2_sec_dpseci.c b/drivers/crypto/dpaa2_sec/dpaa2_sec_dpseci.c
index 9a7484554..0c28b1d05 100644
--- a/drivers/crypto/dpaa2_sec/dpaa2_sec_dpseci.c
+++ b/drivers/crypto/dpaa2_sec/dpaa2_sec_dpseci.c
@@ -136,7 +136,7 @@ build_authenc_gcm_sg_fd(dpaa2_sec_session *sess,
 		   "iv-len=%d data_off: 0x%x\n",
 		   sym_op->aead.data.offset,
 		   sym_op->aead.data.length,
-		   sym_op->aead.digest.length,
+		   sess->digest_length,
 		   sess->iv.length,
 		   sym_op->m_src->data_off);
 
@@ -301,7 +301,7 @@ build_authenc_gcm_fd(dpaa2_sec_session *sess,
 		   "iv-len=%d data_off: 0x%x\n",
 		   sym_op->aead.data.offset,
 		   sym_op->aead.data.length,
-		   sym_op->aead.digest.length,
+		   sess->digest_length,
 		   sess->iv.length,
 		   sym_op->m_src->data_off);
 
@@ -433,10 +433,10 @@ build_authenc_sg_fd(dpaa2_sec_session *sess,
 			"cipher_off: 0x%x/length %d, iv-len=%d data_off: 0x%x\n",
 		   sym_op->auth.data.offset,
 		   sym_op->auth.data.length,
-		   sym_op->auth.digest.length,
+		   sess->digest_length,
 		   sym_op->cipher.data.offset,
 		   sym_op->cipher.data.length,
-		   sym_op->cipher.iv.length,
+		   sess->iv.length,
 		   sym_op->m_src->data_off);
 
 	/* Configure Output FLE with Scatter/Gather Entry */
@@ -877,7 +877,7 @@ build_cipher_sg_fd(dpaa2_sec_session *sess, struct rte_crypto_op *op,
 			"CIPHER SG: cipher_off: 0x%x/length %d,ivlen=%d data_off: 0x%x",
 		   sym_op->cipher.data.offset,
 		   sym_op->cipher.data.length,
-		   sym_op->cipher.iv.length,
+		   sess->iv.length,
 		   sym_op->m_src->data_off);
 
 	/* o/p fle */
-- 
2.14.1

  parent reply	other threads:[~2018-03-23 11:50 UTC|newest]

Thread overview: 50+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-03-12  9:25 [PATCH 0/7] Change DPAA2 to dynamic logging Shreyansh Jain
2018-03-12  9:25 ` [PATCH 1/7] bus/fslmc: change " Shreyansh Jain
2018-03-12  9:25 ` [PATCH 2/7] mempool/dpaa2: " Shreyansh Jain
2018-03-12  9:25 ` [PATCH 3/7] net/dpaa2: change into " Shreyansh Jain
2018-03-12 11:04   ` Ferruh Yigit
2018-03-12 12:01     ` Shreyansh Jain
2018-03-12  9:25 ` [PATCH 4/7] event/dpaa2: change to " Shreyansh Jain
2018-03-12  9:25 ` [PATCH 5/7] bus/fslmc: remove unused debug macros Shreyansh Jain
2018-03-12  9:25 ` [PATCH 6/7] crypto/dpaa2_sec: fix incorrect debugging prints Shreyansh Jain
2018-03-12  9:25 ` [PATCH 7/7] crypto/dpaa2_sec: change to dynamic logging Shreyansh Jain
2018-03-12 12:10 ` [PATCH 0/7] Change DPAA2 " Hemant Agrawal
2018-03-12 12:37 ` Shreyansh Jain
2018-03-13  5:44 ` [RESEND v2 " Shreyansh Jain
2018-03-13  5:44   ` [RESEND v2 1/7] bus/fslmc: change " Shreyansh Jain
2018-03-21  6:24     ` Hemant Agrawal
2018-03-13  5:44   ` [RESEND v2 2/7] mempool/dpaa2: " Shreyansh Jain
2018-03-21  6:27     ` Hemant Agrawal
2018-03-13  5:44   ` [RESEND v2 3/7] net/dpaa2: change into " Shreyansh Jain
2018-03-21  6:31     ` Hemant Agrawal
2018-03-23  7:19       ` Shreyansh Jain
2018-03-13  5:44   ` [RESEND v2 4/7] event/dpaa2: change to " Shreyansh Jain
2018-03-14  4:01     ` Nipun Gupta
2018-03-13  5:44   ` [RESEND v2 5/7] bus/fslmc: remove unused debug macros Shreyansh Jain
2018-03-21  6:13     ` Hemant Agrawal
2018-03-13  5:44   ` [RESEND v2 6/7] crypto/dpaa2_sec: fix incorrect debugging prints Shreyansh Jain
2018-03-21  6:12     ` Hemant Agrawal
2018-03-13  5:44   ` [RESEND v2 7/7] crypto/dpaa2_sec: change to dynamic logging Shreyansh Jain
2018-03-21  6:18     ` Hemant Agrawal
2018-03-23 12:04   ` [PATCH v3 0/7] Change DPAA2 " Shreyansh Jain
2018-03-23 12:04     ` [PATCH v3 1/7] bus/fslmc: change " Shreyansh Jain
2018-03-23 12:04     ` [PATCH v3 2/7] mempool/dpaa2: " Shreyansh Jain
2018-03-26  8:48       ` Hemant Agrawal
2018-03-23 12:04     ` [PATCH v3 3/7] net/dpaa2: change into " Shreyansh Jain
2018-03-26  8:48       ` Hemant Agrawal
2018-03-29 15:26       ` Thomas Monjalon
2018-03-29 18:01         ` Shreyansh Jain
2018-03-23 12:04     ` [PATCH v3 4/7] event/dpaa2: change to " Shreyansh Jain
2018-03-23 12:04     ` [PATCH v3 5/7] bus/fslmc: remove unused debug macros Shreyansh Jain
2018-03-23 12:04     ` Shreyansh Jain [this message]
2018-03-23 12:04     ` [PATCH v3 7/7] crypto/dpaa2_sec: change to dynamic logging Shreyansh Jain
2018-04-02 14:05     ` [PATCH v4 0/7] Change DPAA2 " Shreyansh Jain
2018-04-02 14:05       ` [PATCH v4 1/7] bus/fslmc: change " Shreyansh Jain
2019-12-03 15:35         ` [dpdk-dev] " Ferruh Yigit
2018-04-02 14:05       ` [PATCH v4 2/7] mempool/dpaa2: " Shreyansh Jain
2018-04-02 14:05       ` [PATCH v4 3/7] net/dpaa2: change into " Shreyansh Jain
2018-04-02 14:05       ` [PATCH v4 4/7] event/dpaa2: change to " Shreyansh Jain
2018-04-02 14:05       ` [PATCH v4 5/7] bus/fslmc: remove unused debug macros Shreyansh Jain
2018-04-02 14:06       ` [PATCH v4 6/7] crypto/dpaa2_sec: fix incorrect debugging prints Shreyansh Jain
2018-04-02 14:06       ` [PATCH v4 7/7] crypto/dpaa2_sec: change to dynamic logging Shreyansh Jain
2018-04-02 22:03       ` [PATCH v4 0/7] Change DPAA2 " Thomas Monjalon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180323120456.16920-7-shreyansh.jain@nxp.com \
    --to=shreyansh.jain@nxp.com \
    --cc=akhil.goyal@nxp.com \
    --cc=dev@dpdk.org \
    --cc=ferruh.yigit@intel.com \
    --cc=hemant.agrawal@nxp.com \
    --cc=nipun.gupta@nxp.com \
    --cc=pablo.de.lara.guarch@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).