From mboxrd@z Thu Jan  1 00:00:00 1970
From: Bruce Richardson <bruce.richardson@intel.com>
Subject: Re: [PATCH v3 02/20] kvargs: build before EAL
Date: Tue, 27 Mar 2018 10:12:20 +0100
Message-ID: <20180327091220.GA23992@bricha3-MOBL.ger.corp.intel.com>
References: <cover.1522105876.git.gaetan.rivet@6wind.com>
 <996543406679ba5e61341a71c030f06dd83f4ccf.1522105876.git.gaetan.rivet@6wind.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: dev@dpdk.org
To: Gaetan Rivet <gaetan.rivet@6wind.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mga11.intel.com (mga11.intel.com [192.55.52.93])
 by dpdk.org (Postfix) with ESMTP id E588C4CBB
 for <dev@dpdk.org>; Tue, 27 Mar 2018 11:12:50 +0200 (CEST)
Content-Disposition: inline
In-Reply-To: <996543406679ba5e61341a71c030f06dd83f4ccf.1522105876.git.gaetan.rivet@6wind.com>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On Tue, Mar 27, 2018 at 01:18:26AM +0200, Gaetan Rivet wrote:
> Signed-off-by: Gaetan Rivet <gaetan.rivet@6wind.com>
> ---
>  lib/Makefile                                                      | 3 +--
>  lib/librte_eal/common/Makefile                                    | 2 +-
>  lib/librte_kvargs/Makefile                                        | 2 +-
>  lib/librte_kvargs/rte_kvargs.c                                    | 3 +--
>  lib/{librte_eal/common/include => librte_kvargs}/rte_string_fns.h | 0
>  5 files changed, 4 insertions(+), 6 deletions(-)
>  rename lib/{librte_eal/common/include => librte_kvargs}/rte_string_fns.h (100%)
> 
Don't forget to update the meson.build file. You need to move kvargs before
EAL in the list of libraries, and modify the special case for
default dependencies for non-EAL libs.

/Bruce