From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stephen Hemminger Subject: Re: [PATCH v3 03/68] eal: make malloc heap a doubly-linked list Date: Tue, 3 Apr 2018 16:32:40 -0700 Message-ID: <20180403163240.2b14d418@xeon-e3> References: <02cfd92be8f1b013c932a792445facd1e3383a36.1522797505.git.anatoly.burakov@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Cc: dev@dpdk.org, keith.wiles@intel.com, jianfeng.tan@intel.com, andras.kovacs@ericsson.com, laszlo.vadkeri@ericsson.com, benjamin.walker@intel.com, bruce.richardson@intel.com, thomas@monjalon.net, konstantin.ananyev@intel.com, kuralamudhan.ramakrishnan@intel.com, louise.m.daly@intel.com, nelio.laranjeiro@6wind.com, yskoh@mellanox.com, pepperjo@japf.ch, jerin.jacob@caviumnetworks.com, hemant.agrawal@nxp.com, olivier.matz@6wind.com, shreyansh.jain@nxp.com, gowrishankar.m@linux.vnet.ibm.com To: Anatoly Burakov Return-path: Received: from mail-pl0-f66.google.com (mail-pl0-f66.google.com [209.85.160.66]) by dpdk.org (Postfix) with ESMTP id 257EE1BB00 for ; Wed, 4 Apr 2018 01:32:46 +0200 (CEST) Received: by mail-pl0-f66.google.com with SMTP id v5-v6so9319331plo.4 for ; Tue, 03 Apr 2018 16:32:46 -0700 (PDT) In-Reply-To: <02cfd92be8f1b013c932a792445facd1e3383a36.1522797505.git.anatoly.burakov@intel.com> List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Wed, 4 Apr 2018 00:21:15 +0100 Anatoly Burakov wrote: > As we are preparing for dynamic memory allocation, we need to be > able to handle holes in our malloc heap, hence we're switching to > doubly linked list, and prepare infrastructure to support it. > > Since our heap is now aware where are our first and last elements, > there is no longer any need to have a dummy element at the end of > each heap, so get rid of that as well. Instead, let insert/remove/ > join/split operations handle end-of-list conditions automatically. > > Signed-off-by: Anatoly Burakov Dummy element at end of heap could be helpful for purify/valgrind style verification that code does not exceed allocation.