From mboxrd@z Thu Jan  1 00:00:00 1970
From: =?iso-8859-1?Q?Ga=EBtan?= Rivet <gaetan.rivet@6wind.com>
Subject: Re: [PATCH v9 20/27] ethdev: register ether layer as a
 class
Date: Thu, 5 Jul 2018 13:54:26 +0200
Message-ID: <20180705115426.gd6j7t6ox336pqpe@bidouze.vm.6wind.com>
References: <cover.1530655929.git.gaetan.rivet@6wind.com>
 <58a5a7ac27a6ac6206246e8534ebf67168813318.1530655929.git.gaetan.rivet@6wind.com>
 <5a604a07-0a77-3a13-5e55-87de42e73f02@solarflare.com>
 <20180705093638.vsijoifid3z4bdx4@bidouze.vm.6wind.com>
 <20180705111355.GA23212@bricha3-MOBL.ger.corp.intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Transfer-Encoding: 8bit
Cc: Andrew Rybchenko <arybchenko@solarflare.com>, dev@dpdk.org
To: Bruce Richardson <bruce.richardson@intel.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mail-wm0-f67.google.com (mail-wm0-f67.google.com [74.125.82.67])
 by dpdk.org (Postfix) with ESMTP id 424C01BDED
 for <dev@dpdk.org>; Thu,  5 Jul 2018 13:54:44 +0200 (CEST)
Received: by mail-wm0-f67.google.com with SMTP id s12-v6so10678623wmc.1
 for <dev@dpdk.org>; Thu, 05 Jul 2018 04:54:44 -0700 (PDT)
Content-Disposition: inline
In-Reply-To: <20180705111355.GA23212@bricha3-MOBL.ger.corp.intel.com>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On Thu, Jul 05, 2018 at 12:13:56PM +0100, Bruce Richardson wrote:
> On Thu, Jul 05, 2018 at 11:36:38AM +0200, Gaëtan Rivet wrote:
> > Hi Andrew,
> > 
> > On Wed, Jul 04, 2018 at 03:20:17PM +0300, Andrew Rybchenko wrote:
> > > On 07/04/2018 01:15 AM, Gaetan Rivet wrote:
> > > > Signed-off-by: Gaetan Rivet <gaetan.rivet@6wind.com>
> > > > ---
> > > >   lib/librte_ethdev/Makefile        |  3 +-
> > > >   lib/librte_ethdev/rte_class_eth.c | 79 +++++++++++++++++++++++++++++++++++++++
> > > >   2 files changed, 81 insertions(+), 1 deletion(-)
> > > >   create mode 100644 lib/librte_ethdev/rte_class_eth.c
> > > > 
> > > > diff --git a/lib/librte_ethdev/Makefile b/lib/librte_ethdev/Makefile
> > > > index 2fa133fbc..d4c3a8d06 100644
> > > > --- a/lib/librte_ethdev/Makefile
> > > > +++ b/lib/librte_ethdev/Makefile
> > > > @@ -12,7 +12,7 @@ CFLAGS += -DALLOW_EXPERIMENTAL_API
> > > >   CFLAGS += -O3
> > > >   CFLAGS += $(WERROR_FLAGS)
> > > >   LDLIBS += -lrte_net -lrte_eal -lrte_mempool -lrte_ring
> > > > -LDLIBS += -lrte_mbuf
> > > > +LDLIBS += -lrte_mbuf -lrte_kvargs
> > > >   EXPORT_MAP := rte_ethdev_version.map
> > > > @@ -20,6 +20,7 @@ LIBABIVER := 9
> > > >   SRCS-y += eth_private.c
> > > >   SRCS-y += rte_ethdev.c
> > > > +SRCS-y += rte_class_eth.c
> > > >   SRCS-y += rte_flow.c
> > > >   SRCS-y += rte_tm.c
> > > >   SRCS-y += rte_mtr.c
> > > 
> > > meson.build files should be updated as well.
> > 
> > The meson version required by DPDK is not available in my distribution.
> > 
> "pip3 install meson" works in just about all distros. I'd recommend using
> meson from pip generally, since it tends to be very up to date. The latest
> versions configure DPDK a lot faster than the older ones!
> 
> /Bruce

Thanks,

The v10 now supports meson.

-- 
Gaëtan Rivet
6WIND