From: Bruce Richardson <bruce.richardson@intel.com>
To: Gavin Hu <gavin.hu@arm.com>
Cc: dev@dpdk.org, nd@arm.com, thomas@monjalon.net,
jerin.jacob@caviumnetworks.com, hemant.agrawal@nxp.com,
Honnappa.Nagarahalli@arm.com, stable@dpdk.org
Subject: Re: [PATCH v2 2/2] hash: flush the rings instead of dequeuing one by one
Date: Wed, 12 Dec 2018 03:15:59 -0700 [thread overview]
Message-ID: <20181212101558.GB28296@bricha3-MOBL.ger.corp.intel.com> (raw)
In-Reply-To: <20181212064733.1008-3-gavin.hu@arm.com>
On Wed, Dec 12, 2018 at 02:47:33PM +0800, Gavin Hu wrote:
> Within rte_hash_reset, calling a while loop to dequeue one by
> one from the ring, while not using them at all, is wasting cycles,
> The patch just flush the ring by resetting the indices can save cpu
> cycles.
>
> Fixes: b26473ff8f4a ("hash: add reset function")
> Fixes: 75706568a7eb ("hash: add extendable bucket feature")
> Cc: stable@dpdk.org
>
> Signed-off-by: Gavin Hu <gavin.hu@arm.com>
> Reviewed-by: Honnappa Nagarahalli <Honnappa.Nagarahalli@arm.com>
> ---
> lib/librte_hash/Makefile | 2 +-
> lib/librte_hash/rte_cuckoo_hash.c | 11 ++++-------
> 2 files changed, 5 insertions(+), 8 deletions(-)
>
> diff --git a/lib/librte_hash/Makefile b/lib/librte_hash/Makefile
> index c8c435dfd..5669d83f4 100644
> --- a/lib/librte_hash/Makefile
> +++ b/lib/librte_hash/Makefile
> @@ -6,7 +6,7 @@ include $(RTE_SDK)/mk/rte.vars.mk
> # library name
> LIB = librte_hash.a
>
> -CFLAGS += -O3
> +CFLAGS += -O3 -DALLOW_EXPERIMENTAL_API
> CFLAGS += $(WERROR_FLAGS) -I$(SRCDIR)
> LDLIBS += -lrte_eal -lrte_ring
>
Is a similar change needed to meson.build?
next prev parent reply other threads:[~2018-12-12 10:15 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-12 6:24 [PATCH v1 0/2] add rte_ring_reset and use it to flush a ring Gavin Hu
2018-12-12 6:24 ` [PATCH v1 1/2] ring: add rte_ring_reset api to flush the ring Gavin Hu
2018-12-12 6:24 ` [PATCH v1 2/2] hash: flush the rings instead of dequeuing one by one Gavin Hu
2018-12-12 6:47 ` [PATCH v2 0/2] add rte ring reset api and use it to flush a ring by hash Gavin Hu
2018-12-12 6:47 ` [PATCH v2 1/2] ring: add reset api to flush the ring when not in use Gavin Hu
2018-12-12 6:47 ` [PATCH v2 2/2] hash: flush the rings instead of dequeuing one by one Gavin Hu
2018-12-12 10:15 ` Bruce Richardson [this message]
2018-12-12 19:28 ` Mattias Rönnblom
2019-03-15 3:31 ` [PATCH v7 0/2] new ring reset api and use it by hash Gavin Hu
2019-03-15 3:31 ` [PATCH v7 1/2] ring: add reset API to flush the ring when not in use Gavin Hu
2019-03-29 14:17 ` Olivier Matz
2019-07-04 14:42 ` [dpdk-dev] " Thomas Monjalon
2019-07-12 9:32 ` Gavin Hu (Arm Technology China)
2019-07-12 9:53 ` Olivier Matz
2019-07-12 11:06 ` Gavin Hu (Arm Technology China)
2019-07-12 11:48 ` Olivier Matz
2019-07-12 15:07 ` Gavin Hu (Arm Technology China)
2019-07-12 15:40 ` Honnappa Nagarahalli
2019-07-12 16:01 ` Gavin Hu (Arm Technology China)
2019-07-16 8:47 ` Olivier Matz
2019-07-16 9:00 ` Olivier Matz
2019-03-15 3:31 ` [PATCH v7 2/2] hash: flush the rings instead of dequeuing one by one Gavin Hu
2019-07-12 9:26 ` [dpdk-dev] [PATCH v8 0/2] new ring reset api and use it by hash Gavin Hu
2019-07-12 9:26 ` [dpdk-dev] [PATCH v8 1/2] ring: add reset API to flush the ring when not in use Gavin Hu
2019-07-12 9:26 ` [dpdk-dev] [PATCH v8 2/2] hash: flush the rings instead of dequeuing one by one Gavin Hu
2019-07-12 15:54 ` [dpdk-dev] [PATCH v9 0/2] new ring reset api and use it by hash Gavin Hu
2019-07-12 15:54 ` [dpdk-dev] [PATCH v9 1/2] ring: add reset API to flush the ring when not in use Gavin Hu
2019-07-16 9:01 ` Olivier Matz
2019-07-16 11:31 ` Olivier Matz
2019-07-16 14:03 ` Gavin Hu (Arm Technology China)
2019-07-16 15:06 ` Thomas Monjalon
2019-07-16 19:25 ` Gavin Hu (Arm Technology China)
2019-07-12 15:54 ` [dpdk-dev] [PATCH v9 2/2] hash: flush the rings instead of dequeuing one by one Gavin Hu
2019-07-16 19:23 ` [dpdk-dev] [PATCH v10 0/2] new ring reset api and use it by hash Gavin Hu
2019-07-17 17:53 ` Thomas Monjalon
2019-07-16 19:23 ` [dpdk-dev] [PATCH v10 1/2] ring: add reset API to flush the ring when not in use Gavin Hu
2019-07-16 19:23 ` [dpdk-dev] [PATCH v10 2/2] hash: flush the rings instead of dequeuing one by one Gavin Hu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181212101558.GB28296@bricha3-MOBL.ger.corp.intel.com \
--to=bruce.richardson@intel.com \
--cc=Honnappa.Nagarahalli@arm.com \
--cc=dev@dpdk.org \
--cc=gavin.hu@arm.com \
--cc=hemant.agrawal@nxp.com \
--cc=jerin.jacob@caviumnetworks.com \
--cc=nd@arm.com \
--cc=stable@dpdk.org \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).