From: Bruce Richardson <bruce.richardson@intel.com>
To: Thomas Monjalon <thomas@monjalon.net>
Cc: konstantin.ananyev@intel.com, adrien.mazarguil@6wind.com,
dev@dpdk.org, Marcin Smoczynski <marcinx.smoczynski@intel.com>
Subject: Re: [dpdk-dev] [PATCH v2 1/1] build: enable BSD features visibility for FreeBSD
Date: Wed, 5 Jun 2019 11:02:26 +0100 [thread overview]
Message-ID: <20190605100226.GA1550@bricha3-MOBL.ger.corp.intel.com> (raw)
In-Reply-To: <1847238.2vmrsgWslk@xps>
On Wed, Jun 05, 2019 at 11:37:34AM +0200, Thomas Monjalon wrote:
> Marcin, please remind to use --in-reply-to to have next versions
> in the same thread. Thanks
>
> Bruce, Konstantin, Adrien, any opinion about this patch?
>
Looks a reasonable cleanup to me. The fact that the same macros are being
defined in multiple places implies that it would be good to consolidate
them.
>
> 14/05/2019 16:04, Marcin Smoczynski:
> > When a component uses either XOPEN_SOURCE or POSIX_C_SOURCE macro
> > explicitly in its build recipe, it restricts visibility of a non POSIX
> > features subset, such as IANA protocol numbers (IPPROTO_* macros).
> > Non standard features are enabled by default for DPDK both for Linux
> > thanks to _GNU_SOURCE and for FreeBSD thanks to __BSD_VISIBLE. However
> > using XOPEN_SOURCE or POSIX_(C_)SOURCE in a component causes
> > __BSD_VISIBLE to be defined to 0 for FreeBSD, causing different feature
> > sets visibility for Linux and FreeBSD. It restricts from using IPPROTO
> > macros in public headers, such as rte_ip.h, despite the fact they are
> > already widely used in sources.
> >
> > Add __BSD_VISIBLE macro specified unconditionally for FreeBSD targets
> > which enforces feature sets visibility unification between Linux and
> > FreeBSD.
> >
> > Add single -D_GNU_SOURCE to config/meson.build as a project argument
> > instead of adding separate directive for each project subtree.
> >
> > This patch solves the problem of build breaks for [1] on FreeBSD [2]
> > following the discussion [3].
> >
> > [1] https://mails.dpdk.org/archives/dev/2019-May/131885.html
> > [2] http://mails.dpdk.org/archives/test-report/2019-May/082263.html
> > [3] https://mails.dpdk.org/archives/dev/2019-May/132110.html
> >
> > Signed-off-by: Marcin Smoczynski <marcinx.smoczynski@intel.com>
>
Acked-by: Bruce Richardson <bruce.richardson@intel.com>
next prev parent reply other threads:[~2019-06-05 10:02 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-14 14:04 [dpdk-dev] [PATCH v2 0/1] Enable BSD features visibility for FreeBSD Marcin Smoczynski
2019-05-14 14:04 ` [dpdk-dev] [PATCH v2 1/1] build: enable " Marcin Smoczynski
2019-06-05 9:37 ` Thomas Monjalon
2019-06-05 10:02 ` Bruce Richardson [this message]
2019-06-05 10:15 ` Ananyev, Konstantin
2019-06-17 12:36 ` Smoczynski, MarcinX
2019-06-26 14:51 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190605100226.GA1550@bricha3-MOBL.ger.corp.intel.com \
--to=bruce.richardson@intel.com \
--cc=adrien.mazarguil@6wind.com \
--cc=dev@dpdk.org \
--cc=konstantin.ananyev@intel.com \
--cc=marcinx.smoczynski@intel.com \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).