From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.5 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 30694C04AB5 for ; Thu, 6 Jun 2019 08:23:31 +0000 (UTC) Received: from dpdk.org (dpdk.org [92.243.14.124]) by mail.kernel.org (Postfix) with ESMTP id E07BD20866 for ; Thu, 6 Jun 2019 08:23:30 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org E07BD20866 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=intel.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=dev-bounces@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id CE6E31B951; Thu, 6 Jun 2019 10:23:29 +0200 (CEST) Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by dpdk.org (Postfix) with ESMTP id 7D1D45424 for ; Thu, 6 Jun 2019 10:23:28 +0200 (CEST) X-Amp-Result: UNSCANNABLE X-Amp-File-Uploaded: False Received: from fmsmga007.fm.intel.com ([10.253.24.52]) by orsmga105.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 06 Jun 2019 01:23:27 -0700 X-ExtLoop1: 1 Received: from bricha3-mobl.ger.corp.intel.com ([10.237.221.51]) by fmsmga007.fm.intel.com with SMTP; 06 Jun 2019 01:23:24 -0700 Received: by (sSMTP sendmail emulation); Thu, 06 Jun 2019 09:23:23 +0100 Date: Thu, 6 Jun 2019 09:23:23 +0100 From: Bruce Richardson To: Xiaoyun Li Cc: jingjing.wu@intel.com, keith.wiles@intel.com, cunming.liang@intel.com, omkar.maslekar@intel.com, dev@dpdk.org, thomas@monjalon.net Message-ID: <20190606082323.GA1586@bricha3-MOBL.ger.corp.intel.com> References: <20190603084611.40931-1-xiaoyun.li@intel.com> <20190606074303.104108-1-xiaoyun.li@intel.com> <20190606074303.104108-6-xiaoyun.li@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190606074303.104108-6-xiaoyun.li@intel.com> User-Agent: Mutt/1.11.4 (2019-03-13) Subject: Re: [dpdk-dev] [PATCH v2 5/6] usertools/dpdk-devbind.py: add support for ntb X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Thu, Jun 06, 2019 at 03:43:02PM +0800, Xiaoyun Li wrote: > In order to allow binding/unbinding of devices for use by the > ntb_rawdev, we need to update the devbind script to add a new class > of device, and add device ids for the specific HW instances. And > only support skx platform right now. > > Signed-off-by: Xiaoyun Li > --- > usertools/dpdk-devbind.py | 9 +++++++++ > 1 file changed, 9 insertions(+) > > diff --git a/usertools/dpdk-devbind.py b/usertools/dpdk-devbind.py > index 9e79f0d28..3f7eafe28 100755 > --- a/usertools/dpdk-devbind.py > +++ b/usertools/dpdk-devbind.py > @@ -36,11 +36,15 @@ > octeontx2_npa = {'Class': '08', 'Vendor': '177d', 'Device': 'a0fb,a0fc', > 'SVendor': None, 'SDevice': None} > > +intel_ntb_skx = {'Class': '06', 'Vendor': '8086', 'Device': '201c', > + 'SVendor': None, 'SDevice': None} > + > network_devices = [network_class, cavium_pkx, avp_vnic, ifpga_class] > crypto_devices = [encryption_class, intel_processor_class] > eventdev_devices = [cavium_sso, cavium_tim, octeontx2_sso] > mempool_devices = [cavium_fpa, octeontx2_npa] > compress_devices = [cavium_zip] > +communication_devices = [intel_ntb_skx] > Looking at this patch, and my own rawdev set for adding the ioat driver, I wonder if it's really a good idea to add new categories for each rawdev device type. Given we don't know how many device types there will be overall, I wonder if it's better to just add a "misc" or "other" device type section, where we put all raw devices. /Bruce