From: Ajit Khaparde <ajit.khaparde@broadcom.com>
To: dev@dpdk.org
Cc: ferruh.yigit@intel.com,
Somnath Kotur <somnath.kotur@broadcom.com>,
Kalesh AP <kalesh-anakkur.purayil@broadcom.com>
Subject: [dpdk-dev] [PATCH 2/6] net/bnxt: fix to check for NULL completion ring doorbell in int_handler
Date: Sat, 8 Jun 2019 23:22:04 +0400 [thread overview]
Message-ID: <20190608192208.77607-3-ajit.khaparde@broadcom.com> (raw)
In-Reply-To: <20190608192208.77607-1-ajit.khaparde@broadcom.com>
From: Somnath Kotur <somnath.kotur@broadcom.com>
It is observed that sometimes during init, the bnxt_int_handler() gets
invoked while the cpr->cp_db.doorbell is not yet initialized. Check for
the same and return.
Signed-off-by: Somnath Kotur <somnath.kotur@broadcom.com>
Signed-off-by: Kalesh AP <kalesh-anakkur.purayil@broadcom.com>
Signed-off-by: Ajit Khaparde <ajit.khaparde@broadcom.com>
---
drivers/net/bnxt/bnxt_irq.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/bnxt/bnxt_irq.c b/drivers/net/bnxt/bnxt_irq.c
index 918f3dcf4..e1b9a2b04 100644
--- a/drivers/net/bnxt/bnxt_irq.c
+++ b/drivers/net/bnxt/bnxt_irq.c
@@ -31,7 +31,7 @@ static void bnxt_int_handler(void *param)
raw_cons = cpr->cp_raw_cons;
while (1) {
- if (!cpr || !cpr->cp_ring_struct)
+ if (!cpr || !cpr->cp_ring_struct || !cpr->cp_db.cp_doorbell)
return;
cons = RING_CMP(cpr->cp_ring_struct, raw_cons);
--
2.20.1 (Apple Git-117)
next prev parent reply other threads:[~2019-06-08 19:22 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-08 19:22 [dpdk-dev] [PATCH 0/6] bnxt patch series Ajit Khaparde
2019-06-08 19:22 ` [dpdk-dev] [PATCH 1/6] net/bnxt: add code to redirect tunnel packets Ajit Khaparde
2019-06-08 19:22 ` Ajit Khaparde [this message]
2019-06-12 14:44 ` [dpdk-dev] [PATCH 2/6] net/bnxt: fix to check for NULL completion ring doorbell in int_handler Ferruh Yigit
2019-06-12 14:49 ` Ferruh Yigit
2019-06-08 19:22 ` [dpdk-dev] [PATCH 3/6] net/bnxt: driver to use configured MTU value during load Ajit Khaparde
2019-06-08 19:22 ` [dpdk-dev] [PATCH 4/6] net/bnxt: fix output of port xstats Ajit Khaparde
2019-06-08 19:22 ` [dpdk-dev] [PATCH 5/6] net/bnxt: fix interrupt vector array initialization Ajit Khaparde
2019-06-08 19:22 ` [dpdk-dev] [PATCH 6/6] net/bnxt: address build errors reported by intel compiler Ajit Khaparde
2019-06-12 15:41 ` [dpdk-dev] [PATCH 0/6] bnxt patch series Ferruh Yigit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190608192208.77607-3-ajit.khaparde@broadcom.com \
--to=ajit.khaparde@broadcom.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=kalesh-anakkur.purayil@broadcom.com \
--cc=somnath.kotur@broadcom.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).