From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A1DA3C282DD for ; Mon, 10 Jun 2019 11:12:11 +0000 (UTC) Received: from dpdk.org (dpdk.org [92.243.14.124]) by mail.kernel.org (Postfix) with ESMTP id 5B482206C3 for ; Mon, 10 Jun 2019 11:12:11 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 5B482206C3 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=intel.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=dev-bounces@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 1A61D1C00F; Mon, 10 Jun 2019 13:12:10 +0200 (CEST) Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by dpdk.org (Postfix) with ESMTP id 7DDF51BFAD for ; Mon, 10 Jun 2019 13:12:08 +0200 (CEST) X-Amp-Result: UNSCANNABLE X-Amp-File-Uploaded: False Received: from orsmga002.jf.intel.com ([10.7.209.21]) by orsmga102.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 10 Jun 2019 04:12:07 -0700 X-ExtLoop1: 1 Received: from bricha3-mobl.ger.corp.intel.com ([10.252.23.18]) by orsmga002.jf.intel.com with SMTP; 10 Jun 2019 04:12:04 -0700 Received: by (sSMTP sendmail emulation); Mon, 10 Jun 2019 12:12:04 +0100 Date: Mon, 10 Jun 2019 12:12:03 +0100 From: Bruce Richardson To: Igor Ryzhov Cc: dev@dpdk.org Message-ID: <20190610111203.GA1930@bricha3-MOBL.ger.corp.intel.com> References: <20190610082552.79083-1-iryzhov@nfware.com> <20190610093717.GA1925@bricha3-MOBL.ger.corp.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.11.4 (2019-03-13) Subject: Re: [dpdk-dev] [PATCH] kernel/linux: fix modules install path X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Mon, Jun 10, 2019 at 02:04:26PM +0300, Igor Ryzhov wrote: > Bruce, > From my understanding, kernel_dir is a directory with kernel headers > needed > for modules building. Right now, yes. I'd suggest that we change that to the actual kernel modules directory, and we get both the build directory and the install directory based off that. > When it's formed automatically, yes, it will be > "/lib/modules/version/build" and we can get installation directory by > stripping > "/build". Well, I'd suggest if we query the value automatically we don't both adding the build, and just add that later when building the modules, i.e. kernel_dir should always be the the base directory without "build" on it. > But when it's set manually, it can be set to, for example, > "/usr/src/linux-headers-version", and build will be successful, but we > won't be > able to strip "/build" as there is no "/build". > Which path should be used for installation in cross-compile case, when > the > kernel_dir is set manually? The stripping "build" was just a suggestion to allow the value to be specified either with or without the "build/" suffix and have things work. For the paths specified in the cross-compile case, my thinking was that we would: * build using /build * install to /extra/dpdk as with the non-cross-compile case. /Bruce