DPDK-dev Archive on lore.kernel.org
 help / color / Atom feed
* [dpdk-dev] [PATCH] Revert "net/mlx: support IOVA VA mode"
@ 2019-06-07 23:08 Stephen Hemminger
  2019-06-12 21:39 ` Stephen Hemminger
                   ` (2 more replies)
  0 siblings, 3 replies; 6+ messages in thread
From: Stephen Hemminger @ 2019-06-07 23:08 UTC (permalink / raw)
  To: dev; +Cc: Stephen Hemminger

From: Stephen Hemminger <sthemmin@microsoft.com>

This reverts commit 69c06d0e357ed0064b498d510d169603cf7308cd.
That commit breaks support for netvsc PMD with MLX SRIOV
on both Hyper-V and Azure.

Signed-off-by: Stephen Hemminger <sthemmin@microsoft.com>
---
 drivers/net/mlx4/mlx4.c | 4 ++--
 drivers/net/mlx5/mlx5.c | 4 ++--
 2 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/drivers/net/mlx4/mlx4.c b/drivers/net/mlx4/mlx4.c
index aa4d43fad78a..4d84a923d2ff 100644
--- a/drivers/net/mlx4/mlx4.c
+++ b/drivers/net/mlx4/mlx4.c
@@ -1142,8 +1142,8 @@ static struct rte_pci_driver mlx4_driver = {
 	},
 	.id_table = mlx4_pci_id_map,
 	.probe = mlx4_pci_probe,
-	.drv_flags = RTE_PCI_DRV_INTR_LSC | RTE_PCI_DRV_INTR_RMV |
-		     RTE_PCI_DRV_IOVA_AS_VA,
+	.drv_flags = RTE_PCI_DRV_INTR_LSC |
+		     RTE_PCI_DRV_INTR_RMV,
 };
 
 #ifdef RTE_IBVERBS_LINK_DLOPEN
diff --git a/drivers/net/mlx5/mlx5.c b/drivers/net/mlx5/mlx5.c
index daadf4a7a7f9..912d80e16d09 100644
--- a/drivers/net/mlx5/mlx5.c
+++ b/drivers/net/mlx5/mlx5.c
@@ -2107,8 +2107,8 @@ static struct rte_pci_driver mlx5_driver = {
 	.remove = mlx5_pci_remove,
 	.dma_map = mlx5_dma_map,
 	.dma_unmap = mlx5_dma_unmap,
-	.drv_flags = RTE_PCI_DRV_INTR_LSC | RTE_PCI_DRV_INTR_RMV |
-		     RTE_PCI_DRV_PROBE_AGAIN | RTE_PCI_DRV_IOVA_AS_VA,
+	.drv_flags = (RTE_PCI_DRV_INTR_LSC | RTE_PCI_DRV_INTR_RMV |
+		      RTE_PCI_DRV_PROBE_AGAIN),
 };
 
 #ifdef RTE_IBVERBS_LINK_DLOPEN
-- 
2.20.1


^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [dpdk-dev] [PATCH] Revert "net/mlx: support IOVA VA mode"
  2019-06-07 23:08 [dpdk-dev] [PATCH] Revert "net/mlx: support IOVA VA mode" Stephen Hemminger
@ 2019-06-12 21:39 ` Stephen Hemminger
  2019-06-20 22:30 ` Stephen Hemminger
  2019-07-09 14:39 ` Stephen Hemminger
  2 siblings, 0 replies; 6+ messages in thread
From: Stephen Hemminger @ 2019-06-12 21:39 UTC (permalink / raw)
  To: Shahaf Shuler; +Cc: dev

On Fri,  7 Jun 2019 16:08:41 -0700
Stephen Hemminger <stephen@networkplumber.org> wrote:

> From: Stephen Hemminger <sthemmin@microsoft.com>
> 
> This reverts commit 69c06d0e357ed0064b498d510d169603cf7308cd.
> That commit breaks support for netvsc PMD with MLX SRIOV
> on both Hyper-V and Azure.
> 
> Signed-off-by: Stephen Hemminger <sthemmin@microsoft.com>

Ping. What happened to this patch?

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [dpdk-dev] [PATCH] Revert "net/mlx: support IOVA VA mode"
  2019-06-07 23:08 [dpdk-dev] [PATCH] Revert "net/mlx: support IOVA VA mode" Stephen Hemminger
  2019-06-12 21:39 ` Stephen Hemminger
@ 2019-06-20 22:30 ` Stephen Hemminger
  2019-07-09 14:39 ` Stephen Hemminger
  2 siblings, 0 replies; 6+ messages in thread
From: Stephen Hemminger @ 2019-06-20 22:30 UTC (permalink / raw)
  To: Yongseok Koh; +Cc: dev

On Fri,  7 Jun 2019 16:08:41 -0700
Stephen Hemminger <stephen@networkplumber.org> wrote:

> From: Stephen Hemminger <sthemmin@microsoft.com>
> 
> This reverts commit 69c06d0e357ed0064b498d510d169603cf7308cd.
> That commit breaks support for netvsc PMD with MLX SRIOV
> on both Hyper-V and Azure.
> 
> Signed-off-by: Stephen Hemminger <sthemmin@microsoft.com>

Could one of the MLX maintainers review this. DPDK 19.08 is broken
right now on Hyper-V/Azure.

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [dpdk-dev] [PATCH] Revert "net/mlx: support IOVA VA mode"
  2019-06-07 23:08 [dpdk-dev] [PATCH] Revert "net/mlx: support IOVA VA mode" Stephen Hemminger
  2019-06-12 21:39 ` Stephen Hemminger
  2019-06-20 22:30 ` Stephen Hemminger
@ 2019-07-09 14:39 ` Stephen Hemminger
  2019-07-10 22:18   ` Thomas Monjalon
  2 siblings, 1 reply; 6+ messages in thread
From: Stephen Hemminger @ 2019-07-09 14:39 UTC (permalink / raw)
  To: dev; +Cc: Stephen Hemminger

On Fri,  7 Jun 2019 16:08:41 -0700
Stephen Hemminger <stephen@networkplumber.org> wrote:

> From: Stephen Hemminger <sthemmin@microsoft.com>
> 
> This reverts commit 69c06d0e357ed0064b498d510d169603cf7308cd.
> That commit breaks support for netvsc PMD with MLX SRIOV
> on both Hyper-V and Azure.
> 
> Signed-off-by: Stephen Hemminger <sthemmin@microsoft.com>

DPDK 19.08-rc is broken on Azure. This patch which seems to have been
ignored fixes it.

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [dpdk-dev] [PATCH] Revert "net/mlx: support IOVA VA mode"
  2019-07-09 14:39 ` Stephen Hemminger
@ 2019-07-10 22:18   ` Thomas Monjalon
  2019-07-22 15:55     ` Thomas Monjalon
  0 siblings, 1 reply; 6+ messages in thread
From: Thomas Monjalon @ 2019-07-10 22:18 UTC (permalink / raw)
  To: Stephen Hemminger; +Cc: dev, Stephen Hemminger

09/07/2019 16:39, Stephen Hemminger:
> On Fri,  7 Jun 2019 16:08:41 -0700
> Stephen Hemminger <stephen@networkplumber.org> wrote:
> 
> > From: Stephen Hemminger <sthemmin@microsoft.com>
> > 
> > This reverts commit 69c06d0e357ed0064b498d510d169603cf7308cd.
> > That commit breaks support for netvsc PMD with MLX SRIOV
> > on both Hyper-V and Azure.
> > 
> > Signed-off-by: Stephen Hemminger <sthemmin@microsoft.com>
> 
> DPDK 19.08-rc is broken on Azure. This patch which seems to have been
> ignored fixes it.

This patch was not ignored. I was waiting for the IOVA changes
to settle down. As a result, the revert will happen because the
type RTE_KDRV_NIC_MLX is not needed anymore:
	https://patches.dpdk.org/patch/56314/

However, I don't understand how it is related to netvsc PMD.
Please could you give more details?



^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [dpdk-dev] [PATCH] Revert "net/mlx: support IOVA VA mode"
  2019-07-10 22:18   ` Thomas Monjalon
@ 2019-07-22 15:55     ` Thomas Monjalon
  0 siblings, 0 replies; 6+ messages in thread
From: Thomas Monjalon @ 2019-07-22 15:55 UTC (permalink / raw)
  To: Stephen Hemminger; +Cc: dev, Stephen Hemminger

11/07/2019 00:18, Thomas Monjalon:
> 09/07/2019 16:39, Stephen Hemminger:
> > On Fri,  7 Jun 2019 16:08:41 -0700
> > Stephen Hemminger <stephen@networkplumber.org> wrote:
> > 
> > > From: Stephen Hemminger <sthemmin@microsoft.com>
> > > 
> > > This reverts commit 69c06d0e357ed0064b498d510d169603cf7308cd.
> > > That commit breaks support for netvsc PMD with MLX SRIOV
> > > on both Hyper-V and Azure.
> > > 
> > > Signed-off-by: Stephen Hemminger <sthemmin@microsoft.com>
> > 
> > DPDK 19.08-rc is broken on Azure. This patch which seems to have been
> > ignored fixes it.
> 
> This patch was not ignored. I was waiting for the IOVA changes
> to settle down. As a result, the revert will happen because the
> type RTE_KDRV_NIC_MLX is not needed anymore:
> 	https://patches.dpdk.org/patch/56314/

The revert is applied on master now.

> However, I don't understand how it is related to netvsc PMD.
> Please could you give more details?

Please did you investigate what happened?



^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, back to index

Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-06-07 23:08 [dpdk-dev] [PATCH] Revert "net/mlx: support IOVA VA mode" Stephen Hemminger
2019-06-12 21:39 ` Stephen Hemminger
2019-06-20 22:30 ` Stephen Hemminger
2019-07-09 14:39 ` Stephen Hemminger
2019-07-10 22:18   ` Thomas Monjalon
2019-07-22 15:55     ` Thomas Monjalon

DPDK-dev Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/dpdk-dev/0 dpdk-dev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 dpdk-dev dpdk-dev/ https://lore.kernel.org/dpdk-dev \
		dev@dpdk.org dpdk-dev@archiver.kernel.org
	public-inbox-index dpdk-dev


Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.dpdk.dev


AGPL code for this site: git clone https://public-inbox.org/ public-inbox