DPDK-dev Archive on lore.kernel.org
 help / color / Atom feed
* [dpdk-dev] [PATCH] crypto/qat: set message field to zero in sym SGL case
@ 2019-05-28 10:07 Gosia Bakota
  2019-05-28 10:41 ` Trahe, Fiona
                   ` (2 more replies)
  0 siblings, 3 replies; 6+ messages in thread
From: Gosia Bakota @ 2019-05-28 10:07 UTC (permalink / raw)
  To: dev; +Cc: akhil.goyal, fiona.trahe, gosia.bakota

Signed-off-by: Gosia Bakota <gosia.bakota@intel.com>
---
 drivers/crypto/qat/qat_sym.c |    2 ++
 1 files changed, 2 insertions(+), 0 deletions(-)
 mode change 100644 => 100755 drivers/crypto/qat/qat_sym.c

diff --git a/drivers/crypto/qat/qat_sym.c b/drivers/crypto/qat/qat_sym.c
old mode 100644
new mode 100755
index 8801ca5..7515a55
--- a/drivers/crypto/qat/qat_sym.c
+++ b/drivers/crypto/qat/qat_sym.c
@@ -530,6 +530,8 @@
 			qat_req->comn_mid.dest_data_addr =
 					cookie->qat_sgl_dst_phys_addr;
 		}
+		qat_req->comn_mid.src_length = 0;
+		qat_req->comn_mid.dst_length = 0;
 	} else {
 		qat_req->comn_mid.src_data_addr = src_buf_start;
 		qat_req->comn_mid.dest_data_addr = dst_buf_start;
-- 
1.7.0.7


^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [dpdk-dev] [PATCH] crypto/qat: set message field to zero in sym SGL case
  2019-05-28 10:07 [dpdk-dev] [PATCH] crypto/qat: set message field to zero in sym SGL case Gosia Bakota
@ 2019-05-28 10:41 ` Trahe, Fiona
  2019-06-12 14:41 ` [dpdk-dev] [PATCH v2] symmetric crypto, set-message-field-to-zero-in-SGL-case Gosia Bakota
  2019-06-12 17:31 ` [dpdk-dev] [PATCH v2] symmetric crypto, set message field to zero in SGL case Gosia Bakota
  2 siblings, 0 replies; 6+ messages in thread
From: Trahe, Fiona @ 2019-05-28 10:41 UTC (permalink / raw)
  To: Bakota, Gosia, dev; +Cc: akhil.goyal



> -----Original Message-----
> From: Bakota, Gosia
> Sent: Tuesday, May 28, 2019 11:07 AM
> To: dev@dpdk.org
> Cc: akhil.goyal@nxp.com; Trahe, Fiona <fiona.trahe@intel.com>; Bakota, Gosia <gosia.bakota@intel.com>
> Subject: [PATCH] crypto/qat: set message field to zero in sym SGL case
> 
> Signed-off-by: Gosia Bakota <gosia.bakota@intel.com>
Nack
Checkpatch issue - will send a v2

^ permalink raw reply	[flat|nested] 6+ messages in thread

* [dpdk-dev] [PATCH v2] symmetric crypto, set-message-field-to-zero-in-SGL-case
  2019-05-28 10:07 [dpdk-dev] [PATCH] crypto/qat: set message field to zero in sym SGL case Gosia Bakota
  2019-05-28 10:41 ` Trahe, Fiona
@ 2019-06-12 14:41 ` Gosia Bakota
  2019-06-12 17:31 ` [dpdk-dev] [PATCH v2] symmetric crypto, set message field to zero in SGL case Gosia Bakota
  2 siblings, 0 replies; 6+ messages in thread
From: Gosia Bakota @ 2019-06-12 14:41 UTC (permalink / raw)
  To: dev

Fixes: e09231eaa2af ("crypto/qat: add SGL capability")
Cc: Arek Kusztal <arkadiuszx.kusztal@intel.com>
Cc: stable@dpdk.org

Signed-off-by: Gosia Bakota <gosia.bakota@intel.com>
---
 drivers/crypto/qat/qat_sym.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/drivers/crypto/qat/qat_sym.c b/drivers/crypto/qat/qat_sym.c
index 8801ca567..7515a55d0 100644
--- a/drivers/crypto/qat/qat_sym.c
+++ b/drivers/crypto/qat/qat_sym.c
@@ -530,6 +530,8 @@ qat_sym_build_request(void *in_op, uint8_t *out_msg,
 			qat_req->comn_mid.dest_data_addr =
 					cookie->qat_sgl_dst_phys_addr;
 		}
+		qat_req->comn_mid.src_length = 0;
+		qat_req->comn_mid.dst_length = 0;
 	} else {
 		qat_req->comn_mid.src_data_addr = src_buf_start;
 		qat_req->comn_mid.dest_data_addr = dst_buf_start;
-- 
2.13.6


^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [dpdk-dev] [PATCH v2] symmetric crypto, set message field to zero in SGL case
  2019-06-12 17:31 ` [dpdk-dev] [PATCH v2] symmetric crypto, set message field to zero in SGL case Gosia Bakota
@ 2019-06-12 16:53   ` Trahe, Fiona
  2019-06-19 14:47     ` Akhil Goyal
  0 siblings, 1 reply; 6+ messages in thread
From: Trahe, Fiona @ 2019-06-12 16:53 UTC (permalink / raw)
  To: Bakota, Gosia, dev; +Cc: akhil.goyal, Trahe, Fiona



> -----Original Message-----
> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Gosia Bakota
> Sent: Wednesday, June 12, 2019 6:32 PM
> To: dev@dpdk.org
> Subject: [dpdk-dev] [PATCH v2] symmetric crypto, set message field to zero in SGL case
> 
> Fixes: e09231eaa2af ("crypto/qat: add SGL capability")
> Cc: Arek Kusztal <arkadiuszx.kusztal@intel.com>
> Cc: stable@dpdk.org
> 
> Signed-off-by: Gosia Bakota <gosia.bakota@intel.com>
Acked-by: Fiona Trahe <fiona.trahe@intel.com>

^ permalink raw reply	[flat|nested] 6+ messages in thread

* [dpdk-dev] [PATCH v2] symmetric crypto, set message field to zero in SGL case
  2019-05-28 10:07 [dpdk-dev] [PATCH] crypto/qat: set message field to zero in sym SGL case Gosia Bakota
  2019-05-28 10:41 ` Trahe, Fiona
  2019-06-12 14:41 ` [dpdk-dev] [PATCH v2] symmetric crypto, set-message-field-to-zero-in-SGL-case Gosia Bakota
@ 2019-06-12 17:31 ` Gosia Bakota
  2019-06-12 16:53   ` Trahe, Fiona
  2 siblings, 1 reply; 6+ messages in thread
From: Gosia Bakota @ 2019-06-12 17:31 UTC (permalink / raw)
  To: dev

Fixes: e09231eaa2af ("crypto/qat: add SGL capability")
Cc: Arek Kusztal <arkadiuszx.kusztal@intel.com>
Cc: stable@dpdk.org

Signed-off-by: Gosia Bakota <gosia.bakota@intel.com>
---
v2 changes
 -remove file mode change
 
 drivers/crypto/qat/qat_sym.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/drivers/crypto/qat/qat_sym.c b/drivers/crypto/qat/qat_sym.c
index 8801ca567..7515a55d0 100644
--- a/drivers/crypto/qat/qat_sym.c
+++ b/drivers/crypto/qat/qat_sym.c
@@ -530,6 +530,8 @@ qat_sym_build_request(void *in_op, uint8_t *out_msg,
 			qat_req->comn_mid.dest_data_addr =
 					cookie->qat_sgl_dst_phys_addr;
 		}
+		qat_req->comn_mid.src_length = 0;
+		qat_req->comn_mid.dst_length = 0;
 	} else {
 		qat_req->comn_mid.src_data_addr = src_buf_start;
 		qat_req->comn_mid.dest_data_addr = dst_buf_start;
-- 
2.13.6


^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [dpdk-dev] [PATCH v2] symmetric crypto, set message field to zero in SGL case
  2019-06-12 16:53   ` Trahe, Fiona
@ 2019-06-19 14:47     ` Akhil Goyal
  0 siblings, 0 replies; 6+ messages in thread
From: Akhil Goyal @ 2019-06-19 14:47 UTC (permalink / raw)
  To: Trahe, Fiona, Bakota, Gosia, dev

> > Fixes: e09231eaa2af ("crypto/qat: add SGL capability")
> > Cc: Arek Kusztal <arkadiuszx.kusztal@intel.com>
> > Cc: stable@dpdk.org
> >
> > Signed-off-by: Gosia Bakota <gosia.bakota@intel.com>
> Acked-by: Fiona Trahe <fiona.trahe@intel.com>

No need to add " Cc: Arek Kusztal <arkadiuszx.kusztal@intel.com>" in commit message.
Also changes the subject as that of your v1. Please take care of this in future.

Applied to dpdk-next-crypto

Thanks

^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, back to index

Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-05-28 10:07 [dpdk-dev] [PATCH] crypto/qat: set message field to zero in sym SGL case Gosia Bakota
2019-05-28 10:41 ` Trahe, Fiona
2019-06-12 14:41 ` [dpdk-dev] [PATCH v2] symmetric crypto, set-message-field-to-zero-in-SGL-case Gosia Bakota
2019-06-12 17:31 ` [dpdk-dev] [PATCH v2] symmetric crypto, set message field to zero in SGL case Gosia Bakota
2019-06-12 16:53   ` Trahe, Fiona
2019-06-19 14:47     ` Akhil Goyal

DPDK-dev Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/dpdk-dev/0 dpdk-dev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 dpdk-dev dpdk-dev/ https://lore.kernel.org/dpdk-dev \
		dev@dpdk.org dpdk-dev@archiver.kernel.org
	public-inbox-index dpdk-dev


Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.dpdk.dev


AGPL code for this site: git clone https://public-inbox.org/ public-inbox