From: Neil Horman <nhorman@tuxdriver.com> To: dev@dpdk.org Cc: Neil Horman <nhorman@tuxdriver.com>, Jerin Jacob Kollanukkaran <jerinj@marvell.com>, Bruce Richardson <bruce.richardson@intel.com>, Thomas Monjalon <thomas@monjalon.net>, Hemant Agrawal <hemant.agrawal@nxp.com>, Shreyansh Jain <shreyansh.jain@nxp.com> Subject: [dpdk-dev] [PATCH v1 5/9] dpaa2: Adjust dpaa2 driver to mark internal symbols with __rte_internal Date: Wed, 12 Jun 2019 16:38:59 -0400 Message-ID: <20190612203903.16565-6-nhorman@tuxdriver.com> (raw) In-Reply-To: <20190612203903.16565-1-nhorman@tuxdriver.com> Identify functions in the dpaa2 driver which are internal (based on their not having an rte_ prefix) and tag them with __rte_internal Signed-off-by: Neil Horman <nhorman@tuxdriver.com> CC: Jerin Jacob Kollanukkaran <jerinj@marvell.com> CC: Bruce Richardson <bruce.richardson@intel.com> CC: Thomas Monjalon <thomas@monjalon.net> CC: Hemant Agrawal <hemant.agrawal@nxp.com> CC: Shreyansh Jain <shreyansh.jain@nxp.com> --- drivers/net/dpaa2/dpaa2_ethdev.c | 4 ++-- drivers/net/dpaa2/dpaa2_ethdev.h | 4 ++-- drivers/net/dpaa2/rte_pmd_dpaa2_version.map | 14 ++++++-------- 3 files changed, 10 insertions(+), 12 deletions(-) diff --git a/drivers/net/dpaa2/dpaa2_ethdev.c b/drivers/net/dpaa2/dpaa2_ethdev.c index 900182f66..fafdec1f9 100644 --- a/drivers/net/dpaa2/dpaa2_ethdev.c +++ b/drivers/net/dpaa2/dpaa2_ethdev.c @@ -1798,7 +1798,7 @@ dpaa2_dev_rss_hash_conf_get(struct rte_eth_dev *dev, return 0; } -int dpaa2_eth_eventq_attach(const struct rte_eth_dev *dev, +int __rte_internal dpaa2_eth_eventq_attach(const struct rte_eth_dev *dev, int eth_rx_queue_id, uint16_t dpcon_id, const struct rte_event_eth_rx_adapter_queue_conf *queue_conf) @@ -1881,7 +1881,7 @@ int dpaa2_eth_eventq_attach(const struct rte_eth_dev *dev, return 0; } -int dpaa2_eth_eventq_detach(const struct rte_eth_dev *dev, +int __rte_internal dpaa2_eth_eventq_detach(const struct rte_eth_dev *dev, int eth_rx_queue_id) { struct dpaa2_dev_priv *eth_priv = dev->data->dev_private; diff --git a/drivers/net/dpaa2/dpaa2_ethdev.h b/drivers/net/dpaa2/dpaa2_ethdev.h index 33b1506aa..b7d691238 100644 --- a/drivers/net/dpaa2/dpaa2_ethdev.h +++ b/drivers/net/dpaa2/dpaa2_ethdev.h @@ -140,12 +140,12 @@ int dpaa2_remove_flow_dist(struct rte_eth_dev *eth_dev, int dpaa2_attach_bp_list(struct dpaa2_dev_priv *priv, void *blist); -int dpaa2_eth_eventq_attach(const struct rte_eth_dev *dev, +int __rte_internal dpaa2_eth_eventq_attach(const struct rte_eth_dev *dev, int eth_rx_queue_id, uint16_t dpcon_id, const struct rte_event_eth_rx_adapter_queue_conf *queue_conf); -int dpaa2_eth_eventq_detach(const struct rte_eth_dev *dev, +int __rte_internal dpaa2_eth_eventq_detach(const struct rte_eth_dev *dev, int eth_rx_queue_id); uint16_t dpaa2_dev_loopback_rx(void *queue, struct rte_mbuf **bufs, diff --git a/drivers/net/dpaa2/rte_pmd_dpaa2_version.map b/drivers/net/dpaa2/rte_pmd_dpaa2_version.map index d1b4cdb23..fcf0b8ac0 100644 --- a/drivers/net/dpaa2/rte_pmd_dpaa2_version.map +++ b/drivers/net/dpaa2/rte_pmd_dpaa2_version.map @@ -1,15 +1,13 @@ -DPDK_17.05 { - - local: *; -}; - -DPDK_17.11 { +INTERNAL { global: dpaa2_eth_eventq_attach; dpaa2_eth_eventq_detach; +}; -} DPDK_17.05; +DPDK_17.05 { + local: *; +}; EXPERIMENTAL { global: @@ -17,4 +15,4 @@ EXPERIMENTAL { rte_pmd_dpaa2_mux_flow_create; rte_pmd_dpaa2_set_custom_hash; rte_pmd_dpaa2_set_timestamp; -} DPDK_17.11; +} DPDK_17.05; -- 2.20.1
next prev parent reply index Thread overview: 104+ messages / expand[flat|nested] mbox.gz Atom feed top 2019-05-25 18:43 [dpdk-dev] [RFC PATCH 0/2] introduce __rte_internal tag Neil Horman 2019-05-25 18:43 ` [dpdk-dev] [RFC PATCH 1/2] Add __rte_internal tag for functions and version target Neil Horman 2019-06-05 16:14 ` [dpdk-dev] [EXT] " Jerin Jacob Kollanukkaran 2019-05-25 18:43 ` [dpdk-dev] [RFC PATCH 2/2] Convert dpaa driver to tag internal-only symbols appropriately Neil Horman 2019-06-05 16:24 ` [dpdk-dev] [EXT] [RFC PATCH 0/2] introduce __rte_internal tag Jerin Jacob Kollanukkaran 2019-06-05 16:45 ` Bruce Richardson 2019-06-05 18:11 ` Neil Horman 2019-06-06 9:44 ` Jerin Jacob Kollanukkaran 2019-06-06 11:34 ` Neil Horman 2019-06-06 12:04 ` Jerin Jacob Kollanukkaran 2019-06-06 13:18 ` Wiles, Keith 2019-06-06 13:43 ` Neil Horman 2019-06-06 13:53 ` Wiles, Keith 2019-06-06 14:46 ` Neil Horman 2019-06-06 13:35 ` Neil Horman 2019-06-06 14:02 ` Jerin Jacob Kollanukkaran 2019-06-06 15:03 ` Neil Horman 2019-06-06 15:14 ` Jerin Jacob Kollanukkaran 2019-06-06 15:26 ` Neil Horman 2019-06-06 16:23 ` Jerin Jacob Kollanukkaran 2019-06-06 16:55 ` Neil Horman 2019-06-07 9:41 ` Jerin Jacob Kollanukkaran 2019-06-07 10:35 ` Neil Horman 2019-06-07 15:42 ` Ray Kinsella 2019-06-07 18:21 ` Wiles, Keith 2020-01-09 15:49 ` Neil Horman 2019-06-12 20:38 ` [dpdk-dev] [PATCH v1 0/9] dpdk: " Neil Horman 2019-06-12 20:38 ` [dpdk-dev] [PATCH v1 1/9] Add __rte_internal tag for functions and version target Neil Horman 2019-06-12 20:38 ` [dpdk-dev] [PATCH v1 2/9] Exempt INTERNAL symbols from checking Neil Horman 2019-06-12 20:38 ` [dpdk-dev] [PATCH v1 3/9] mark dpaa driver internal-only symbols with __rte_internal Neil Horman 2019-06-12 20:38 ` [dpdk-dev] [PATCH v1 4/9] fslmc: identify internal only functions and tag them as __rte_internal Neil Horman 2019-06-12 20:38 ` Neil Horman [this message] 2019-06-12 20:39 ` [dpdk-dev] [PATCH v1 6/9] dpaax: mark internal functions with __rte_internal Neil Horman 2019-06-12 20:39 ` [dpdk-dev] [PATCH v1 7/9] cpt: " Neil Horman 2019-06-17 5:27 ` [dpdk-dev] [EXT] " Anoob Joseph 2019-06-12 20:39 ` [dpdk-dev] [PATCH v1 8/9] octeonx: " Neil Horman 2019-06-12 20:39 ` [dpdk-dev] [PATCH v1 9/9] dpaa2: " Neil Horman 2019-06-12 21:14 ` Aaron Conole 2019-06-13 10:24 ` Neil Horman 2019-06-13 7:53 ` [dpdk-dev] [PATCH v1 0/9] dpdk: introduce __rte_internal tag David Marchand 2019-06-13 10:30 ` Neil Horman 2019-06-13 14:23 ` [dpdk-dev] [PATCH v2 0/10] " Neil Horman 2019-06-13 14:23 ` [dpdk-dev] [PATCH v2 01/10] Add __rte_internal tag for functions and version target Neil Horman 2020-04-17 2:04 ` Wang, Haiyue 2020-04-17 2:38 ` Neil Horman 2020-04-17 4:40 ` Wang, Haiyue 2019-06-13 14:23 ` [dpdk-dev] [PATCH v2 02/10] meson: add BUILDING_RTE_SDK Neil Horman 2019-06-13 14:44 ` Bruce Richardson 2019-06-19 10:39 ` Neil Horman 2019-06-19 10:46 ` Bruce Richardson 2019-06-19 18:34 ` Neil Horman 2019-06-20 10:20 ` Bruce Richardson 2019-06-20 10:21 ` Bruce Richardson 2019-06-13 14:23 ` [dpdk-dev] [PATCH v2 03/10] Exempt INTERNAL symbols from checking Neil Horman 2019-06-13 14:23 ` [dpdk-dev] [PATCH v2 04/10] mark dpaa driver internal-only symbols with __rte_internal Neil Horman 2019-06-13 14:23 ` [dpdk-dev] [PATCH v2 05/10] fslmc: identify internal only functions and tag them as __rte_internal Neil Horman 2019-06-17 7:30 ` Hemant Agrawal 2019-06-19 10:45 ` Neil Horman 2020-04-02 9:49 ` Hemant Agrawal 2020-04-02 11:30 ` Neil Horman 2020-04-02 15:44 ` Hemant Agrawal 2019-06-13 14:23 ` [dpdk-dev] [PATCH v2 06/10] dpaa2: Adjust dpaa2 driver to mark internal symbols with __rte_internal Neil Horman 2019-06-13 14:23 ` [dpdk-dev] [PATCH v2 07/10] dpaax: mark internal functions " Neil Horman 2019-06-13 14:23 ` [dpdk-dev] [PATCH v2 08/10] cpt: " Neil Horman 2019-06-13 14:23 ` [dpdk-dev] [PATCH v2 09/10] octeonx: " Neil Horman 2019-06-13 14:23 ` [dpdk-dev] [PATCH v2 10/10] dpaa2: " Neil Horman 2019-08-06 10:03 ` [dpdk-dev] [PATCH v2 0/10] dpdk: introduce __rte_internal tag Thomas Monjalon 2019-08-06 12:21 ` Neil Horman 2020-01-09 9:55 ` David Marchand 2020-01-09 11:46 ` Neil Horman 2020-01-09 11:53 ` David Marchand 2020-04-22 13:52 ` [dpdk-dev] [PATCH v3 0/1] " Haiyue Wang 2020-04-22 13:52 ` [dpdk-dev] [PATCH v3 1/1] eal: add internal ABI mark support Haiyue Wang 2020-04-22 14:13 ` David Marchand 2020-04-22 16:44 ` Wang, Haiyue 2020-04-22 16:37 ` [dpdk-dev] [PATCH v4 0/1] dpdk: introduce __rte_internal tag Haiyue Wang 2020-04-22 16:37 ` [dpdk-dev] [PATCH v4 1/1] eal: add internal ABI mark support Haiyue Wang 2020-04-23 3:19 ` [dpdk-dev] [PATCH v5 0/1] dpdk: introduce __rte_internal tag Haiyue Wang 2020-04-23 3:19 ` [dpdk-dev] [PATCH v5 1/1] eal: add internal ABI marking support Haiyue Wang 2020-04-24 14:52 ` David Marchand 2020-04-25 6:10 ` Wang, Haiyue 2020-04-25 14:21 ` David Marchand 2020-04-25 14:24 ` Thomas Monjalon 2020-04-25 6:04 ` [dpdk-dev] [PATCH v6 0/6] dpdk: introduce __rte_internal tag Haiyue Wang 2020-04-25 6:04 ` [dpdk-dev] [PATCH v6 1/6] eal: add internal ABI tag definition Haiyue Wang 2020-04-25 6:04 ` [dpdk-dev] [PATCH v6 2/6] build: enable internal API tag Haiyue Wang 2020-04-25 6:04 ` [dpdk-dev] [PATCH v6 3/6] mk: add internal tag check Haiyue Wang 2020-04-25 6:04 ` [dpdk-dev] [PATCH v6 4/6] devtools: ignore internal ABI check Haiyue Wang 2020-04-25 6:04 ` [dpdk-dev] [PATCH v6 5/6] devtools: exempt internal ABI checking Haiyue Wang 2020-04-25 6:04 ` [dpdk-dev] [PATCH v6 6/6] devtools: enforce internal tag at the beginning Haiyue Wang 2020-04-25 10:56 ` [dpdk-dev] [PATCH v7 0/6] dpdk: introduce __rte_internal tag Haiyue Wang 2020-04-25 10:56 ` [dpdk-dev] [PATCH v7 1/6] eal: add internal ABI tag definition Haiyue Wang 2020-04-25 10:56 ` [dpdk-dev] [PATCH v7 2/6] build: enable internal API tag Haiyue Wang 2020-04-25 10:56 ` [dpdk-dev] [PATCH v7 3/6] mk: add internal tag check Haiyue Wang 2020-04-25 14:34 ` David Marchand 2020-04-25 10:56 ` [dpdk-dev] [PATCH v7 4/6] devtools: ignore internal ABI check Haiyue Wang 2020-04-25 10:56 ` [dpdk-dev] [PATCH v7 5/6] devtools: exempt internal ABI checking Haiyue Wang 2020-04-25 14:34 ` David Marchand 2020-04-25 10:56 ` [dpdk-dev] [PATCH v7 6/6] devtools: enforce internal tag at the beginning Haiyue Wang 2020-04-25 14:39 ` [dpdk-dev] [PATCH v7 0/6] dpdk: introduce __rte_internal tag David Marchand 2020-04-25 16:34 ` Wang, Haiyue 2020-04-25 18:09 ` Wang, Haiyue 2020-04-29 8:22 ` David Marchand 2020-04-29 8:24 ` Wang, Haiyue
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20190612203903.16565-6-nhorman@tuxdriver.com \ --to=nhorman@tuxdriver.com \ --cc=bruce.richardson@intel.com \ --cc=dev@dpdk.org \ --cc=hemant.agrawal@nxp.com \ --cc=jerinj@marvell.com \ --cc=shreyansh.jain@nxp.com \ --cc=thomas@monjalon.net \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
DPDK-dev Archive on lore.kernel.org Archives are clonable: git clone --mirror https://lore.kernel.org/dpdk-dev/0 dpdk-dev/git/0.git # If you have public-inbox 1.1+ installed, you may # initialize and index your mirror using the following commands: public-inbox-init -V2 dpdk-dev dpdk-dev/ https://lore.kernel.org/dpdk-dev \ dev@dpdk.org public-inbox-index dpdk-dev Example config snippet for mirrors Newsgroup available over NNTP: nntp://nntp.lore.kernel.org/org.dpdk.dev AGPL code for this site: git clone https://public-inbox.org/public-inbox.git