DPDK-dev Archive on lore.kernel.org
 help / color / Atom feed
* [dpdk-dev] [PATCH] examples/vdpa: remove trace of legacy "linuxapp"
@ 2019-06-17  7:54 David Marchand
  2019-06-17  8:51 ` Tiwei Bie
                   ` (2 more replies)
  0 siblings, 3 replies; 4+ messages in thread
From: David Marchand @ 2019-06-17  7:54 UTC (permalink / raw)
  To: dev; +Cc: stable, Maxime Coquelin, Tiwei Bie, Zhihong Wang

This check on Linux environment has been added at a time when we already
had switched to using the boolean RTE_EXEC_ENV_LINUXAPP.
It was then missed when converting to RTE_EXEC_ENV_LINUX.

Fixes: edbed86d1cc3 ("examples/vdpa: introduce a new sample for vDPA")
Fixes: 742bde12f3bd ("build/linux: rename macro from LINUXAPP to LINUX")
Cc: stable@dpdk.org

Signed-off-by: David Marchand <david.marchand@redhat.com>
---
If we backport this to 18.11, the fix is to switch to
RTE_EXEC_ENV_LINUXAPP.

---
 examples/vdpa/Makefile | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/examples/vdpa/Makefile b/examples/vdpa/Makefile
index 9d16d8e..ab2bbdf 100644
--- a/examples/vdpa/Makefile
+++ b/examples/vdpa/Makefile
@@ -10,7 +10,7 @@ RTE_TARGET ?= $(notdir $(abspath $(dir $(firstword $(wildcard $(RTE_SDK)/*/.conf
 
 include $(RTE_SDK)/mk/rte.vars.mk
 
-ifneq ($(CONFIG_RTE_EXEC_ENV),"linuxapp")
+ifneq ($(CONFIG_RTE_EXEC_ENV_LINUX),y)
 $(info This application can only operate in a linux environment, \
 please change the definition of the RTE_TARGET environment variable)
 all:
-- 
1.8.3.1


^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [dpdk-dev] [PATCH] examples/vdpa: remove trace of legacy "linuxapp"
  2019-06-17  7:54 [dpdk-dev] [PATCH] examples/vdpa: remove trace of legacy "linuxapp" David Marchand
@ 2019-06-17  8:51 ` Tiwei Bie
  2019-06-17 15:40 ` Ye Xiaolong
  2019-06-20  9:58 ` Maxime Coquelin
  2 siblings, 0 replies; 4+ messages in thread
From: Tiwei Bie @ 2019-06-17  8:51 UTC (permalink / raw)
  To: David Marchand; +Cc: dev, stable, Maxime Coquelin, Zhihong Wang

On Mon, Jun 17, 2019 at 09:54:42AM +0200, David Marchand wrote:
> This check on Linux environment has been added at a time when we already
> had switched to using the boolean RTE_EXEC_ENV_LINUXAPP.
> It was then missed when converting to RTE_EXEC_ENV_LINUX.
> 
> Fixes: edbed86d1cc3 ("examples/vdpa: introduce a new sample for vDPA")
> Fixes: 742bde12f3bd ("build/linux: rename macro from LINUXAPP to LINUX")
> Cc: stable@dpdk.org
> 
> Signed-off-by: David Marchand <david.marchand@redhat.com>
> ---

Reviewed-by: Tiwei Bie <tiwei.bie@intel.com>

Thanks,
Tiwei

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [dpdk-dev] [PATCH] examples/vdpa: remove trace of legacy "linuxapp"
  2019-06-17  7:54 [dpdk-dev] [PATCH] examples/vdpa: remove trace of legacy "linuxapp" David Marchand
  2019-06-17  8:51 ` Tiwei Bie
@ 2019-06-17 15:40 ` Ye Xiaolong
  2019-06-20  9:58 ` Maxime Coquelin
  2 siblings, 0 replies; 4+ messages in thread
From: Ye Xiaolong @ 2019-06-17 15:40 UTC (permalink / raw)
  To: David Marchand; +Cc: dev, stable, Maxime Coquelin, Tiwei Bie, Zhihong Wang

On 06/17, David Marchand wrote:
>This check on Linux environment has been added at a time when we already
>had switched to using the boolean RTE_EXEC_ENV_LINUXAPP.
>It was then missed when converting to RTE_EXEC_ENV_LINUX.
>
>Fixes: edbed86d1cc3 ("examples/vdpa: introduce a new sample for vDPA")
>Fixes: 742bde12f3bd ("build/linux: rename macro from LINUXAPP to LINUX")
>Cc: stable@dpdk.org
>
>Signed-off-by: David Marchand <david.marchand@redhat.com>
>---
>If we backport this to 18.11, the fix is to switch to
>RTE_EXEC_ENV_LINUXAPP.
>
>---
> examples/vdpa/Makefile | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/examples/vdpa/Makefile b/examples/vdpa/Makefile
>index 9d16d8e..ab2bbdf 100644
>--- a/examples/vdpa/Makefile
>+++ b/examples/vdpa/Makefile
>@@ -10,7 +10,7 @@ RTE_TARGET ?= $(notdir $(abspath $(dir $(firstword $(wildcard $(RTE_SDK)/*/.conf
> 
> include $(RTE_SDK)/mk/rte.vars.mk
> 
>-ifneq ($(CONFIG_RTE_EXEC_ENV),"linuxapp")
>+ifneq ($(CONFIG_RTE_EXEC_ENV_LINUX),y)
> $(info This application can only operate in a linux environment, \
> please change the definition of the RTE_TARGET environment variable)
> all:
>-- 
>1.8.3.1
>

Reviewed-by: Xiaolong Ye <xiaolong.ye@intel.com>

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [dpdk-dev] [PATCH] examples/vdpa: remove trace of legacy "linuxapp"
  2019-06-17  7:54 [dpdk-dev] [PATCH] examples/vdpa: remove trace of legacy "linuxapp" David Marchand
  2019-06-17  8:51 ` Tiwei Bie
  2019-06-17 15:40 ` Ye Xiaolong
@ 2019-06-20  9:58 ` Maxime Coquelin
  2 siblings, 0 replies; 4+ messages in thread
From: Maxime Coquelin @ 2019-06-20  9:58 UTC (permalink / raw)
  To: David Marchand, dev; +Cc: stable, Tiwei Bie, Zhihong Wang



On 6/17/19 9:54 AM, David Marchand wrote:
> This check on Linux environment has been added at a time when we already
> had switched to using the boolean RTE_EXEC_ENV_LINUXAPP.
> It was then missed when converting to RTE_EXEC_ENV_LINUX.
> 
> Fixes: edbed86d1cc3 ("examples/vdpa: introduce a new sample for vDPA")
> Fixes: 742bde12f3bd ("build/linux: rename macro from LINUXAPP to LINUX")
> Cc: stable@dpdk.org
> 
> Signed-off-by: David Marchand <david.marchand@redhat.com>
> ---
> If we backport this to 18.11, the fix is to switch to
> RTE_EXEC_ENV_LINUXAPP.
> 
> ---
>   examples/vdpa/Makefile | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 

Applied to dpdk-next-virtio/master.

Thanks,
Maxime

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, back to index

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-06-17  7:54 [dpdk-dev] [PATCH] examples/vdpa: remove trace of legacy "linuxapp" David Marchand
2019-06-17  8:51 ` Tiwei Bie
2019-06-17 15:40 ` Ye Xiaolong
2019-06-20  9:58 ` Maxime Coquelin

DPDK-dev Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/dpdk-dev/0 dpdk-dev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 dpdk-dev dpdk-dev/ https://lore.kernel.org/dpdk-dev \
		dev@dpdk.org dpdk-dev@archiver.kernel.org
	public-inbox-index dpdk-dev


Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.dpdk.dev


AGPL code for this site: git clone https://public-inbox.org/ public-inbox