From: Neil Horman <nhorman@tuxdriver.com> To: Jerin Jacob Kollanukkaran <jerinj@marvell.com> Cc: "dev@dpdk.org" <dev@dpdk.org>, Bruce Richardson <bruce.richardson@intel.com>, Thomas Monjalon <thomas@monjalon.net> Subject: Re: [dpdk-dev] [PATCH v2 09/10] octeonx: mark internal functions with __rte_internal Date: Mon, 17 Jun 2019 15:13:41 -0400 [thread overview] Message-ID: <20190617191341.GC14238@hmswarspite.think-freely.org> (raw) In-Reply-To: <BYAPR18MB24240F780B39BED641DD0354C8EB0@BYAPR18MB2424.namprd18.prod.outlook.com> On Mon, Jun 17, 2019 at 04:09:26PM +0000, Jerin Jacob Kollanukkaran wrote: > > -----Original Message----- > > From: Neil Horman <nhorman@tuxdriver.com> > > Sent: Thursday, June 13, 2019 7:54 PM > > To: dev@dpdk.org > > Cc: Neil Horman <nhorman@tuxdriver.com>; Jerin Jacob Kollanukkaran > > <jerinj@marvell.com>; Bruce Richardson <bruce.richardson@intel.com>; > > Thomas Monjalon <thomas@monjalon.net> > > Subject: [EXT] [PATCH v2 09/10] octeonx: mark internal functions with > > __rte_internal > > > > + > > +DPDK_18.05 { > > + global: > > + octeontx_logtype_mbox; > > It should move to INTERNAL. Right? > So, thats an interesting symbol that we should probably discuss more. octeontx_logtype_mbox is actually a global int variable, not a function, and __rte_internal only works on the latter type of symbol (i.e. the __attribute__(error(...)) tag only applies to functions. I could create an __rte_internal_data data, that can do something simmilar for global variables, but it occured to me that perhaps global variables should not be a method of communication between internal libraries like this (opting instead for getter and setter methods to protect it, and then exempting those functions with __rte_internal). I believe David mentioned something along these lines as well previously, but I didn't want to go making changes like that without a more focused discussion, so I opted to leave global variables in place for now. Thoughts on how to address this case? Neil > > + > > + local: *; > > +}; > > -- > > 2.20.1 > >
next prev parent reply other threads:[~2019-06-17 19:14 UTC|newest] Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top 2019-06-17 16:09 Jerin Jacob Kollanukkaran 2019-06-17 19:13 ` Neil Horman [this message] 2019-07-05 7:49 ` [dpdk-dev] [EXT] " Jerin Jacob Kollanukkaran -- strict thread matches above, loose matches on Subject: below -- 2019-05-25 18:43 [dpdk-dev] [RFC PATCH 0/2] introduce __rte_internal tag Neil Horman 2019-06-13 14:23 ` [dpdk-dev] [PATCH v2 0/10] dpdk: " Neil Horman 2019-06-13 14:23 ` [dpdk-dev] [PATCH v2 09/10] octeonx: mark internal functions with __rte_internal Neil Horman
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20190617191341.GC14238@hmswarspite.think-freely.org \ --to=nhorman@tuxdriver.com \ --cc=bruce.richardson@intel.com \ --cc=dev@dpdk.org \ --cc=jerinj@marvell.com \ --cc=thomas@monjalon.net \ --subject='Re: [dpdk-dev] [PATCH v2 09/10] octeonx: mark internal functions with __rte_internal' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).