From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.5 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,URIBL_SBL,URIBL_SBL_A, USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2FF30C31E5B for ; Mon, 17 Jun 2019 19:14:00 +0000 (UTC) Received: from dpdk.org (dpdk.org [92.243.14.124]) by mail.kernel.org (Postfix) with ESMTP id 0323B208C0 for ; Mon, 17 Jun 2019 19:13:58 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 0323B208C0 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=tuxdriver.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=dev-bounces@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 00B231BFB8; Mon, 17 Jun 2019 21:13:58 +0200 (CEST) Received: from smtp.tuxdriver.com (charlotte.tuxdriver.com [70.61.120.58]) by dpdk.org (Postfix) with ESMTP id 8CF3E1BFB0 for ; Mon, 17 Jun 2019 21:13:56 +0200 (CEST) Received: from [107.15.85.130] (helo=localhost) by smtp.tuxdriver.com with esmtpsa (TLSv1:AES256-SHA:256) (Exim 4.63) (envelope-from ) id 1hcx4c-0004yJ-Un; Mon, 17 Jun 2019 15:13:52 -0400 Date: Mon, 17 Jun 2019 15:13:41 -0400 From: Neil Horman To: Jerin Jacob Kollanukkaran Cc: "dev@dpdk.org" , Bruce Richardson , Thomas Monjalon Message-ID: <20190617191341.GC14238@hmswarspite.think-freely.org> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.11.3 (2019-02-01) Subject: Re: [dpdk-dev] [PATCH v2 09/10] octeonx: mark internal functions with __rte_internal X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Mon, Jun 17, 2019 at 04:09:26PM +0000, Jerin Jacob Kollanukkaran wrote: > > -----Original Message----- > > From: Neil Horman > > Sent: Thursday, June 13, 2019 7:54 PM > > To: dev@dpdk.org > > Cc: Neil Horman ; Jerin Jacob Kollanukkaran > > ; Bruce Richardson ; > > Thomas Monjalon > > Subject: [EXT] [PATCH v2 09/10] octeonx: mark internal functions with > > __rte_internal > > > > + > > +DPDK_18.05 { > > + global: > > + octeontx_logtype_mbox; > > It should move to INTERNAL. Right? > So, thats an interesting symbol that we should probably discuss more. octeontx_logtype_mbox is actually a global int variable, not a function, and __rte_internal only works on the latter type of symbol (i.e. the __attribute__(error(...)) tag only applies to functions. I could create an __rte_internal_data data, that can do something simmilar for global variables, but it occured to me that perhaps global variables should not be a method of communication between internal libraries like this (opting instead for getter and setter methods to protect it, and then exempting those functions with __rte_internal). I believe David mentioned something along these lines as well previously, but I didn't want to go making changes like that without a more focused discussion, so I opted to leave global variables in place for now. Thoughts on how to address this case? Neil > > + > > + local: *; > > +}; > > -- > > 2.20.1 > >