DPDK-dev Archive on lore.kernel.org
 help / color / Atom feed
* [dpdk-dev] [PATCH] examples/flow_filtering: remove out-of-date comment
@ 2019-06-18 13:45 Xiaolong Ye
  2019-06-23  5:22 ` Ori Kam
  0 siblings, 1 reply; 3+ messages in thread
From: Xiaolong Ye @ 2019-06-18 13:45 UTC (permalink / raw)
  To: Ferruh Yigit, Marko Kovacevic, Ori Kam, Bruce Richardson,
	Pablo de Lara, Radu Nicolau, Akhil Goyal, Tomasz Kantecki
  Cc: dev, Xiaolong Ye

Now we've setup both rx and tx queues.

Signed-off-by: Xiaolong Ye <xiaolong.ye@intel.com>
---
 examples/flow_filtering/main.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/examples/flow_filtering/main.c b/examples/flow_filtering/main.c
index 09dbbcea9..a0487be77 100644
--- a/examples/flow_filtering/main.c
+++ b/examples/flow_filtering/main.c
@@ -149,7 +149,6 @@ init_port(void)
 
 	rxq_conf = dev_info.default_rxconf;
 	rxq_conf.offloads = port_conf.rxmode.offloads;
-	/* only set Rx queues: something we care only so far */
 	for (i = 0; i < nr_queues; i++) {
 		ret = rte_eth_rx_queue_setup(port_id, i, 512,
 				     rte_eth_dev_socket_id(port_id),
-- 
2.17.1


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [dpdk-dev] [PATCH] examples/flow_filtering: remove out-of-date comment
  2019-06-18 13:45 [dpdk-dev] [PATCH] examples/flow_filtering: remove out-of-date comment Xiaolong Ye
@ 2019-06-23  5:22 ` Ori Kam
  2019-06-28 19:03   ` Ferruh Yigit
  0 siblings, 1 reply; 3+ messages in thread
From: Ori Kam @ 2019-06-23  5:22 UTC (permalink / raw)
  To: Xiaolong Ye, Ferruh Yigit, Marko Kovacevic, Bruce Richardson,
	Pablo de Lara, Radu Nicolau, Akhil Goyal, Tomasz Kantecki
  Cc: dev



> -----Original Message-----
> From: Xiaolong Ye <xiaolong.ye@intel.com>
> Sent: Tuesday, June 18, 2019 4:46 PM
> To: Ferruh Yigit <ferruh.yigit@intel.com>; Marko Kovacevic
> <marko.kovacevic@intel.com>; Ori Kam <orika@mellanox.com>; Bruce
> Richardson <bruce.richardson@intel.com>; Pablo de Lara
> <pablo.de.lara.guarch@intel.com>; Radu Nicolau <radu.nicolau@intel.com>;
> Akhil Goyal <akhil.goyal@nxp.com>; Tomasz Kantecki
> <tomasz.kantecki@intel.com>
> Cc: dev@dpdk.org; Xiaolong Ye <xiaolong.ye@intel.com>
> Subject: [PATCH] examples/flow_filtering: remove out-of-date comment
> 
> Now we've setup both rx and tx queues.
> 
> Signed-off-by: Xiaolong Ye <xiaolong.ye@intel.com>
> ---
>  examples/flow_filtering/main.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/examples/flow_filtering/main.c b/examples/flow_filtering/main.c
> index 09dbbcea9..a0487be77 100644
> --- a/examples/flow_filtering/main.c
> +++ b/examples/flow_filtering/main.c
> @@ -149,7 +149,6 @@ init_port(void)
> 
>  	rxq_conf = dev_info.default_rxconf;
>  	rxq_conf.offloads = port_conf.rxmode.offloads;
> -	/* only set Rx queues: something we care only so far */
>  	for (i = 0; i < nr_queues; i++) {
>  		ret = rte_eth_rx_queue_setup(port_id, i, 512,
>  				     rte_eth_dev_socket_id(port_id),
> --
> 2.17.1

Acked-by: Ori Kam <orika@mellanox.com>
Thanks,
Ori Kam


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [dpdk-dev] [PATCH] examples/flow_filtering: remove out-of-date comment
  2019-06-23  5:22 ` Ori Kam
@ 2019-06-28 19:03   ` Ferruh Yigit
  0 siblings, 0 replies; 3+ messages in thread
From: Ferruh Yigit @ 2019-06-28 19:03 UTC (permalink / raw)
  To: Ori Kam, Xiaolong Ye, Marko Kovacevic, Bruce Richardson,
	Pablo de Lara, Radu Nicolau, Akhil Goyal, Tomasz Kantecki
  Cc: dev

On 6/23/2019 6:22 AM, Ori Kam wrote:
> 
> 
>> -----Original Message-----
>> From: Xiaolong Ye <xiaolong.ye@intel.com>
>> Sent: Tuesday, June 18, 2019 4:46 PM
>> To: Ferruh Yigit <ferruh.yigit@intel.com>; Marko Kovacevic
>> <marko.kovacevic@intel.com>; Ori Kam <orika@mellanox.com>; Bruce
>> Richardson <bruce.richardson@intel.com>; Pablo de Lara
>> <pablo.de.lara.guarch@intel.com>; Radu Nicolau <radu.nicolau@intel.com>;
>> Akhil Goyal <akhil.goyal@nxp.com>; Tomasz Kantecki
>> <tomasz.kantecki@intel.com>
>> Cc: dev@dpdk.org; Xiaolong Ye <xiaolong.ye@intel.com>
>> Subject: [PATCH] examples/flow_filtering: remove out-of-date comment
>>
>> Now we've setup both rx and tx queues.
>>
>> Signed-off-by: Xiaolong Ye <xiaolong.ye@intel.com>
> 
> Acked-by: Ori Kam <orika@mellanox.com>

Applied to dpdk-next-net/master, thanks.

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, back to index

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-06-18 13:45 [dpdk-dev] [PATCH] examples/flow_filtering: remove out-of-date comment Xiaolong Ye
2019-06-23  5:22 ` Ori Kam
2019-06-28 19:03   ` Ferruh Yigit

DPDK-dev Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/dpdk-dev/0 dpdk-dev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 dpdk-dev dpdk-dev/ https://lore.kernel.org/dpdk-dev \
		dev@dpdk.org dpdk-dev@archiver.kernel.org
	public-inbox-index dpdk-dev


Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.dpdk.dev


AGPL code for this site: git clone https://public-inbox.org/ public-inbox