From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.6 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 377ADC31E5B for ; Tue, 18 Jun 2019 16:17:34 +0000 (UTC) Received: from dpdk.org (dpdk.org [92.243.14.124]) by mail.kernel.org (Postfix) with ESMTP id BD05B213F2 for ; Tue, 18 Jun 2019 16:17:33 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=networkplumber-org.20150623.gappssmtp.com header.i=@networkplumber-org.20150623.gappssmtp.com header.b="1LsYBKOn" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org BD05B213F2 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=networkplumber.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=dev-bounces@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id F0A131C23C; Tue, 18 Jun 2019 18:16:58 +0200 (CEST) Received: from mail-pf1-f194.google.com (mail-pf1-f194.google.com [209.85.210.194]) by dpdk.org (Postfix) with ESMTP id 4CD761C220 for ; Tue, 18 Jun 2019 18:16:51 +0200 (CEST) Received: by mail-pf1-f194.google.com with SMTP id c85so7955635pfc.1 for ; Tue, 18 Jun 2019 09:16:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=MaX/9U1VKQDRlwJP1eh9LKqP+HAkhTNljy8r1/SknpU=; b=1LsYBKOnOMM8XoV2jH4ihDku+vZC4+KhVdlI/BpSD0AuBvDnSR6TH7lg8BKD9JzG2J 5sZguU4es0SqEpTYNRCbYuCEvSCgaz3LJHK9PjPwxFn1Iar3pdAXKQmol7QGlFghmhhY 9OxMXttg8zSIH283ZtmqOgLbZTFO/DoDrLppMZ8gI1vmvbPuRmrswvonFSNbgHKSeEqh dWw2Fs+3PaHXe59LV7Wodtg1EdNBfSXxH84EBDtAEw/Mp4wlcLMqRMM5JcuvyFrTVQO7 mm4L+qc50pSildLTc9EkNMAx9pSkPICXeVXSzGeRp1SVB3j3KJWpZ3fzOd7/HuHEXbQr LcVA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=MaX/9U1VKQDRlwJP1eh9LKqP+HAkhTNljy8r1/SknpU=; b=ME0yWUcD0IjgIin/1q+JBUaa88DfiDr6aL6ooIyy5DK6Tn/IhzC8ZYts8VGy0wMoEP C7I4tsVOcSGrMjakevUuNpMFCfwFlOCIEuQXh4mSDOPlIEqtHZVGyJWK5sliEW7Cxt3o tKQa6tMuiIlj5Q+G8PeD/F5c/D30Z8EyManP8NOWRRMZiK7TR5EpPZeiuN3XUfXvwVoc TlgsL+hftGhb4tqxh0oXfm2A9VF6mHPYYUrAQQWT8Lcxn6n60UrrcPzn/itwc+VjTA2s oyllpvKJfw15WHBJiF2i9SgEKO+NhaOQ2AXEyOIQftb3mAS6z0prR4rMgpRahvKmxiLq CJvg== X-Gm-Message-State: APjAAAXwzYkAxHyJEY8HckDwQ8q9ioQFfkeWPsHz50Dy6IsECOsTPuBy IMd8kfWuNbZFQv3BZz6MgechAFEj7SE= X-Google-Smtp-Source: APXvYqyWztEr8hTpvGICKWb7lQK9WNn1Wx96vP/4J+eZ4xUDgtGT8pPaISBq9FavRFjT/w/xnjuIFw== X-Received: by 2002:a65:5202:: with SMTP id o2mr3152440pgp.199.1560874610247; Tue, 18 Jun 2019 09:16:50 -0700 (PDT) Received: from hermes.lan (204-195-22-127.wavecable.com. [204.195.22.127]) by smtp.gmail.com with ESMTPSA id 3sm15485385pfp.114.2019.06.18.09.16.49 (version=TLS1_3 cipher=AEAD-AES256-GCM-SHA384 bits=256/256); Tue, 18 Jun 2019 09:16:49 -0700 (PDT) From: Stephen Hemminger To: dev@dpdk.org Cc: Stephen Hemminger Date: Tue, 18 Jun 2019 09:16:33 -0700 Message-Id: <20190618161636.23748-6-stephen@networkplumber.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20190618161636.23748-1-stephen@networkplumber.org> References: <20190610175155.21374-1-stephen@networkplumber.org> <20190618161636.23748-1-stephen@networkplumber.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Subject: [dpdk-dev] [PATCH v3 5/8] kni: use proper type for kni fifo's X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Using void * instead of proper type is unsafe practice. Signed-off-by: Stephen Hemminger --- kernel/linux/kni/kni_dev.h | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/kernel/linux/kni/kni_dev.h b/kernel/linux/kni/kni_dev.h index f3e6c3ca4efa..ceba5f73c1d9 100644 --- a/kernel/linux/kni/kni_dev.h +++ b/kernel/linux/kni/kni_dev.h @@ -51,22 +51,22 @@ struct kni_dev { struct net_device *net_dev; /* queue for packets to be sent out */ - void *tx_q; + struct rte_kni_fifo *tx_q; /* queue for the packets received */ - void *rx_q; + struct rte_kni_fifo *rx_q; /* queue for the allocated mbufs those can be used to save sk buffs */ - void *alloc_q; + struct rte_kni_fifo *alloc_q; /* free queue for the mbufs to be freed */ - void *free_q; + struct rte_kni_fifo *free_q; /* request queue */ - void *req_q; + struct rte_kni_fifo *req_q; /* response queue */ - void *resp_q; + struct rte_kni_fifo *resp_q; void *sync_kva; void *sync_va; -- 2.20.1