From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.5 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_SBL,URIBL_SBL_A, USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 54D32C31E5E for ; Wed, 19 Jun 2019 10:46:05 +0000 (UTC) Received: from dpdk.org (dpdk.org [92.243.14.124]) by mail.kernel.org (Postfix) with ESMTP id 1E78E21479 for ; Wed, 19 Jun 2019 10:46:01 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 1E78E21479 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=tuxdriver.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=dev-bounces@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 24EC51BF99; Wed, 19 Jun 2019 12:46:00 +0200 (CEST) Received: from smtp.tuxdriver.com (charlotte.tuxdriver.com [70.61.120.58]) by dpdk.org (Postfix) with ESMTP id 991271BF15 for ; Wed, 19 Jun 2019 12:45:58 +0200 (CEST) Received: from [107.15.85.130] (helo=localhost) by smtp.tuxdriver.com with esmtpsa (TLSv1:AES256-SHA:256) (Exim 4.63) (envelope-from ) id 1hdY69-0004ZW-4T; Wed, 19 Jun 2019 06:45:54 -0400 Date: Wed, 19 Jun 2019 06:45:43 -0400 From: Neil Horman To: Hemant Agrawal Cc: "dev@dpdk.org" , Jerin Jacob Kollanukkaran , Bruce Richardson , Thomas Monjalon , Shreyansh Jain Message-ID: <20190619104543.GB19712@hmswarspite.think-freely.org> References: <20190525184346.27932-1-nhorman@tuxdriver.com> <20190613142344.9188-1-nhorman@tuxdriver.com> <20190613142344.9188-6-nhorman@tuxdriver.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.11.3 (2019-02-01) Subject: Re: [dpdk-dev] [PATCH v2 05/10] fslmc: identify internal only functions and tag them as __rte_internal X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Mon, Jun 17, 2019 at 07:30:34AM +0000, Hemant Agrawal wrote: > HI Neil, > The same code of low-level HW driver is shared with different OSs (kernel, uboot etc) and different framework. If we introduce rte_internal in these low-level hw files, it will be a big maintenance issue for NXP. Everytime there is a change or upgrade, it will be a pain. > Why? If you don't want to support the use of a project specific tag in other projects, you can add a global cflag to those like this: -D__rte_experimental and the code will be eliminated I'm not sure what you see as difficult here Neil > Regards, > Hemant > > > -----Original Message----- > > From: Neil Horman > > Sent: Thursday, June 13, 2019 7:54 PM > > To: dev@dpdk.org > > Cc: Neil Horman ; Jerin Jacob Kollanukkaran > > ; Bruce Richardson ; > > Thomas Monjalon ; Hemant Agrawal > > ; Shreyansh Jain > > Subject: [PATCH v2 05/10] fslmc: identify internal only functions and tag them > > as __rte_internal > > Importance: High > > > > Identify functions in fslmc bus driver which are internal (based on > > their not having an rte_ prefix) and tag them with __rte_internal > > >