From: Ye Xiaolong <xiaolong.ye@intel.com>
To: Ferruh Yigit <ferruh.yigit@intel.com>
Cc: John McNamara <john.mcnamara@intel.com>,
Marko Kovacevic <marko.kovacevic@intel.com>,
Qi Zhang <qi.z.zhang@intel.com>,
Karlsson Magnus <magnus.karlsson@intel.com>,
Topel Bjorn <bjorn.topel@intel.com>,
yuan.peng@intel.com, dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH v3] net/af_xdp: support need wakeup feature
Date: Fri, 28 Jun 2019 16:35:39 +0800 [thread overview]
Message-ID: <20190628083539.GA90458@intel.com> (raw)
In-Reply-To: <d965c654-d331-be7d-3d2d-285b285e43ed@intel.com>
Hi, Ferruh
On 06/27, Ferruh Yigit wrote:
>On 6/21/2019 2:19 PM, Xiaolong Ye wrote:
>> This patch enables need_wakeup flag for Tx and fill rings, when this flag
>> is set by the driver, it means that the userspace application has to
>> explicitly wake up the kernel Rx or kernel Tx processing by issuing a
>> syscall. Poll() can wake up both and sendto() or its alternatives will wake
>> up Tx processing only.
>>
>> This feature is to provide efficient support for case that application and
>> driver executing on the same core.
>>
>> Signed-off-by: Xiaolong Ye <xiaolong.ye@intel.com>
>> ---
>> v3 changes:
>>
>> 1. add introduction in 19.08 release note
>>
>> v2 changes:
>>
>> 1. remove need_wakeup devarg to make need_wakeup feature enabled
>> unconditionally.
>> 2. add conditional compilation directive to avoid breaking build with
>> kernel which doesn't support need_wakeup feature yet.
>>
>> Note:
>>
>> Original busy poll feature has morphed into need_wakeup flag in
>> kernel side, the main purpose is the same, that is to support both
>> application and driver executing on the same core efficiently.
>> doc/guides/rel_notes/release_19_08.rst | 2 ++
>> drivers/net/af_xdp/rte_eth_af_xdp.c | 41 +++++++++++++++++++-------
>
>Hi Xiaolong,
>
>Can you please document this feature in af_xdp documentation? And if there
>specific kernel version requirement for this, can you please add this
>information too?
Got it, will do in next version.
Thanks,
Xiaolong
>
next prev parent reply other threads:[~2019-06-28 1:54 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-17 14:23 [dpdk-dev] [PATCH v1] net/af_xdp: support need wakeup feature Xiaolong Ye
2019-06-17 8:03 ` David Marchand
2019-06-17 15:27 ` Ye Xiaolong
2019-06-17 8:51 ` David Marchand
2019-06-17 10:05 ` Bruce Richardson
2019-06-17 15:39 ` Ye Xiaolong
2019-06-18 8:51 ` [dpdk-dev] [PATCH v2] " Xiaolong Ye
2019-06-21 13:19 ` [dpdk-dev] [PATCH v3] " Xiaolong Ye
2019-06-27 18:22 ` Ferruh Yigit
2019-06-28 8:35 ` Ye Xiaolong [this message]
2019-06-28 10:07 ` [dpdk-dev] [PATCH v4] " Xiaolong Ye
2019-06-28 17:58 ` Ferruh Yigit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190628083539.GA90458@intel.com \
--to=xiaolong.ye@intel.com \
--cc=bjorn.topel@intel.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=john.mcnamara@intel.com \
--cc=magnus.karlsson@intel.com \
--cc=marko.kovacevic@intel.com \
--cc=qi.z.zhang@intel.com \
--cc=yuan.peng@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).