From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.7 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 062EFC4321A for ; Fri, 28 Jun 2019 16:05:28 +0000 (UTC) Received: from dpdk.org (dpdk.org [92.243.14.124]) by mail.kernel.org (Postfix) with ESMTP id 8ED6920828 for ; Fri, 28 Jun 2019 16:05:27 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=networkplumber-org.20150623.gappssmtp.com header.i=@networkplumber-org.20150623.gappssmtp.com header.b="H2CvUCh5" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 8ED6920828 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=networkplumber.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=dev-bounces@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 9021534F0; Fri, 28 Jun 2019 18:05:26 +0200 (CEST) Received: from mail-pf1-f193.google.com (mail-pf1-f193.google.com [209.85.210.193]) by dpdk.org (Postfix) with ESMTP id 490271E20 for ; Fri, 28 Jun 2019 18:05:25 +0200 (CEST) Received: by mail-pf1-f193.google.com with SMTP id p184so3203391pfp.7 for ; Fri, 28 Jun 2019 09:05:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=SXN6rlLcIxG87S04h162tLXQjK4sHZWFaVAXpqwW44c=; b=H2CvUCh5H9c1VZZVcSA6jqqlNEm4HCA4J308HNbxd+DwA4DlBGBYDPIxSWZAbWAbcY hjE6RSetUB7fZFGJpSVW0emgU8/fBs/ngUkybANvP4v8zlmZ8trK4Nh9+uTHSvuMoD1K XIWEFV9Wz/hkRu2vfJ8eo+WWEOlIV4sy7C4uJkIteJHJZGlC7akdzy/QXupS4Um4FfTr dgq6xfUs22kIxxwOmDqVUc+H+EAAFqmdTwVYhCHAAmUYSVaZq5QlzTnKY182oyb4/sps OEHFH9DWOpaGvho6T2CBvIIFcWNFFb/dSMf+poTF6wnJCyi0bdbui4WrQxt3ZPBJJzkk TAWw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=SXN6rlLcIxG87S04h162tLXQjK4sHZWFaVAXpqwW44c=; b=dDZWIZGv1UARiCvOvH5Y1vR2v4zkNSpQdcrWo7wWtntFwdYvX76F/aoN1RbwJhzyi4 MdztsOE7lGAIDh98Wh27gX/T/ppBC3Nn3k7IRUiZZFJFp81seuv/lOIK+szSzoH535AD h86fh/M3f0vuyJmUqMQPn8qgwDeVa+J1A6+ijtveMSYNA6ai2UpCnF5vVIbwQBEsxumw HVqIw6FFmYhjZImT/IGrPqEkdEF5lMhhFEyx4AYLrpP6YGvVxXg2+Ccxc8aBIspEIG1v PiVgTGM27AhhsYJ0/2O6vCIYH2UzQ4a1CdHZFWpmX/P8iEUBJSBDDuCwtHmKQ6kQkWJX a0Sw== X-Gm-Message-State: APjAAAXuA4CRD47n/KuCzVmPMVoGmtu2IieF3w/HgKk9A8YLKCypCJpA tQfKs4eo9YJNDE3A7GZLEZEwDw== X-Google-Smtp-Source: APXvYqwFtGtULMVgD63S6twbB3djg7ZAwnPtET6S0TMWtVoawbAc4jZj5z72yaHlzG7B8SuwTmNVSQ== X-Received: by 2002:a17:90a:2666:: with SMTP id l93mr13968531pje.16.1561737924157; Fri, 28 Jun 2019 09:05:24 -0700 (PDT) Received: from hermes.lan (204-195-22-127.wavecable.com. [204.195.22.127]) by smtp.gmail.com with ESMTPSA id t2sm2094304pgo.61.2019.06.28.09.05.23 (version=TLS1_3 cipher=AEAD-AES256-GCM-SHA384 bits=256/256); Fri, 28 Jun 2019 09:05:23 -0700 (PDT) Date: Fri, 28 Jun 2019 09:05:16 -0700 From: Stephen Hemminger To: Adrien Mazarguil Cc: Thomas Monjalon , dev@dpdk.org, David Marchand , Mattias =?UTF-8?B?UsO2bm5ibG9t?= Message-ID: <20190628090516.0b06df77@hermes.lan> In-Reply-To: <20190628155056.28884-2-adrien.mazarguil@6wind.com> References: <20190628155056.28884-1-adrien.mazarguil@6wind.com> <20190628155056.28884-2-adrien.mazarguil@6wind.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [dpdk-dev] [PATCH 1/2] eal: fix duplicate experimental tag X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Fri, 28 Jun 2019 17:56:34 +0200 Adrien Mazarguil wrote: > Its presence on the function prototype in the header file is enough. >=20 > Fixes: 5f4ed3f05849 ("eal: introduce random generator with upper bound") > Cc: Mattias R=C3=B6nnblom >=20 > Signed-off-by: Adrien Mazarguil > --- > lib/librte_eal/common/rte_random.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) >=20 > diff --git a/lib/librte_eal/common/rte_random.c b/lib/librte_eal/common/r= te_random.c > index 3d9b9b7d8..f85119048 100644 > --- a/lib/librte_eal/common/rte_random.c > +++ b/lib/librte_eal/common/rte_random.c > @@ -137,7 +137,7 @@ rte_rand(void) > return __rte_rand_lfsr258(state); > } > =20 > -uint64_t __rte_experimental > +uint64_t > rte_rand_max(uint64_t upper_bound) > { > struct rte_rand_state *state; Almost any __rte_experimental in a .c file is wrong. The experimental tag is supposed to be on the prototype in the header. This seems to be a common problem: ./drivers/net/atlantic/rte_pmd_atlantic.c ./drivers/net/dpaa2/dpaa2_ethdev.c ./drivers/net/ixgbe/rte_pmd_ixgbe.c ./lib/librte_bbdev/rte_bbdev.c ./lib/librte_bpf/bpf.c ./lib/librte_bpf/bpf_exec.c ./lib/librte_bpf/bpf_load.c ./lib/librte_bpf/bpf_load_elf.c ./lib/librte_bpf/bpf_pkt.c ./lib/librte_compressdev/rte_comp.c ./lib/librte_compressdev/rte_compressdev.c ./lib/librte_compressdev/rte_compressdev_pmd.c ./lib/librte_cryptodev/rte_cryptodev.c ./lib/librte_eal/common/eal_common_class.c ./lib/librte_eal/common/eal_common_dev.c ./lib/librte_eal/common/eal_common_fbarray.c ./lib/librte_eal/common/eal_common_log.c ./lib/librte_eal/common/eal_common_memory.c ./lib/librte_eal/common/eal_common_proc.c ./lib/librte_eal/common/eal_common_timer.c ./lib/librte_eal/common/rte_malloc.c ./lib/librte_eal/common/rte_option.c ./lib/librte_eal/common/rte_random.c ./lib/librte_eal/common/rte_service.c ./lib/librte_eal/freebsd/eal/eal.c ./lib/librte_eal/freebsd/eal/eal_dev.c ./lib/librte_eal/freebsd/eal/eal_interrupts.c ./lib/librte_eal/linux/eal/eal_dev.c ./lib/librte_eal/linux/eal/eal_interrupts.c ./lib/librte_eal/linux/eal/eal_vfio.c ./lib/librte_ethdev/rte_ethdev.c ./lib/librte_ethdev/rte_flow.c ./lib/librte_ethdev/rte_mtr.c ./lib/librte_eventdev/rte_event_eth_rx_adapter.c ./lib/librte_flow_classify/rte_flow_classify.c ./lib/librte_hash/rte_cuckoo_hash.c ./lib/librte_ip_frag/rte_ip_frag_common.c ./lib/librte_ipsec/sa.c ./lib/librte_ipsec/ses.c ./lib/librte_kni/rte_kni.c ./lib/librte_kvargs/rte_kvargs.c ./lib/librte_mbuf/rte_mbuf.c ./lib/librte_meter/rte_meter.c ./lib/librte_net/rte_arp.c ./lib/librte_net/rte_net.c ./lib/librte_power/rte_power_empty_poll.c ./lib/librte_rcu/rte_rcu_qsbr.c ./lib/librte_sched/rte_sched.c ./lib/librte_security/rte_security.c ./lib/librte_telemetry/rte_telemetry.c ./lib/librte_telemetry/rte_telemetry_parser.c ./lib/librte_timer/rte_timer.c ./lib/librte_vhost/vdpa.c ./lib/librte_vhost/vhost_crypto.c