From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.5 required=3.0 tests=DATE_IN_FUTURE_06_12, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 01A24C5B57D for ; Tue, 2 Jul 2019 06:19:53 +0000 (UTC) Received: from dpdk.org (dpdk.org [92.243.14.124]) by mail.kernel.org (Postfix) with ESMTP id 96F6B2146F for ; Tue, 2 Jul 2019 06:19:52 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 96F6B2146F Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=intel.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=dev-bounces@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 88A091B996; Tue, 2 Jul 2019 08:19:27 +0200 (CEST) Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by dpdk.org (Postfix) with ESMTP id 156191B203; Tue, 2 Jul 2019 08:19:25 +0200 (CEST) X-Amp-Result: UNSCANNABLE X-Amp-File-Uploaded: False Received: from orsmga006.jf.intel.com ([10.7.209.51]) by orsmga104.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 01 Jul 2019 23:19:25 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.63,442,1557212400"; d="scan'208";a="168692839" Received: from yexl-server.sh.intel.com (HELO localhost) ([10.67.110.186]) by orsmga006.jf.intel.com with ESMTP; 01 Jul 2019 23:19:24 -0700 Date: Tue, 2 Jul 2019 21:00:43 +0800 From: Ye Xiaolong To: Haiyue Wang Cc: dev@dpdk.org, stable@dpdk.org Message-ID: <20190702130043.GA86373@intel.com> References: <1561459083-29808-1-git-send-email-haiyue.wang@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1561459083-29808-1-git-send-email-haiyue.wang@intel.com> User-Agent: Mutt/1.9.4 (2018-02-28) Subject: Re: [dpdk-dev] [PATCH v2] app/testpmd: fix setting RSS queue rule failure on fedora30 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 06/25, Haiyue Wang wrote: >Declare a local variable 'arg' to hold the pointer to ARGS_ENTRY_ARB, >otherwise, the pop 'arg' in 'parse_int' holds wrong data like 'arg-> >offset = 5912737, arg->size = 0', this caused the parse failure. > >If calling like 'push_args(ctx, ARGS_ENTRY_ARB..)', the below code for >assgining 'offset & size' will be missed for some gcc optimization. > >parse_vc_action_rss_queue > 29c5: c5 f9 ef c0 vpxor %xmm0,%xmm0,%xmm0 > 29c9: 43 8d 44 24 68 lea 0x68(%r12,%r12,1),%eax > 29ce: 48 c7 44 24 20 00 00 movq $0x0,0x20(%rsp) > 29d5: 00 00 > 29d7: c5 f8 29 44 24 10 vmovaps %xmm0,0x10(%rsp) > 29dd: 89 44 24 18 mov %eax,0x18(%rsp) > 29e1: 48 63 83 0c 01 00 00 movslq 0x10c(%rbx),%rax > 29e8: c7 44 24 1c 02 00 00 movl $0x2,0x1c(%rsp) > 29ef: 00 > 29f0: c5 f8 29 04 24 vmovaps %xmm0,(%rsp) > >The above assembly code is from this modification with: > gcc version 9.1.1 20190503 (Red Hat 9.1.1-1) (GCC) > Fedora release 30 (Thirty) > 5.1.11-300.fc30.x86_64 Do you mean without your patch, the above assembly code (for assgining offset & size) is missing, after apply this patch, it would show up? > >Fixes: d0ad8648b1c5 ("app/testpmd: fix RSS flow action configuration") >Cc: stable@dpdk.org > >Signed-off-by: Haiyue Wang >--- Minor nit, better to reply the v2 to v1 and add some changelog after the `---` mark. > app/test-pmd/cmdline_flow.c | 9 +++++---- > 1 file changed, 5 insertions(+), 4 deletions(-) > >diff --git a/app/test-pmd/cmdline_flow.c b/app/test-pmd/cmdline_flow.c >index 201bd9d..4a083d4 100644 >--- a/app/test-pmd/cmdline_flow.c >+++ b/app/test-pmd/cmdline_flow.c >@@ -3378,6 +3378,7 @@ parse_vc_action_rss_queue(struct context *ctx, const struct token *token, > { > static const enum index next[] = NEXT_ENTRY(ACTION_RSS_QUEUE); > struct action_rss_data *action_rss_data; >+ const struct arg *arg; > int ret; > int i; > >@@ -3393,10 +3394,10 @@ parse_vc_action_rss_queue(struct context *ctx, const struct token *token, > } > if (i >= ACTION_RSS_QUEUE_NUM) > return -1; >- if (push_args(ctx, >- ARGS_ENTRY_ARB(offsetof(struct action_rss_data, queue) + >- i * sizeof(action_rss_data->queue[i]), >- sizeof(action_rss_data->queue[i])))) >+ arg = ARGS_ENTRY_ARB(offsetof(struct action_rss_data, queue) + >+ i * sizeof(action_rss_data->queue[i]), >+ sizeof(action_rss_data->queue[i])); >+ if (push_args(ctx, arg)) > return -1; > ret = parse_int(ctx, token, str, len, NULL, 0); > if (ret < 0) { For the patch, Reviewed-by: Xiaolong Ye Thanks, Xiaolong >-- >2.7.4 >