From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id F41CBC74A2B for ; Wed, 10 Jul 2019 14:40:07 +0000 (UTC) Received: from dpdk.org (dpdk.org [92.243.14.124]) by mail.kernel.org (Postfix) with ESMTP id 88C2A20651 for ; Wed, 10 Jul 2019 14:40:07 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=Mellanox.com header.i=@Mellanox.com header.b="U3QGCOmE" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 88C2A20651 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=mellanox.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=dev-bounces@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 3A8D92F42; Wed, 10 Jul 2019 16:40:06 +0200 (CEST) Received: from EUR02-AM5-obe.outbound.protection.outlook.com (mail-eopbgr00050.outbound.protection.outlook.com [40.107.0.50]) by dpdk.org (Postfix) with ESMTP id 21390F04 for ; Wed, 10 Jul 2019 16:40:05 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=LPIdP7EyEHK24BHZ3qH14fkjCqYhXYHKuAYwBe4xM/U=; b=U3QGCOmEYwQAT0k7card3KgLJSWLaNM7TEDfd/kDOUBiiHhOZmVZVW/7y1y1ceSrZjDbkeh0gRR1WHibqnvlRTxnHh4b6a7rFf/1y2zr6LfxzXiIJGrWrCFVhfruigcXPZMaaZ2iGXF7GRM+wy3UVdYKfflnmsr5jrQNqjjth40= Received: from AM6PR05MB6567.eurprd05.prod.outlook.com (20.179.6.215) by AM6PR05MB6310.eurprd05.prod.outlook.com (20.179.5.15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2052.17; Wed, 10 Jul 2019 14:40:03 +0000 Received: from AM6PR05MB6567.eurprd05.prod.outlook.com ([fe80::496b:bd1c:863a:ed47]) by AM6PR05MB6567.eurprd05.prod.outlook.com ([fe80::496b:bd1c:863a:ed47%3]) with mapi id 15.20.2073.008; Wed, 10 Jul 2019 14:40:03 +0000 From: Jack Min To: Slava Ovsiienko CC: Raslan Darawsheh , Shahaf Shuler , Yongseok Koh , John McNamara , Marko Kovacevic , "dev@dpdk.org" Thread-Topic: [dpdk-dev] [Suspected-Phishing][PATCH v3] net/mlx5: support IP-in-IP tunnel Thread-Index: AQHVNy1bSIEkIIIlHUC3rcKAIa36dQ== Date: Wed, 10 Jul 2019 14:40:03 +0000 Message-ID: <20190710143953.75ilbcsllze4texd@mellanox.com> References: <20190528020426.18638-1-jackmin@mellanox.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-clientproxiedby: HK2PR0302CA0007.apcprd03.prod.outlook.com (2603:1096:202::17) To AM6PR05MB6567.eurprd05.prod.outlook.com (2603:10a6:20b:bc::23) authentication-results: spf=none (sender IP is ) smtp.mailfrom=jackmin@mellanox.com; x-ms-exchange-messagesentrepresentingtype: 1 x-originating-ip: [116.6.64.189] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: b02e7647-10b0-4ebc-4638-08d705447e16 x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: BCL:0; PCL:0; RULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600148)(711020)(4605104)(1401327)(4618075)(2017052603328)(7193020); SRVR:AM6PR05MB6310; x-ms-traffictypediagnostic: AM6PR05MB6310: x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:7691; x-forefront-prvs: 0094E3478A x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(4636009)(376002)(39860400002)(396003)(346002)(136003)(366004)(199004)(13464003)(189003)(76176011)(86362001)(6506007)(386003)(305945005)(102836004)(7736002)(53546011)(5660300002)(8936002)(4326008)(316002)(6246003)(256004)(14444005)(66446008)(66556008)(64756008)(66476007)(26005)(81156014)(53936002)(25786009)(66946007)(6486002)(81166006)(478600001)(186003)(6862004)(2616005)(2906002)(476003)(6436002)(8676002)(54906003)(446003)(71190400001)(11346002)(14454004)(6512007)(486006)(66066001)(36756003)(99286004)(229853002)(1076003)(52116002)(6636002)(3846002)(6116002)(68736007)(37006003)(71200400001); DIR:OUT; SFP:1101; SCL:1; SRVR:AM6PR05MB6310; H:AM6PR05MB6567.eurprd05.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1; received-spf: None (protection.outlook.com: mellanox.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam-message-info: IYwwAxMCeh+JvlwrKxwjBoC1ApJbKjatoXRc9Jb+NCkGdwf+HfugZ/txllP2cQEBOpT78K1Reti6r+yU/gkdVDO1CB0xpd26McGooJH6XW2mzfwfEgB+yv850tZTPekSdFbSt/RZkFWuGvWs7zcZAPtanbYkUNUZxUtUYyfdV44zJnNGUZ911rsMmRNjTAh1LLd0F2AuoO7AKtuqx9VeRb52Y/e0ojkXtaufc65yLqKO+zxg5zScEoiKf1CVR7HV9gaBEByAc74YCCJ+O5AGx7PUU1Mco9/NkOxE96S6lDJh5CeqK6tzZyKvg2haDS3uR6kAjk3Bm+UF4Xhg8908TQI92PPcyprcvBpjK/OduJMra9Q37rJkzD7VD83FMSP7VMg1JpDpIHBdkd81xxW1isisj8C9UmWkS+T+NyvB+vg= Content-Type: text/plain; charset="us-ascii" Content-ID: <3F713DAA4A854545B6542A7C8B34C8BF@eurprd05.prod.outlook.com> Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-Network-Message-Id: b02e7647-10b0-4ebc-4638-08d705447e16 X-MS-Exchange-CrossTenant-originalarrivaltime: 10 Jul 2019 14:40:03.1406 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: jackmin@mellanox.com X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM6PR05MB6310 Subject: Re: [dpdk-dev] [Suspected-Phishing][PATCH v3] net/mlx5: support IP-in-IP tunnel X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Wed, 19-07-10, 22:35, Slava Ovsiienko wrote: > Regarding point 2) - it is OK, there is common flags update in the item v= alidation loop. > So, after update point 1) - you can add my Acked-by to the patch, thanks. Great! thank you~ I'll update it soon. >=20 > WBR, > Slava >=20 > > -----Original Message----- > > From: dev On Behalf Of Slava Ovsiienko > > Sent: Wednesday, July 10, 2019 17:20 > > To: Jack Min ; Raslan Darawsheh > > ; Shahaf Shuler ; > > Yongseok Koh ; John McNamara > > ; Marko Kovacevic > > > > Cc: dev@dpdk.org > > Subject: Re: [dpdk-dev] [Suspected-Phishing][PATCH v3] net/mlx5: suppor= t > > IP-in-IP tunnel > >=20 > > Hi, Xiaoyu > >=20 > > There is a couple of small points to note: > > 1) It would be good to have the testpmd flow create command sample with > > new tunnels in commit log. > > 2) is it OK: "mlx5_flow_tunnel_ip_check(items, &last_item); " ? > > It looks like a bug, should the second parameter be "&item_flags" ?= (if so - > > please, fix all > > calls of mlx5_flow_tunnel_ip_check()) > >=20 > > WBR, > > Slava > >=20 > > > -----Original Message----- > > > From: Xiaoyu Min > > > Sent: Wednesday, July 10, 2019 13:15 > > > To: Raslan Darawsheh ; Slava Ovsiienko > > > ; Shahaf Shuler ; > > > Yongseok Koh ; John McNamara > > > ; Marko Kovacevic > > > > > Cc: dev@dpdk.org > > > Subject: [Suspected-Phishing][PATCH v3] net/mlx5: support IP-in-IP > > > tunnel > > > > > > Enabled IP-in-IP tunnel type support on DV/DR flow engine. > > > This includes the following combination: > > > - IPv4 over IPv4 > > > - IPv4 over IPv6 > > > - IPv6 over IPv4 > > > - IPv6 over IPv6 > > > > > > MLX5 NIC supports IP-in-IP tunnel via FLEX Parser so need to make sur= e > > > fw using FLEX Paser profile 0. > > > > > > mlxconfig -d -y set FLEX_PARSER_PROFILE_ENABLE=3D0 > > > > > > Signed-off-by: Xiaoyu Min > > > --- > > > v2: > > > * updated release note > > > v3: > > > * rebased on 19.08-rc1 > > > --- > > > doc/guides/nics/mlx5.rst | 15 ++++++++++- > > > doc/guides/rel_notes/release_19_08.rst | 1 + > > > drivers/net/mlx5/mlx5_flow.c | 35 ++++++++++++++++++++++++ > > > drivers/net/mlx5/mlx5_flow.h | 6 ++++- > > > drivers/net/mlx5/mlx5_flow_dv.c | 37 ++++++++++++++++++++++++= ++ > > > 5 files changed, 92 insertions(+), 2 deletions(-) > > >