dev.dpdk.org archive mirror
 help / color / mirror / Atom feed
From: Ye Xiaolong <xiaolong.ye@intel.com>
To: "Július Milan" <jmilan.dev@gmail.com>
Cc: dev@dpdk.org, qi.z.zhang@intel.com, david.marchand@redhat.com
Subject: Re: [dpdk-dev] [PATCH] net/af_xdp: fix xdp_get_channels_info return value
Date: Fri, 12 Jul 2019 23:43:19 +0800	[thread overview]
Message-ID: <20190712154319.GA51076@intel.com> (raw)
In-Reply-To: <20190712075546.GA20880@localhost.localdomain>

Hi, 

Thanks for the patch.

On 07/12, Július Milan wrote:
>Procedure xdp_get_channels_info was returning error code -1 in case of
>ioctl command SIOCETHTOOL was not supported. This patch sets return
>value back to 0 as it is valid case.
>
>Fixes: 339b88c6a9 ("net/af_xdp: support multi-queue")
>
>Signed-off-by: Július Milan <jmilan.dev@gmail.com>
>---
> drivers/net/af_xdp/rte_eth_af_xdp.c | 10 +++++++---
> 1 file changed, 7 insertions(+), 3 deletions(-)
>
>diff --git a/drivers/net/af_xdp/rte_eth_af_xdp.c b/drivers/net/af_xdp/rte_eth_af_xdp.c
>index ff8e90589..33352e10a 100644
>--- a/drivers/net/af_xdp/rte_eth_af_xdp.c
>+++ b/drivers/net/af_xdp/rte_eth_af_xdp.c
>@@ -852,9 +852,13 @@ xdp_get_channels_info(const char *if_name, int *max_queues,
> 	ifr.ifr_data = (void *)&channels;
> 	strncpy(ifr.ifr_name, if_name, IFNAMSIZ);
> 	ret = ioctl(fd, SIOCETHTOOL, &ifr);
>-	if (ret && errno != EOPNOTSUPP) {
>-		ret = -errno;
>-		goto out;
>+	if (ret) {
>+		if (errno == EOPNOTSUPP) {
>+			ret = 0;
>+		} else {
>+			ret = -errno;
>+			goto out;
>+		}
> 	}
> 
> 	if (channels.max_combined == 0 || errno == EOPNOTSUPP) {
>-- 
>2.21.0
>

Reviewed-by: Xiaolong Ye <xiaolong.ye@intel.com>

Thanks,
Xiaolong

  parent reply	other threads:[~2019-07-12  9:01 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-07-12  7:55 [dpdk-dev] [PATCH] net/af_xdp: fix xdp_get_channels_info return value Július Milan
2019-07-12 15:10 ` Stephen Hemminger
2019-07-12 15:35   ` Ferruh Yigit
2019-07-12 15:48     ` Stephen Hemminger
2019-07-12 16:07       ` Ferruh Yigit
2019-07-12 15:43 ` Ye Xiaolong [this message]
2019-07-12 15:01   ` Ferruh Yigit
2019-07-12 15:21     ` Stephen Hemminger
  -- strict thread matches above, loose matches on Subject: below --
2019-07-12  7:40 Július Milan
2019-07-12 15:09 ` Stephen Hemminger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190712154319.GA51076@intel.com \
    --to=xiaolong.ye@intel.com \
    --cc=david.marchand@redhat.com \
    --cc=dev@dpdk.org \
    --cc=jmilan.dev@gmail.com \
    --cc=qi.z.zhang@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).