From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.7 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EB7EEC7618F for ; Tue, 16 Jul 2019 16:17:16 +0000 (UTC) Received: from dpdk.org (dpdk.org [92.243.14.124]) by mail.kernel.org (Postfix) with ESMTP id 7EF582064B for ; Tue, 16 Jul 2019 16:17:16 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=networkplumber-org.20150623.gappssmtp.com header.i=@networkplumber-org.20150623.gappssmtp.com header.b="x9CNHgXa" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 7EF582064B Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=networkplumber.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=dev-bounces@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id A48161B957; Tue, 16 Jul 2019 18:17:15 +0200 (CEST) Received: from mail-pg1-f193.google.com (mail-pg1-f193.google.com [209.85.215.193]) by dpdk.org (Postfix) with ESMTP id 62A5D1B94F for ; Tue, 16 Jul 2019 18:17:14 +0200 (CEST) Received: by mail-pg1-f193.google.com with SMTP id f20so447658pgj.0 for ; Tue, 16 Jul 2019 09:17:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=lz+9IWmDNdxyCffMUYRbLSQMQjCNRQ2+VkLWjRjOD6M=; b=x9CNHgXaAj/DNNn6XoXi3Phn8MJ4EZu/IsmDRhQlnmg3TemggKEaF4W7l0d79f2Xlz DmFCDfJs38IAu65Igwl6RtHJxD7Cvvl0NsNl6XrQDtmfKZR5LvRr6Z1/Epvn4c8UuyEb zNltkLFZgiTrCggNcdHpZWR9zyi14bIOLzFMOfDA8LONKHrJ699Ja57j3+qoD/ERWwk3 p0Ux+qoMdGmnLtXjt+ppafeO8am5AsU5jSNBF4ElZSOgiIwl8XAcQoneokjonNH5e5ud T7HYU7mjHb9IS4nhz+03bgWKGoxLv7CuujaIWoZrmv28ivs2LMr0BoU0W442VfRYXZNs 66+g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=lz+9IWmDNdxyCffMUYRbLSQMQjCNRQ2+VkLWjRjOD6M=; b=hbt1EGWVWWAocLzg5zlXa+JsUYQeVnD5VlGW0t/YCF+AW4A1JRjVt9Yji/D+PD/D5O jXNaMrDikgwPhgU05x8sesnTGwB+gemhUKwQjjQuGCzPtUC/Ggu3H7q/mneqSCo69vGf PUb52rJ4xgd2Um9yd/XSHrGyVlhqFU5J9ttxBvPoFV/tvIMhg8tKUFVa4J/CW4422YYV etgPbEkUlcGyzl+1XJRcNvDvTG8tsbwrlt2h5Yw4j2Dt9MS4jWzpQsxbi6oWuQoqN58O S3/Dl57h4OzWlBOUVSCDN8E8gNFtPmfW6e1HTX3bJZ31jjZIG6f1VmhaUSREhaJLXxvj D5WQ== X-Gm-Message-State: APjAAAVIwYtoAg+H4Uz6JFcjALlfYHARsGWzNlCWdPtd3xIzj2GFf3b3 p17fREHaMDerxkF1IazOZEg= X-Google-Smtp-Source: APXvYqzzTbwEVDHhm1bZ2L2Kr4YP9ZJYRiVuB+pbZUiZy3aivTHpJxmrS7iAaqBOHvoxRh4oL9Llfg== X-Received: by 2002:a63:fe15:: with SMTP id p21mr35338924pgh.149.1563293833555; Tue, 16 Jul 2019 09:17:13 -0700 (PDT) Received: from hermes.lan (204-195-22-127.wavecable.com. [204.195.22.127]) by smtp.gmail.com with ESMTPSA id y22sm19193118pgj.38.2019.07.16.09.17.13 (version=TLS1_3 cipher=AEAD-AES256-GCM-SHA384 bits=256/256); Tue, 16 Jul 2019 09:17:13 -0700 (PDT) Date: Tue, 16 Jul 2019 09:17:04 -0700 From: Stephen Hemminger To: "Li, WenjieX A" Cc: "Wang, FengqinX" , "Byrne, Stephen1" , dev@dpdk.org Message-ID: <20190716091704.2f9d0d01@hermes.lan> In-Reply-To: <8688172CD5C0B74590FAE19D9579F94B53742875@SHSMSX103.ccr.corp.intel.com> References: <20190516180427.17270-1-stephen@networkplumber.org> <20190624204435.29452-1-stephen@networkplumber.org> <20190624204435.29452-7-stephen@networkplumber.org> <8688172CD5C0B74590FAE19D9579F94B53742875@SHSMSX103.ccr.corp.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH v5 6/8] cmdline: use new ethernet address parser X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Tue, 16 Jul 2019 01:17:56 +0000 "Li, WenjieX A" wrote: > Hi Stephen, > > > > This DPDK patch makes cmdline_autotest failed. List the details as below. > > Could you please help to resolve it? > > Thank you! > Test Setup > Steps to reproduce > List the steps to reproduce the issue. > ./x86_64-native-linuxapp-gcc/app/test -n 1 -c 0xff > testpmd> cmdline_autotest > Show the output from the previous commands. > Testind parsing ethernet addresses... > Error: parsing 01:23:45:67:89:A succeeded! > Test Failed > Expected Result > Explain what is the expected result in text or as an example output: > Testind parsing ethernet addresses... > Testind parsing port lists... > Testind parsing numbers... > Testing parsing IP addresses... > Testing parsing strings... > Testing circular buffer... > Testing library functions... > Test OK > > > > BR, > > Wenjie > There are two possible solutions. Make the ether_unformat_addr function more complex and more restrictive. The new version corresponds to the FreeBSD behavior. The other possibility is just remove the test case. I am leaning towards the latter as the least work.