From: Ajit Khaparde <ajit.khaparde@broadcom.com>
To: dev@dpdk.org
Cc: ferruh.yigit@intel.com, Lance Richardson <lance.richardson@broadcom.com>
Subject: [dpdk-dev] [PATCH v2 10/15] net/bnxt: avoid null pointer dereference
Date: Tue, 16 Jul 2019 14:58:21 +0530 [thread overview]
Message-ID: <20190716092826.54276-11-ajit.khaparde@broadcom.com> (raw)
In-Reply-To: <20190716092826.54276-1-ajit.khaparde@broadcom.com>
From: Lance Richardson <lance.richardson@broadcom.com>
Avoid null pointer dereference when allocating an insolated
completion ring by basing nq ring allocation on whether an
nq ring was requested instead of whether the device supports
nq rings.
Fixes: f8168ca0e690 ("net/bnxt: support thor controller")
Signed-off-by: Lance Richardson <lance.richardson@broadcom.com>
Signed-off-by: Ajit Khaparde <ajit.khaparde@broadcom.com>
---
drivers/net/bnxt/bnxt_ring.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/bnxt/bnxt_ring.c b/drivers/net/bnxt/bnxt_ring.c
index faf861cc1..ada748c05 100644
--- a/drivers/net/bnxt/bnxt_ring.c
+++ b/drivers/net/bnxt/bnxt_ring.c
@@ -280,7 +280,7 @@ int bnxt_alloc_rings(struct bnxt *bp, uint16_t qidx,
}
cp_ring_info->hw_stats_ctx_id = HWRM_NA_SIGNATURE;
- if (BNXT_HAS_NQ(bp)) {
+ if (nq_ring_info) {
struct bnxt_ring *nq_ring = nq_ring_info->cp_ring_struct;
nq_ring->bd = (char *)mz->addr + nq_ring_start;
--
2.20.1 (Apple Git-117)
next prev parent reply other threads:[~2019-07-16 9:30 UTC|newest]
Thread overview: 54+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-12 6:06 [dpdk-dev] [PATCH 00/15] bnxt patch series Ajit Khaparde
2019-07-12 6:06 ` [dpdk-dev] [PATCH 01/15] net/bnxt: fix extended port counter statistics Ajit Khaparde
2019-07-12 15:04 ` Stephen Hemminger
2019-07-12 6:06 ` [dpdk-dev] [PATCH 02/15] net/bnxt: fix possible segfault in case of probe failure Ajit Khaparde
2019-07-12 6:06 ` [dpdk-dev] [PATCH 03/15] net/bnxt: do not fail VF probe when the MAC address is zero Ajit Khaparde
2019-07-12 6:06 ` [dpdk-dev] [PATCH 04/15] net/bnxt: fix Tx hang after port stop/start Ajit Khaparde
2019-07-12 6:06 ` [dpdk-dev] [PATCH 05/15] net/bnxt: reset Rx allocation state on port restart Ajit Khaparde
2019-07-12 12:06 ` Lance Richardson
2019-07-12 12:09 ` Lance Richardson
2019-07-12 6:06 ` [dpdk-dev] [PATCH 06/15] net/bnxt: correctly set L4 checksum error for tunnel and non-tunnel packets Ajit Khaparde
2019-07-12 6:06 ` [dpdk-dev] [PATCH 07/15] net/bnxt: fix for doorbell register offset for Tx ring Ajit Khaparde
2019-07-12 6:06 ` [dpdk-dev] [PATCH 08/15] net/bnxt: save the number of EM flow count Ajit Khaparde
2019-07-12 6:06 ` [dpdk-dev] [PATCH 09/15] net/bnxt: nq doorbell cleanups Ajit Khaparde
2019-07-12 6:06 ` [dpdk-dev] [PATCH 10/15] net/bnxt: avoid null pointer dereference Ajit Khaparde
2019-07-12 6:06 ` [dpdk-dev] [PATCH 11/15] net/bnxt: fix to enable disable interrupts correctly in start stop Ajit Khaparde
2019-07-12 6:06 ` [dpdk-dev] [PATCH 12/15] net/bnxt: fix to check for invalid VNIC in cleanup path Ajit Khaparde
2019-07-12 6:06 ` [dpdk-dev] [PATCH 13/15] net/bnxt: fix a compilation warning Ajit Khaparde
2019-07-12 13:50 ` Ajit Kumar Khaparde
2019-07-12 6:06 ` [dpdk-dev] [PATCH 14/15] net/bnxt: fix rxq count if ntuple filtering is disabled Ajit Khaparde
2019-07-12 6:06 ` [dpdk-dev] [PATCH 15/15] net/bnxt: fix to avoid sending invalid VNIC id to firmware Ajit Khaparde
2019-07-16 9:28 ` [dpdk-dev] [PATCH v2 00/15] bnxt patch series Ajit Khaparde
2019-07-16 9:28 ` [dpdk-dev] [PATCH v2 01/15] net/bnxt: fix extended port counter statistics Ajit Khaparde
2019-07-16 9:28 ` [dpdk-dev] [PATCH v2 02/15] net/bnxt: fix possible segfault in case of probe failure Ajit Khaparde
2019-07-16 9:28 ` [dpdk-dev] [PATCH v2 03/15] net/bnxt: do not fail VF probe when the MAC address is zero Ajit Khaparde
2019-07-16 9:28 ` [dpdk-dev] [PATCH v2 04/15] net/bnxt: fix Tx hang after port stop/start Ajit Khaparde
2019-07-16 9:28 ` [dpdk-dev] [PATCH v2 05/15] net/bnxt: reset Rx allocation state on port restart Ajit Khaparde
2019-07-16 9:28 ` [dpdk-dev] [PATCH v2 06/15] net/bnxt: correctly set L4 checksum error for tunnel and non-tunnel packets Ajit Khaparde
2019-07-16 9:28 ` [dpdk-dev] [PATCH v2 07/15] net/bnxt: fix for doorbell register offset for Tx ring Ajit Khaparde
2019-07-16 9:28 ` [dpdk-dev] [PATCH v2 08/15] net/bnxt: save the number of EM flow count Ajit Khaparde
2019-07-16 9:28 ` [dpdk-dev] [PATCH v2 09/15] net/bnxt: nq doorbell cleanups Ajit Khaparde
2019-07-16 9:28 ` Ajit Khaparde [this message]
2019-07-16 9:28 ` [dpdk-dev] [PATCH v2 11/15] net/bnxt: fix to enable disable interrupts correctly in start stop Ajit Khaparde
2019-07-16 9:28 ` [dpdk-dev] [PATCH v2 12/15] net/bnxt: fix to check for invalid VNIC in cleanup path Ajit Khaparde
2019-07-16 9:28 ` [dpdk-dev] [PATCH v2 13/15] net/bnxt: fix a compilation warning Ajit Khaparde
2019-07-16 9:28 ` [dpdk-dev] [PATCH v2 14/15] net/bnxt: fix rxq count if ntuple filtering is disabled Ajit Khaparde
2019-07-16 9:28 ` [dpdk-dev] [PATCH v2 15/15] net/bnxt: fix to avoid sending invalid VNIC id to firmware Ajit Khaparde
2019-07-16 18:42 ` [dpdk-dev] [PATCH v2 00/15] bnxt patch series Ferruh Yigit
2019-07-17 10:41 ` [dpdk-dev] [PATCH v3 " Ajit Khaparde
2019-07-17 10:41 ` [dpdk-dev] [PATCH v3 01/15] net/bnxt: fix extended port counter statistics Ajit Khaparde
2019-07-17 10:41 ` [dpdk-dev] [PATCH v3 02/15] net/bnxt: fix possible segfault in case of probe failure Ajit Khaparde
2019-07-17 10:41 ` [dpdk-dev] [PATCH v3 03/15] net/bnxt: do not fail VF probe when the MAC address is zero Ajit Khaparde
2019-07-17 10:41 ` [dpdk-dev] [PATCH v3 04/15] net/bnxt: fix Tx hang after port stop/start Ajit Khaparde
2019-07-17 10:41 ` [dpdk-dev] [PATCH v3 05/15] net/bnxt: reset Rx allocation state on port restart Ajit Khaparde
2019-07-17 10:41 ` [dpdk-dev] [PATCH v3 06/15] net/bnxt: fix L4 checksum error indication in Rx path Ajit Khaparde
2019-07-17 10:41 ` [dpdk-dev] [PATCH v3 07/15] net/bnxt: fix for doorbell register offset for Tx ring Ajit Khaparde
2019-07-17 10:41 ` [dpdk-dev] [PATCH v3 08/15] net/bnxt: save the number of EM flow count Ajit Khaparde
2019-07-17 10:41 ` [dpdk-dev] [PATCH v3 09/15] net/bnxt: nq doorbell cleanups Ajit Khaparde
2019-07-17 10:41 ` [dpdk-dev] [PATCH v3 10/15] net/bnxt: avoid null pointer dereference Ajit Khaparde
2019-07-17 10:41 ` [dpdk-dev] [PATCH v3 11/15] net/bnxt: fix to enable disable interrupts correctly Ajit Khaparde
2019-07-17 10:41 ` [dpdk-dev] [PATCH v3 12/15] net/bnxt: fix to check for invalid VNIC in cleanup path Ajit Khaparde
2019-07-17 10:41 ` [dpdk-dev] [PATCH v3 13/15] net/bnxt: fix a compilation warning Ajit Khaparde
2019-07-17 10:41 ` [dpdk-dev] [PATCH v3 14/15] net/bnxt: fix rxq count if ntuple filtering is disabled Ajit Khaparde
2019-07-17 10:41 ` [dpdk-dev] [PATCH v3 15/15] net/bnxt: fix to avoid sending invalid VNIC id to firmware Ajit Khaparde
2019-07-17 17:15 ` [dpdk-dev] [PATCH v3 00/15] bnxt patch series Ferruh Yigit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190716092826.54276-11-ajit.khaparde@broadcom.com \
--to=ajit.khaparde@broadcom.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=lance.richardson@broadcom.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).