From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E6A27C76188 for ; Tue, 16 Jul 2019 13:43:34 +0000 (UTC) Received: from dpdk.org (dpdk.org [92.243.14.124]) by mail.kernel.org (Postfix) with ESMTP id A54F02173C for ; Tue, 16 Jul 2019 13:43:34 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org A54F02173C Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=intel.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=dev-bounces@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 53AF02C18; Tue, 16 Jul 2019 15:43:33 +0200 (CEST) Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by dpdk.org (Postfix) with ESMTP id C7AA32BF5 for ; Tue, 16 Jul 2019 15:43:31 +0200 (CEST) X-Amp-Result: UNKNOWN X-Amp-Original-Verdict: FILE UNKNOWN X-Amp-File-Uploaded: False Received: from orsmga003.jf.intel.com ([10.7.209.27]) by fmsmga107.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 16 Jul 2019 06:43:30 -0700 X-IronPort-AV: E=Sophos;i="5.63,498,1557212400"; d="scan'208";a="169932578" Received: from bricha3-mobl.ger.corp.intel.com ([10.237.221.51]) by orsmga003-auth.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 16 Jul 2019 06:43:28 -0700 Date: Tue, 16 Jul 2019 14:43:25 +0100 From: Bruce Richardson To: Thomas Monjalon Cc: Ferruh Yigit , Hemant Agrawal , dev@dpdk.org Message-ID: <20190716134325.GA1309@bricha3-MOBL.ger.corp.intel.com> References: <20190627093343.5171-2-hemant.agrawal@nxp.com> <2215079.QxrPnuoOdN@xps> <38a8dc70-51f2-ad22-c211-953beaadcb99@intel.com> <2854650.ZaSKyfgELu@xps> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <2854650.ZaSKyfgELu@xps> User-Agent: Mutt/1.11.4 (2019-03-13) Subject: Re: [dpdk-dev] [PATCH v3 0/5] FSLMC bus enchancements X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Tue, Jul 16, 2019 at 03:36:53PM +0200, Thomas Monjalon wrote: > 16/07/2019 13:40, Ferruh Yigit: > > On 7/15/2019 10:53 PM, Thomas Monjalon wrote: > > > 15/07/2019 10:44, Hemant Agrawal: > > >> Nipun Gupta (1): > > >> bus/fslmc: use cinh read for eqcr ci on ls1088 platform > > >> > > >> Sachin Saxena (1): > > >> mempool/dpaa2: vfio dmamap for user allocated memory > > >> > > >> Shreyansh Jain (3): > > >> bus/fslmc: support device iteration > > >> bus/fslmc: enhance error handling for dev parsing > > >> bus/fslmc: dynamic iommu mode detection > > > > > > I had the following comments on v1: > > > The title should start with a verb. > > > VFIO and DMA should be uppercase. > > > I tried to fix it. > > > > > > Applied, thanks > > > > Getting build error with "ppc_64-power8-linuxapp-gcc" target [1], related to the > > wrong format specifier. Not sure it is only ppc one. > > It's so disappointing. > I don't know how many times I tried to explain the issue with %lx. > Should we just forbid %lx and %llx usage? > We could, I suppose, so long as there never is a case where we actually do use long, or long long variables. A checkpatch-style warning when one is used probably is the best option, since it may help with catching these earlier, while still allowing flexibility and human judgement as to whether an instance is correct or not. /Bruce