From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.8 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_SBL,URIBL_SBL_A,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2E4CBC76186 for ; Wed, 17 Jul 2019 08:57:10 +0000 (UTC) Received: from dpdk.org (dpdk.org [92.243.14.124]) by mail.kernel.org (Postfix) with ESMTP id 6D0B92077C for ; Wed, 17 Jul 2019 08:57:09 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=monjalon.net header.i=@monjalon.net header.b="crpkKYxt"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=messagingengine.com header.i=@messagingengine.com header.b="cd99NR3G" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 6D0B92077C Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=monjalon.net Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=dev-bounces@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 264C01C01; Wed, 17 Jul 2019 10:57:08 +0200 (CEST) Received: from wout5-smtp.messagingengine.com (wout5-smtp.messagingengine.com [64.147.123.21]) by dpdk.org (Postfix) with ESMTP id C0292DE3 for ; Wed, 17 Jul 2019 10:57:06 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.west.internal (Postfix) with ESMTP id 8D2E7440; Wed, 17 Jul 2019 04:57:05 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute1.internal (MEProxy); Wed, 17 Jul 2019 04:57:05 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; s=mesmtp; bh=qjH2FesIF+OyotaxmCPh5YO X0OlXm2jUXW9yAHh2I54=; b=crpkKYxtnKt1eWIyOAuFuzC8bgi6cTsFU2PVSYs UstUkxh+rns+fFW4gTcAqE2AGEb6Vwyzx48kTrzZ+9r6x+qZRJf0hgsAesRlAQ9G nLioMfpfIuxWmU8SxwLzpjglsMr3K82Ch0H45EX4qO0UKYZjhZWHiV5dwVFW5SY4 F0G4= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:date:from :message-id:mime-version:subject:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm3; bh=qjH2FesIF+Oyotaxm CPh5YOX0OlXm2jUXW9yAHh2I54=; b=cd99NR3G6cuve24kkRrxaH8Es2i4eAjR5 RjXop1XFyz6sX6A7WaKf5jxtWVBs6ucvGwZRoyA/TsVtaxK2xXOR7kvtWQ4Igz0m 42tZG4NgLg4mtnNmz7lCltGDSw9d5TWRehp048q8VSMNwEOA1gCawydNs1DRFPAu J89la5rwGGb2W6W4LL4RbpSyJ53RAaSUGXRX+ITmA9rms/zUxFBzTVH6ZuXr2lNQ 6Ir7B8ra6oaBgNStQAHn6tFdDH5ZAF0iQcHFo08LN9VfsETTqQ4dAJMyCrA5NMfc 8F9DBPMuqw4ckN0dI1qD1KAPvs8vU7+LCOVpQBfLZbQZL/6AUg9+A== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduvddriedvgdduudcutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecunecujfgurhephffvufffkffoggfgsedtkeertdertd dtnecuhfhrohhmpefvhhhomhgrshcuofhonhhjrghlohhnuceothhhohhmrghssehmohhn jhgrlhhonhdrnhgvtheqnecukfhppeejjedrudefgedrvddtfedrudekgeenucfrrghrrg hmpehmrghilhhfrhhomhepthhhohhmrghssehmohhnjhgrlhhonhdrnhgvthenucevlhhu shhtvghrufhiiigvpedt X-ME-Proxy: Received: from xps.monjalon.net (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 0933880062; Wed, 17 Jul 2019 04:57:03 -0400 (EDT) From: Thomas Monjalon To: anatoly.burakov@intel.com Cc: dev@dpdk.org Date: Wed, 17 Jul 2019 10:56:24 +0200 Message-Id: <20190717085624.30452-1-thomas@monjalon.net> X-Mailer: git-send-email 2.21.0 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Subject: [dpdk-dev] [PATCH] eal: update comment about --no-huge option X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" The old comment, on top of the function rte_eal_has_hugepages(), is really outdated and not generic enough. Signed-off-by: Thomas Monjalon --- lib/librte_eal/common/include/rte_eal.h | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/lib/librte_eal/common/include/rte_eal.h b/lib/librte_eal/common/include/rte_eal.h index 34245b053..b7cf91214 100644 --- a/lib/librte_eal/common/include/rte_eal.h +++ b/lib/librte_eal/common/include/rte_eal.h @@ -448,10 +448,7 @@ rte_set_application_usage_hook(rte_usage_hook_t usage_func); /** * Whether EAL is using huge pages (disabled by --no-huge option). - * The no-huge mode cannot be used with UIO poll-mode drivers like igb/ixgbe. - * It is useful for NIC drivers (e.g. librte_pmd_mlx4, librte_pmd_vmxnet3) or - * crypto drivers (e.g. librte_crypto_nitrox) provided by third-parties such - * as 6WIND. + * The no-huge mode is not compatible with all drivers or features. * * @return * Nonzero if hugepages are enabled. -- 2.21.0