From: Stephen Hemminger <stephen@networkplumber.org>
To: <pbhagavatula@marvell.com>
Cc: <jerinj@marvell.com>, Nithin Dabilpuram <ndabilpuram@marvell.com>,
"Vamsi Attunuru" <vattunuru@marvell.com>, <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH] mempool/octeontx2: use noinline to preserve ABI
Date: Thu, 18 Jul 2019 07:43:20 -0700 [thread overview]
Message-ID: <20190718074320.0571e83f@hermes.lan> (raw)
In-Reply-To: <20190717184013.1072-1-pbhagavatula@marvell.com>
On Thu, 18 Jul 2019 00:10:13 +0530
<pbhagavatula@marvell.com> wrote:
> From: Pavan Nikhilesh <pbhagavatula@marvell.com>
>
> Since direct register access is used in npa_lf_aura_op_alloc_bulk()
> use __rte_noinline to preserve ABI.
>
> Signed-off-by: Pavan Nikhilesh <pbhagavatula@marvell.com>
Huh? this is an internal function, and the driver is new to DPDK.
We don't maintain ABI with external drivers or code bases.
And ABI with code before it was upstream doesn't count either.
next prev parent reply other threads:[~2019-07-18 14:43 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-17 18:40 [dpdk-dev] [PATCH] mempool/octeontx2: use noinline to preserve ABI pbhagavatula
2019-07-18 5:53 ` Jerin Jacob Kollanukkaran
2019-07-18 6:51 ` [dpdk-dev] [PATCH v2] mempool/octeontx2: fix possible ABI break with force inline pbhagavatula
2019-07-18 8:04 ` Jerin Jacob Kollanukkaran
2019-07-18 22:15 ` Thomas Monjalon
2019-07-18 14:43 ` Stephen Hemminger [this message]
2019-07-18 14:49 ` [dpdk-dev] [EXT] Re: [PATCH] mempool/octeontx2: use noinline to preserve ABI Pavan Nikhilesh Bhagavatula
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190718074320.0571e83f@hermes.lan \
--to=stephen@networkplumber.org \
--cc=dev@dpdk.org \
--cc=jerinj@marvell.com \
--cc=ndabilpuram@marvell.com \
--cc=pbhagavatula@marvell.com \
--cc=vattunuru@marvell.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).