DPDK-dev Archive on lore.kernel.org
 help / color / Atom feed
From: Ajit Khaparde <ajit.khaparde@broadcom.com>
To: dev@dpdk.org
Cc: ferruh.yigit@intel.com, Lance Richardson <lance.richardson@broadcom.com>
Subject: [dpdk-dev] [PATCH 5/7] net/bnxt: disable vector mode Tx with VLAN offload
Date: Fri, 19 Jul 2019 11:49:04 +0530
Message-ID: <20190719061906.42451-6-ajit.khaparde@broadcom.com> (raw)
In-Reply-To: <20190719061906.42451-1-ajit.khaparde@broadcom.com>

From: Lance Richardson <lance.richardson@broadcom.com>

The vector mode transmit path does not currently support VLAN tag
insertion, so we need to disable vector transmit when transmit
VLAN insertion offload is enabled.

Fixes: bc4a000f2f53 ("net/bnxt: implement SSE vector mode")
Reviewed-by: Ajit Khaparde <ajit.khaparde@broadcom.com>
Signed-off-by: Lance Richardson <lance.richardson@broadcom.com>
Signed-off-by: Ajit Khaparde <ajit.khaparde@broadcom.com>
---
 drivers/net/bnxt/bnxt_ethdev.c | 8 +++-----
 1 file changed, 3 insertions(+), 5 deletions(-)

diff --git a/drivers/net/bnxt/bnxt_ethdev.c b/drivers/net/bnxt/bnxt_ethdev.c
index fec1ecbae..d6176a686 100644
--- a/drivers/net/bnxt/bnxt_ethdev.c
+++ b/drivers/net/bnxt/bnxt_ethdev.c
@@ -743,13 +743,11 @@ bnxt_transmit_function(__rte_unused struct rte_eth_dev *eth_dev)
 {
 #ifdef RTE_ARCH_X86
 	/*
-	 * Vector mode receive can be enabled only if scatter tx is not
-	 * in use and tx offloads other than VLAN insertion are not
-	 * in use.
+	 * Vector mode transmit can be enabled only if not using scatter rx
+	 * or tx offloads.
 	 */
 	if (!eth_dev->data->scattered_rx &&
-	    !(eth_dev->data->dev_conf.txmode.offloads &
-	      ~DEV_TX_OFFLOAD_VLAN_INSERT)) {
+	    !eth_dev->data->dev_conf.txmode.offloads) {
 		PMD_DRV_LOG(INFO, "Using vector mode transmit for port %d\n",
 			    eth_dev->data->port_id);
 		return bnxt_xmit_pkts_vec;
-- 
2.20.1 (Apple Git-117)


  parent reply index

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-07-19  6:18 [dpdk-dev] [PATCH 0/7] bnxt patches Ajit Khaparde
2019-07-19  6:19 ` [dpdk-dev] [PATCH 1/7] net/bnxt: add new device id Ajit Khaparde
2019-07-19  6:19 ` [dpdk-dev] [PATCH 2/7] net/bnxt: use correct number of RSS contexts for thor Ajit Khaparde
2019-07-19 21:38   ` Ferruh Yigit
2019-07-19  6:19 ` [dpdk-dev] [PATCH 3/7] net/bnxt: fix receive interrupt vector Ajit Khaparde
2019-07-19  6:19 ` [dpdk-dev] [PATCH 4/7] net/bnxt: fix interrupt rearm logic Ajit Khaparde
2019-07-19  6:19 ` Ajit Khaparde [this message]
2019-07-19  6:19 ` [dpdk-dev] [PATCH 6/7] net/bnxt: remove unnecessary interrupt disable Ajit Khaparde
2019-07-19  6:19 ` [dpdk-dev] [PATCH 7/7] doc: update release information for bnxt Ajit Khaparde
2019-07-19 21:38   ` Ferruh Yigit
2019-07-19 12:33 ` [dpdk-dev] [PATCH 0/7] bnxt patches Ferruh Yigit
2019-07-19 16:18   ` Stephen Hemminger
2019-07-19 16:58     ` Ferruh Yigit
2019-07-19 21:39 ` Ferruh Yigit

Reply instructions:

You may reply publically to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190719061906.42451-6-ajit.khaparde@broadcom.com \
    --to=ajit.khaparde@broadcom.com \
    --cc=dev@dpdk.org \
    --cc=ferruh.yigit@intel.com \
    --cc=lance.richardson@broadcom.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

DPDK-dev Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/dpdk-dev/0 dpdk-dev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 dpdk-dev dpdk-dev/ https://lore.kernel.org/dpdk-dev \
		dev@dpdk.org
	public-inbox-index dpdk-dev

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.dpdk.dev


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git