From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.5 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3A2DDC76186 for ; Tue, 23 Jul 2019 18:05:14 +0000 (UTC) Received: from dpdk.org (dpdk.org [92.243.14.124]) by mail.kernel.org (Postfix) with ESMTP id C36192239E for ; Tue, 23 Jul 2019 18:05:13 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=networkplumber-org.20150623.gappssmtp.com header.i=@networkplumber-org.20150623.gappssmtp.com header.b="P5whstql" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org C36192239E Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=networkplumber.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=dev-bounces@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 9C72D1C08E; Tue, 23 Jul 2019 20:05:12 +0200 (CEST) Received: from mail-pl1-f195.google.com (mail-pl1-f195.google.com [209.85.214.195]) by dpdk.org (Postfix) with ESMTP id 212441C08D for ; Tue, 23 Jul 2019 20:05:11 +0200 (CEST) Received: by mail-pl1-f195.google.com with SMTP id m9so20817627pls.8 for ; Tue, 23 Jul 2019 11:05:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=0JyKP4ATqGgVYs/gAVXv0FUORLJsMsa2nFEK1WrmyGE=; b=P5whstqlp4DSsdewQ2TkevQBC7BvEIPbl59gTXbIo5EgbNnNrluHxFRxmu1F+m4YSu 9TsaLy20QvZujLtpbNFHfDehT8hOqyWpL0N4w0x9ku0Qm7W+6HlbmQRt96kHGKPI+gpb Md3fOOH68y9RBN7TVVS8ett+xG1byBuoZ98BMI0RKDuJlMs3KOP0uhvSLVpegumbJv7I 29+rYm28FXCZc98bMqk4J4FJLdWR1+NxHlKmz0FAT84swQPfkpC+Ig3RJSmnkN0Jxdje 6WqVob/umHszdVNJw2P9Cw0NRNLWaHk4NB2k6pADN/dBTwavAsxpwM4AabJNRV0LHy/M I+ng== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=0JyKP4ATqGgVYs/gAVXv0FUORLJsMsa2nFEK1WrmyGE=; b=bX+1wPDNIp5NmitQ7Y9hAYaF+05FvBDgXI3O3waWxfgF9Byj1Ut8x7rpCrlc0oyHQO 9Ltv6XPFKiazP8kO+Gs9Mm7nuMLt+5g4guxCl3pTto8oXB4Dq/iYsDlC2TA4+MqTXyr+ STpEFEAwdZAPPaf2NCbOx0ekluBc/jqpbMantkBQIBqkR7hVLw1m0TbEx1+33IzzvnNL msUSrZjd4F5ZyKiw1uT2g20ImmqFM9vYKl3aGaHbMJ7adOulmmv8/hFfpEvPhwI1EtQj VZYXJqWpaV3LwHmPz/nw7GcDp7khwVR8vz+2fCnDAmuytABJ1QYegNEiYaJFzDQH1LWq EgKA== X-Gm-Message-State: APjAAAXMWpLWWEHtXZjkM5BCRyTXw7f+mXZnk6fVADe/U2/kWkqw2QNk iZNXFANXzVnHgaj2OPQrM5o= X-Google-Smtp-Source: APXvYqwcgI9DdrDYTeSIcWFG8z41Dkj7K2p8Kp109VSF2yJNDA89BG/XGi3MMY5VhHPRkPEXqoyMgg== X-Received: by 2002:a17:902:26c:: with SMTP id 99mr84517517plc.215.1563905110221; Tue, 23 Jul 2019 11:05:10 -0700 (PDT) Received: from hermes.lan (204-195-22-127.wavecable.com. [204.195.22.127]) by smtp.gmail.com with ESMTPSA id v12sm37555675pjk.13.2019.07.23.11.05.09 (version=TLS1_3 cipher=AEAD-AES256-GCM-SHA384 bits=256/256); Tue, 23 Jul 2019 11:05:10 -0700 (PDT) Date: Tue, 23 Jul 2019 11:05:08 -0700 From: Stephen Hemminger To: Gavin Hu Cc: dev@dpdk.org, nd@arm.com, thomas@monjalon.net, jerinj@marvell.com, pbhagavatula@marvell.com, Honnappa.Nagarahalli@arm.com Message-ID: <20190723110508.1b68c1a9@hermes.lan> In-Reply-To: <1563896626-44862-6-git-send-email-gavin.hu@arm.com> References: <1563896626-44862-1-git-send-email-gavin.hu@arm.com> <1563896626-44862-6-git-send-email-gavin.hu@arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH v3 5/5] config: add WFE config entry for aarch64 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Tue, 23 Jul 2019 23:43:46 +0800 Gavin Hu wrote: > Add the RTE_USE_WFE configuration entry for aarch64, disabled by default. > It can be enabled selectively based on the performance benchmarking. > > Signed-off-by: Gavin Hu > Reviewed-by: Ruifeng Wang > Reviewed-by: Steve Capper > Reviewed-by: Honnappa Nagarahalli > Acked-by: Pavan Nikhilesh > --- > config/arm/meson.build | 1 + > config/common_armv8a_linux | 6 ++++++ > 2 files changed, 7 insertions(+) > > diff --git a/config/arm/meson.build b/config/arm/meson.build > index 979018e..496813a 100644 > --- a/config/arm/meson.build > +++ b/config/arm/meson.build > @@ -116,6 +116,7 @@ impl_dpaa = ['NXP DPAA', flags_dpaa, machine_args_generic] > impl_dpaa2 = ['NXP DPAA2', flags_dpaa2, machine_args_generic] > > dpdk_conf.set('RTE_FORCE_INTRINSICS', 1) > +dpdk_conf.set('RTE_USE_WFE', 0) > > if not dpdk_conf.get('RTE_ARCH_64') > dpdk_conf.set('RTE_CACHE_LINE_SIZE', 64) > diff --git a/config/common_armv8a_linux b/config/common_armv8a_linux > index 481712e..48c7ab5 100644 > --- a/config/common_armv8a_linux > +++ b/config/common_armv8a_linux > @@ -12,6 +12,12 @@ CONFIG_RTE_ARCH_64=y > > CONFIG_RTE_FORCE_INTRINSICS=y > > +# Use WFE instructions to implement the rte_wait_for_equal_xxx APIs, > +# calling these APIs put the cores enter low power state while waiting > +# for the memory address to be become equal to the expected value. > +# This is supported only by aarch64. > +CONFIG_RTE_USE_WFE=n > + > # Maximum available cache line size in arm64 implementations. > # Setting to maximum available cache line size in generic config > # to address minimum DMA alignment across all arm64 implementations. Introducing config options is a maintenance nightmare. How are distributions supposed to ship a package? Does full regression test get done on both options? The user should not be able to change this.