DPDK-dev Archive on lore.kernel.org
 help / color / Atom feed
* [dpdk-dev] [PATCH] net/vmxnet3: remove IP checksum from Tx/Rx offload capa
@ 2019-08-13 13:29 Maxime Leroy
  2019-08-19 21:56 ` Louis Luo
  0 siblings, 1 reply; 2+ messages in thread
From: Maxime Leroy @ 2019-08-13 13:29 UTC (permalink / raw)
  To: dev; +Cc: llouis, stable

The vmxnet3_prep_pkts function set rte_errno to ENOTSUP for any packets
having PKT_TX_IP_CHECKSUM set in ol_flags. But the vmxnet3 has
DEV_TX_OFFLOAD_IPV4_CKSUM set in this tx offload capa.

This issue has been introduced with the new Rx offload
API. DEV_TX_OFFLOAD_IPV4_CKSUM and DEV_RX_OFFLOAD_IPV4_CKSUM has been
added to the tx/rx offloads capa, but the vmxnet3 driver doesn't support
it.

To fix the issue, DEV_TX/RX_OFFLOAD_IPV4_CKSUM needs to be removed from
tx/rx offload capa.

Fixes: 95e4a96ccbf1 ("net/vmxnet3: convert to new Rx offload API")
Cc: llouis@vmware.com
Cc: stable@dpdk.org

Signed-off-by: Maxime Leroy <maxime.leroy@6wind.com>
---
 drivers/net/vmxnet3/vmxnet3_ethdev.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/drivers/net/vmxnet3/vmxnet3_ethdev.c b/drivers/net/vmxnet3/vmxnet3_ethdev.c
index 57feb377..9cd5eb65 100644
--- a/drivers/net/vmxnet3/vmxnet3_ethdev.c
+++ b/drivers/net/vmxnet3/vmxnet3_ethdev.c
@@ -44,7 +44,6 @@
 
 #define VMXNET3_TX_OFFLOAD_CAP		\
 	(DEV_TX_OFFLOAD_VLAN_INSERT |	\
-	 DEV_TX_OFFLOAD_IPV4_CKSUM |	\
 	 DEV_TX_OFFLOAD_TCP_CKSUM |	\
 	 DEV_TX_OFFLOAD_UDP_CKSUM |	\
 	 DEV_TX_OFFLOAD_TCP_TSO |	\
@@ -54,7 +53,6 @@
 	(DEV_RX_OFFLOAD_VLAN_STRIP |	\
 	 DEV_RX_OFFLOAD_VLAN_FILTER |   \
 	 DEV_RX_OFFLOAD_SCATTER |	\
-	 DEV_RX_OFFLOAD_IPV4_CKSUM |	\
 	 DEV_RX_OFFLOAD_UDP_CKSUM |	\
 	 DEV_RX_OFFLOAD_TCP_CKSUM |	\
 	 DEV_RX_OFFLOAD_TCP_LRO |	\
-- 
2.11.0


^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [dpdk-dev] [PATCH] net/vmxnet3: remove IP checksum from Tx/Rx offload capa
  2019-08-13 13:29 [dpdk-dev] [PATCH] net/vmxnet3: remove IP checksum from Tx/Rx offload capa Maxime Leroy
@ 2019-08-19 21:56 ` Louis Luo
  0 siblings, 0 replies; 2+ messages in thread
From: Louis Luo @ 2019-08-19 21:56 UTC (permalink / raw)
  To: Maxime Leroy, dev; +Cc: stable

Hi Maxime,

Thanks for the fix. Actually Yong and I had some discussion about removing TX IP CSUM offload flag last August and I did prepare a fix but later forgot to submit. Anyway your fix is fine.

Thanks,
Louis

On 8/13/19, 6:30 AM, "Maxime Leroy" <maxime.leroy@6wind.com> wrote:

    The vmxnet3_prep_pkts function set rte_errno to ENOTSUP for any packets
    having PKT_TX_IP_CHECKSUM set in ol_flags. But the vmxnet3 has
    DEV_TX_OFFLOAD_IPV4_CKSUM set in this tx offload capa.
    
    This issue has been introduced with the new Rx offload
    API. DEV_TX_OFFLOAD_IPV4_CKSUM and DEV_RX_OFFLOAD_IPV4_CKSUM has been
    added to the tx/rx offloads capa, but the vmxnet3 driver doesn't support
    it.
    
    To fix the issue, DEV_TX/RX_OFFLOAD_IPV4_CKSUM needs to be removed from
    tx/rx offload capa.
    
    Fixes: 95e4a96ccbf1 ("net/vmxnet3: convert to new Rx offload API")
    Cc: llouis@vmware.com
    Cc: stable@dpdk.org
    
    Signed-off-by: Maxime Leroy <maxime.leroy@6wind.com>
    ---
     drivers/net/vmxnet3/vmxnet3_ethdev.c | 2 --
     1 file changed, 2 deletions(-)
    
    diff --git a/drivers/net/vmxnet3/vmxnet3_ethdev.c b/drivers/net/vmxnet3/vmxnet3_ethdev.c
    index 57feb377..9cd5eb65 100644
    --- a/drivers/net/vmxnet3/vmxnet3_ethdev.c
    +++ b/drivers/net/vmxnet3/vmxnet3_ethdev.c
    @@ -44,7 +44,6 @@
     
     #define VMXNET3_TX_OFFLOAD_CAP		\
     	(DEV_TX_OFFLOAD_VLAN_INSERT |	\
    -	 DEV_TX_OFFLOAD_IPV4_CKSUM |	\
     	 DEV_TX_OFFLOAD_TCP_CKSUM |	\
     	 DEV_TX_OFFLOAD_UDP_CKSUM |	\
     	 DEV_TX_OFFLOAD_TCP_TSO |	\
    @@ -54,7 +53,6 @@
     	(DEV_RX_OFFLOAD_VLAN_STRIP |	\
     	 DEV_RX_OFFLOAD_VLAN_FILTER |   \
     	 DEV_RX_OFFLOAD_SCATTER |	\
    -	 DEV_RX_OFFLOAD_IPV4_CKSUM |	\
     	 DEV_RX_OFFLOAD_UDP_CKSUM |	\
     	 DEV_RX_OFFLOAD_TCP_CKSUM |	\
     	 DEV_RX_OFFLOAD_TCP_LRO |	\
    -- 
    2.11.0
    
    


^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, back to index

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-08-13 13:29 [dpdk-dev] [PATCH] net/vmxnet3: remove IP checksum from Tx/Rx offload capa Maxime Leroy
2019-08-19 21:56 ` Louis Luo

DPDK-dev Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/dpdk-dev/0 dpdk-dev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 dpdk-dev dpdk-dev/ https://lore.kernel.org/dpdk-dev \
		dev@dpdk.org dpdk-dev@archiver.kernel.org
	public-inbox-index dpdk-dev


Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.dpdk.dev


AGPL code for this site: git clone https://public-inbox.org/ public-inbox